chore(scripts): restore archived operator-probe commands; refresh maturity tracker (L1)#1053
Conversation
…urity tracker (L1) PR #1033 archived check-m13-migration.ts and check-july8-live-batch.ts into scripts/archive/ (collateral of a knip fix — an orphaned test referenced a deleted script) and dropped their package.json entries, but left five maintained operator docs still calling `npm run check:july8-live-batch` / `check:m13-migration` — turning the advisory docs:check-scripts gate red (6 stale references across launch-operator-runbook, operator-apply-july8-batch, operator-backlog, process-hardening, tenancy-defense-in-depth-review). Both are live-DB re-verification probes and import-clean from archive/ (no relative imports), so this restores the two package.json entries pointing at scripts/archive/. The documented operator commands work again and docs:check-scripts is green (330 refs resolve), with no operator-doc rewrites. scripts-index.md now records them as archived-but-runnable, and the maturity tracker's L1 (reconciled) and X3 (#1042/#1047; ClinicalDashboard now 4,140) rows are brought current. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Jc1ZYHFjXjn6mE6U6riVU
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates X3 decomposition progress, advances L1 one-shot script archival tracking, restructures archive-candidate documentation, adds npm commands, updates the ChangesBacklog and script archival
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #4395 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7d2fea018
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7d2fea018
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…chive-oneshot-scripts
…n probe The restored `check:m13-migration` operator command relied only on createAdminClient()/requireServerEnv(), so it could report PASS against a configured staging project — greenlighting the documented live M13 apply verification while production (sjrfecxgysukkwxsowpy) is still stale. Mirror the check-july8-live-batch production-target guard: reject a missing/mismatched or non-production Supabase project before touching the RPC. Addresses the Codex review findings on PR #1053. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LRZ1EyBZW1ADXrZvMxEEsC
…chive-oneshot-scripts
|
@codex please resolve failing CI testing |
|
Summary
Testing
|
Next depends on vulnerable sharp@0.34.5; pin the override and allowScripts entry so production audit --audit-level=high passes. Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Summary
Maturity L1 (archive one-shot scripts) — reconcile the aftermath of #1033's partial archive.
#1033 moved
check-m13-migration.tsandcheck-july8-live-batch.ts(plus the latter's.test.ts)into
scripts/archive/— collateral of a knip fix (an orphaned test intests/referenced adeleted script). It also dropped the two
package.jsonentries, but left five maintained operatordocs still calling
npm run check:july8-live-batch/check:m13-migration. That turned theadvisory
docs:check-scriptsgate red — 6 stale references acrosslaunch-operator-runbook,operator-apply-july8-batch,operator-backlog,process-hardening, andtenancy-defense-in-depth-review. It merged only because that gate is deliberately advisory (not inCI).
Both scripts are live-DB re-verification probes (the operator runbooks document their probe
semantics and re-run them to confirm production state). So the minimal, reversible fix is to
restore the two
package.jsonentries pointing atscripts/archive/— the documented operatorcommands work again and
docs:check-scriptsgoes green, with zero operator-doc rewrites.package.json: restoredcheck:m13-migrationandcheck:july8-live-batch→scripts/archive/….docs/scripts-index.md: the one-shot section now records these two as archived-but-runnable andkeeps the rest as candidates.
docs/maturity-backlog-workorders.md: L1 markedIN PROGRESSwith the fix: Phase 1 Maintenance and Staging Tenancy isolation #1033 → this-PR history andthe residual (backfill archiving; the dead
check-m13-migrationtoken inci-change-scope.mjs);X3 row/counts brought current (refactor(components): extract upload-desktop-layout store into a hook (maturity X3) #1042/test(clinical-dashboard): assert upload-layout hook wires useSyncExternalStore #1047; ClinicalDashboard now 4,140).
scripts/archive/check-m13-migration.ts: added a production-target guard (mirrorscheck-july8-live-batch) so the restored probe rejects a missing/mismatched or non-productionSupabase project before touching the RPC — resolving the Codex review finding that it could
otherwise report PASS against staging while production is still stale. This adds
@/lib/env+@/lib/supabase/projectimports to the probe.Verification
npm run typecheck— clean (with the new probe guard)npm run lint,npm run format:check— cleannpm run check:knip— no dead code (the restored entries reference the archived scripts)npm run docs:check-scripts— green, 330 npm-run references resolve (was 6 stale)npm run docs:check-links— repo path references resolvecheck-july8-live-batchguard and is covered by typecheck/lint.Risk and rollout
package.jsonscript entries pointing at already-present archived files, plusdoc updates and a conservative production-target guard on the M13 probe (makes it stricter, never
looser). No app runtime, schema, or CI behaviour changes; the probes are operator-invoked with live
keys and are not run by CI or this PR.
Clinical Governance Preflight
This is operator tooling —
package.jsonscript entries, docs, and a production-target guard on anoperator-invoked live-DB probe. It changes no app runtime, ingestion, answer-generation, or
source-governance behaviour. The checklist is completed because the probe file path
(
scripts/archive/check-m13-migration.ts) matches the policy classifier'smigrationpattern, andthe guard change strictly tightens the probe's production-target enforcement.
Clinical KB Database(sjrfecxgysukkwxsowpy) — the new guard enforces thisNotes
ci-change-scope.mjsdead token and thebackfill:*archivingare left as tracked residual work, not bundled into this fix.
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Chores
sharpoverride/allowlist to match the pinned version.Bug Fixes