test(ui): drop duplicate #015 content-first suites superseded by #1057#1067
Merged
Conversation
PR #1054 and PR #1057 independently resolved ledger #15, landing four overlapping content-first DOM suites on main. #1057's pair is a complete functional superset: - registry-record-loader.dom.test.tsx (8) strictly supersets registry-content-first.dom.test.tsx (4) — adds governance-absent passthrough, not_found, and unauthorized states. - medication-record-page.dom.test.tsx (6) covers everything medication-content-first.dom.test.tsx (7) did, including the graceful-degradation and governance-drop-on-error invariants, via rendered-badge assertions rather than spy-on-argument (more robust, matches repo convention). Remove the two now-redundant *-content-first.dom.test.tsx files. No loss of coverage; the surviving pair (14 tests) is green and the tree is type-clean. Test-only; no source/behaviour change. RAG impact: no retrieval behaviour change — tests-only, no retrieval/ranking/selection/eval or product code touched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UbhUVWVJRwDibC2YtJ6aRX
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (2)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
BigSimmo
marked this pull request as ready for review
July 22, 2026 04:59
BigSimmo
enabled auto-merge (squash)
July 22, 2026 05:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup. PR #1054 and PR #1057 independently resolved ledger item #15, landing four overlapping content-first DOM suites on
main. #1057's pair is a complete functional superset, so this removes the two now-redundant files from #1054 — no loss of coverage.tests/registry-record-loader.dom.test.tsx(8 tests) strictly supersets the deletedtests/registry-content-first.dom.test.tsx(4) — it additionally covers governance-absent passthrough,not_found, andunauthorizedstates.tests/medication-record-page.dom.test.tsx(6 tests) covers everything the deletedtests/medication-content-first.dom.test.tsx(7) did — including the graceful-degradation and governance-drop-on-error invariants — via rendered-badge assertions rather than spy-on-argument, which is more robust and matches repo convention. (The one "error text not shown" assertion in the deleted file was redundant: the component'srecord ? … : errorbranch means a rendered record already precludes the error panel.)Net: the surviving #1057 pair (14 tests) is the single canonical home for the #15 content-first coverage.
RAG impact: no retrieval behaviour change — tests-only, no retrieval/ranking/selection/eval or product code touched.
Verification
npx vitest runon the surviving pair (medication-record-page.dom.test.tsx,registry-record-loader.dom.test.tsx) — 14/14 passnpm run typecheck— cleannpm run verify:pr-local— this PR only deletes two redundant test files (no source/config/behaviour change); the surviving suites pass and CI runs the full gate.npm run verify:ui— N/A (no UI/routing/styling/motion change)npm run verify:release— N/A (no release/handoff claim)Risk and rollout
Clinical Governance Preflight
N/A — tests-only deletion. No ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output surface is touched.
Notes
Generated by Claude Code