Skip to content

test(ui): drop duplicate #015 content-first suites superseded by #1057#1067

Merged
BigSimmo merged 3 commits into
mainfrom
claude/site-audit-quick-wins-21v9gb
Jul 22, 2026
Merged

test(ui): drop duplicate #015 content-first suites superseded by #1057#1067
BigSimmo merged 3 commits into
mainfrom
claude/site-audit-quick-wins-21v9gb

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Cleanup. PR #1054 and PR #1057 independently resolved ledger item #15, landing four overlapping content-first DOM suites on main. #1057's pair is a complete functional superset, so this removes the two now-redundant files from #1054no loss of coverage.

  • tests/registry-record-loader.dom.test.tsx (8 tests) strictly supersets the deleted tests/registry-content-first.dom.test.tsx (4) — it additionally covers governance-absent passthrough, not_found, and unauthorized states.
  • tests/medication-record-page.dom.test.tsx (6 tests) covers everything the deleted tests/medication-content-first.dom.test.tsx (7) did — including the graceful-degradation and governance-drop-on-error invariants — via rendered-badge assertions rather than spy-on-argument, which is more robust and matches repo convention. (The one "error text not shown" assertion in the deleted file was redundant: the component's record ? … : error branch means a rendered record already precludes the error panel.)

Net: the surviving #1057 pair (14 tests) is the single canonical home for the #15 content-first coverage.

RAG impact: no retrieval behaviour change — tests-only, no retrieval/ranking/selection/eval or product code touched.

Verification

  • npx vitest run on the surviving pair (medication-record-page.dom.test.tsx, registry-record-loader.dom.test.tsx) — 14/14 pass
  • npm run typecheck — clean
  • Verification not run: npm run verify:pr-local — this PR only deletes two redundant test files (no source/config/behaviour change); the surviving suites pass and CI runs the full gate.
  • npm run verify:ui — N/A (no UI/routing/styling/motion change)
  • npm run verify:release — N/A (no release/handoff claim)

Risk and rollout

Clinical Governance Preflight

N/A — tests-only deletion. No ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output surface is touched.

Notes


Generated by Claude Code

PR #1054 and PR #1057 independently resolved ledger #15, landing four
overlapping content-first DOM suites on main. #1057's pair is a complete
functional superset:

- registry-record-loader.dom.test.tsx (8) strictly supersets
  registry-content-first.dom.test.tsx (4) — adds governance-absent
  passthrough, not_found, and unauthorized states.
- medication-record-page.dom.test.tsx (6) covers everything
  medication-content-first.dom.test.tsx (7) did, including the
  graceful-degradation and governance-drop-on-error invariants, via
  rendered-badge assertions rather than spy-on-argument (more robust,
  matches repo convention).

Remove the two now-redundant *-content-first.dom.test.tsx files. No loss
of coverage; the surviving pair (14 tests) is green and the tree is
type-clean.

Test-only; no source/behaviour change. RAG impact: no retrieval
behaviour change — tests-only, no retrieval/ranking/selection/eval or
product code touched.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UbhUVWVJRwDibC2YtJ6aRX
@supabase

supabase Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (2)
  • tests/medication-content-first.dom.test.tsx
  • tests/registry-content-first.dom.test.tsx
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: aff65908-978b-4b9e-aec2-0edbe696305f

📥 Commits

Reviewing files that changed from the base of the PR and between 7dcf514 and 1385987.

📒 Files selected for processing (2)
  • tests/medication-content-first.dom.test.tsx
  • tests/registry-content-first.dom.test.tsx

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/site-audit-quick-wins-21v9gb

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo marked this pull request as ready for review July 22, 2026 04:59
@BigSimmo
BigSimmo enabled auto-merge (squash) July 22, 2026 05:02
@BigSimmo
BigSimmo merged commit d84bb90 into main Jul 22, 2026
17 checks passed
@BigSimmo
BigSimmo deleted the claude/site-audit-quick-wins-21v9gb branch July 22, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants