docs(issues): capture source-governance audit deferrals (#025-#030)#1072
Conversation
The source-governance audit (PR #1051) shipped its safe subset and deferred the rest. Those deferrals lived only in the PR body and session context, so they would have been lost once #1051 merged. Capture them in the durable ledger. Most important: #25 records that the audit's ranking findings (review_due has no ranking penalty, unknownCurrentnessPenalty ships at 0, bestSource ignores governance) are NOT debt to pay down — they are deliberate, measured decisions. Blanket governance weighting in selection ordering was measured on 2026-07-02 to regress the golden eval to 16/23 (doc-recall@5 1.0->0.76) because the corpus is only partially metadata-enriched and normalizeSourceMetadata coerces unenriched docs to unknown, so "unknown" != "bad". Filing them as open tasks would have invited a future session to re-introduce a known regression, so the row is written as a guardrail with the measurement attached. Also captured: #26 LLM-prompt governance context, #27 cache stale-governance residual, #28 threshold-conflict scope, #29 implicit is_public visibility, #30 D5 flag decision. Audit item 12 (canary automation) is deliberately not filed - already covered by the blocking pr-policy RAG-impact gate plus the weekly scheduled 44-case canary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe outstanding issues ledger adds open entries ChangesOutstanding issues ledger
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@codex fix branch conflicts please |
|
Summary
Testing
Status
|
|
@coded please resolve the branch conflict for me so it actually resolves it and commit and push here |
|
@codex please resolve branch conflict and commit and push here |
Summary
Testing
|
Co-authored-by: Cursor <cursoragent@cursor.com>
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #4453 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21c1b72e80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/outstanding-issues.md`:
- Around line 61-66: Update the PR description’s stated objectives to reference
the newly added ledger entries `#032`–#037 instead of `#025`–#030. Keep the existing
issue IDs and details unchanged, and ensure the description accurately reflects
the committed changes in docs/outstanding-issues.md.
- Line 62: Update the `#033` entry in docs/outstanding-issues.md to replace the
stale cross-reference to `#025` with `#032`, leaving the governance metadata
description and surrounding issue details unchanged.
- Line 30: Restore the missing `#031` entry in docs/outstanding-issues.md between
`#030` and `#032`, or consistently renumber the affected rows and issues:next-id
marker together. Update the `#033` entry’s reference from `#025` to `#032` while
preserving the ledger’s sequential numbering.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 43766263-fc68-4a7f-b8fb-5a1180313fd8
📒 Files selected for processing (1)
docs/outstanding-issues.md
|
@codex Connector push test: resolve the current merge conflict by merging origin/main into the existing PR branch claude/capture-governance-audit-deferrals, preserve both the current main ledger entries and this PR's governance deferrals, create one conflict-resolution commit, and push that commit to the same PR branch. This explicitly authorizes GitHub read/write operations for PR #1072. Do not rebase, force-push, merge the PR, change unrelated files, or create a second PR. Reply with the pushed commit SHA or the exact push failure. |
Summary
Push result
Testing
|
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. ❌ Failed to clone repository into sandbox. Please try again. |
Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Summary
The source-governance audit shipped its regression-safe subset in #1051 and deferred the rest. Those deferrals existed only in #1051's PR body and session context ΓÇö so once #1051 merges they'd effectively vanish from the repo's durable memory. This captures them in
docs/outstanding-issues.md(6 rows,#025ΓÇô#030).The important one is
#025. The audit reported three ranking "gaps":review_duecarries no ranking penalty,unknownCurrentnessPenaltyships at0, andselectBestSourceRecommendationignores governance metadata. Filing those as open tasks would have been actively harmful ΓÇö they are deliberate, measured decisions, not debt:So
#025is written as a guardrail with the measurement attached, not a todo ΓÇö it exists to stop a future session "fixing" a known regression back into the ranker.The rest are genuine, correctly-scoped follow-ups:
#026eval:rag+ approval; same "unknown Γëá bad" hazard)#027#028#029is_publicflag ΓÇö visibility is implicitowner_id IS NULL#030NEXT_PUBLIC_RAG_TRUST_CAP_ALL_CLAIMSparked OFF (product decision)Audit item 12 (canary automation) is deliberately not filed ΓÇö already covered by the blocking
pr-policyRAG-impact gate plus the weekly scheduled 44-case canary. Filing it would be a false todo.Verification
npx prettier --check docs/outstanding-issues.mdΓÇö cleannpm run docs:check-linksΓÇö passed, 1103 repo path references resolveDocs-only; no code, no behaviour, no provider calls. The non-
#025ΓÇô#030line changes are prettier re-padding the aligned markdown table (whitespace only) because the new Detail cells are the widest in the column.Risk and rollout
🤖 Generated with Claude Code
Summary by CodeRabbit
Summary by CodeRabbit
#032–#037), including priority/type, summaries, and next actions.Sweep note
Governance audit deferrals landed as #32-#37 (not #25-#30) because main already used #25-#30 for webhook/observability items;
next-id=038.