docs(issues): correct #018/#019 root causes from run #61 artifact; add #029/#030#1074
Conversation
/#30 Both items were filed as retrieval problems. Mining the run #61 --dump-answers and golden-retrieval artifacts (zero spend, read-only) shows both are ANSWER-STAGE defects, and retrieval is healthy in each case. #18 - not retrieval-depth. Retrieval is grounded with 4-6 citations and high_confidence_extractive_retrieval. lithium + adhd return the source_backed_review_fallback boilerplate stub with answer_sections: []; metabolic returns a mangled 73-char fragment. The prior "live chunk sets surface no admissible schedule sentence" note was an inference, not a measurement, and is falsified: the chunk sets were never exercised because no answer was composed. Also records that widening the eval matcher would be harmful (the stub echoes monitoring/maintenance/level/range and would falsely pass). #19 - not comparison-class retrieval coverage. Golden retrieval scores documentRecallAt5=1, reciprocalRankAt10=1, missingDocumentSubstrings=[], with "Admission of Community Patients (AKG).pdf" at raw rank 4-5 satisfying the strict AdmissionCommunityPts alias. The answer stage then drops it from answer.sources top-5 and promotes an off-topic doc from raw rank 8. New: #29 (12/30 cases return the fallback stub; targeting masks it for keyword-only intents) and #30 (wide-tier alias lets one doc satisfy both comparison slots - latent false-pass). No code fix included: both root causes sit on protected RAG surfaces and require a provider-backed eval/canary pair plus explicit approval. Docs-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70b10635cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What
Corrects the recorded root causes for #18 and #19, and files two new findings (#29, #30). Docs-only —
docs/outstanding-issues.md.Why
Both items were filed as retrieval problems. Mining the run #61
--dump-answersandgolden-retrievalartifacts (zero spend, read-only) shows both are answer-stage defects, with healthy retrieval in each case.#18 — not retrieval-depth
Retrieval is
grounded=true, 4–6 citations,high_confidence_extractive_retrieval. The answers are:quality-lithium-monitoring-range/quality-adhd-medication-monitoring→ thesource_backed_review_fallbackboilerplate stub, withanswer_sections: []quality-antipsychotic-metabolic-monitoring→ a mangled 73-char fragment: "The guidance for metabolic is that compliance, monitoring and evaluation."The prior note — "their live chunk sets apparently surface no admissible schedule sentence" — was an inference, not a measurement, and is falsified: the chunk sets were never exercised because no answer was composed.
Also recorded: do not widen the eval matcher. The stub contains
monitoring/maintenance/level/range, so wideningrag-eval-cases.ts:192to production vocabulary would make these stubs falsely pass. The narrow matcher is doing its job.#19 — not comparison-class retrieval coverage
Golden retrieval for this exact case:
documentRecallAt5=1,reciprocalRankAt10=1,missingDocumentSubstrings=[],failures=[], with "Admission of Community Patients (AKG).pdf" at raw rank 4–5, satisfying the strictAdmissionCommunityPtsalias.The answer stage then drops it from
answer.sourcestop-5 and promotes "Falls Prevention and Management (AKG).pdf" — raw rank 8, off-topic — in its place. Suspect:balanceCrossDocumentResults/rankAnswerEvidence.Separately noted: nothing guarantees both sides of a comparison are represented —
comparison_multi_document_gate(rag.ts:2043) is satisfied by any 2 distinct docs, including two discharge-side ones.New items
Scope / safety
RAG impact:line required (pr-policy keys on code paths).prettier --check✓,docs:check-links✓ (1104 refs resolve).🤖 Generated with Claude Code