Skip to content

docs(issues): correct #018/#019 root causes from run #61 artifact; add #029/#030#1074

Merged
BigSimmo merged 3 commits into
mainfrom
claude/rag-018-019-root-cause
Jul 22, 2026
Merged

docs(issues): correct #018/#019 root causes from run #61 artifact; add #029/#030#1074
BigSimmo merged 3 commits into
mainfrom
claude/rag-018-019-root-cause

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

What

Corrects the recorded root causes for #18 and #19, and files two new findings (#29, #30). Docs-only — docs/outstanding-issues.md.

Why

Both items were filed as retrieval problems. Mining the run #61 --dump-answers and golden-retrieval artifacts (zero spend, read-only) shows both are answer-stage defects, with healthy retrieval in each case.

#18 — not retrieval-depth

Retrieval is grounded=true, 4–6 citations, high_confidence_extractive_retrieval. The answers are:

  • quality-lithium-monitoring-range / quality-adhd-medication-monitoring → the source_backed_review_fallback boilerplate stub, with answer_sections: []
  • quality-antipsychotic-metabolic-monitoring → a mangled 73-char fragment: "The guidance for metabolic is that compliance, monitoring and evaluation."

The prior note — "their live chunk sets apparently surface no admissible schedule sentence" — was an inference, not a measurement, and is falsified: the chunk sets were never exercised because no answer was composed.

Also recorded: do not widen the eval matcher. The stub contains monitoring/maintenance/level/range, so widening rag-eval-cases.ts:192 to production vocabulary would make these stubs falsely pass. The narrow matcher is doing its job.

#19 — not comparison-class retrieval coverage

Golden retrieval for this exact case: documentRecallAt5=1, reciprocalRankAt10=1, missingDocumentSubstrings=[], failures=[], with "Admission of Community Patients (AKG).pdf" at raw rank 4–5, satisfying the strict AdmissionCommunityPts alias.

The answer stage then drops it from answer.sources top-5 and promotes "Falls Prevention and Management (AKG).pdf" — raw rank 8, off-topic — in its place. Suspect: balanceCrossDocumentResults / rankAnswerEvidence.

Separately noted: nothing guarantees both sides of a comparison are represented — comparison_multi_document_gate (rag.ts:2043) is satisfied by any 2 distinct docs, including two discharge-side ones.

New items

Scope / safety

  • No code fix included. Both root causes sit on protected RAG surfaces and require a provider-backed eval/canary pair plus explicit approval. Shipping an unvalidated fix here is precisely the "offline-green is insufficient" trap.
  • Docs-only → no RAG impact: line required (pr-policy keys on code paths).
  • Gates: prettier --check ✓, docs:check-links ✓ (1104 refs resolve).

🤖 Generated with Claude Code

/#30

Both items were filed as retrieval problems. Mining the run #61 --dump-answers
and golden-retrieval artifacts (zero spend, read-only) shows both are
ANSWER-STAGE defects, and retrieval is healthy in each case.

#18 - not retrieval-depth. Retrieval is grounded with 4-6 citations and
high_confidence_extractive_retrieval. lithium + adhd return the
source_backed_review_fallback boilerplate stub with answer_sections: [];
metabolic returns a mangled 73-char fragment. The prior "live chunk sets
surface no admissible schedule sentence" note was an inference, not a
measurement, and is falsified: the chunk sets were never exercised because
no answer was composed. Also records that widening the eval matcher would be
harmful (the stub echoes monitoring/maintenance/level/range and would falsely
pass).

#19 - not comparison-class retrieval coverage. Golden retrieval scores
documentRecallAt5=1, reciprocalRankAt10=1, missingDocumentSubstrings=[], with
"Admission of Community Patients (AKG).pdf" at raw rank 4-5 satisfying the
strict AdmissionCommunityPts alias. The answer stage then drops it from
answer.sources top-5 and promotes an off-topic doc from raw rank 8.

New: #29 (12/30 cases return the fallback stub; targeting masks it for
keyword-only intents) and #30 (wide-tier alias lets one doc satisfy both
comparison slots - latent false-pass).

No code fix included: both root causes sit on protected RAG surfaces and
require a provider-backed eval/canary pair plus explicit approval. Docs-only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • docs/outstanding-issues.md
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f34c87ed-bebf-44bb-971c-ac7fd3e70d92

📥 Commits

Reviewing files that changed from the base of the PR and between 46f143d and 12d7a1a.

📒 Files selected for processing (1)
  • docs/outstanding-issues.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/rag-018-019-root-cause

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70b10635cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/outstanding-issues.md
@BigSimmo
BigSimmo enabled auto-merge (squash) July 22, 2026 07:06
@BigSimmo
BigSimmo merged commit 12fe707 into main Jul 22, 2026
17 checks passed
@BigSimmo
BigSimmo deleted the claude/rag-018-019-root-cause branch July 22, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant