test: stabilize document viewer navigation in Firefox#1083
Merged
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
📝 WalkthroughWalkthroughThe UI smoke test adds a helper for React-event-aware activation of document viewer disclosure tabs and updates Images, Text, and Summary assertions for visibility and mutual exclusivity. ChangesViewer disclosure navigation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAG impact: no retrieval behaviour change — Playwright test reliability only; production code is unchanged.
Verification
document viewer content disclosures are naturally closed and mutually exclusive by default.npm run ensureserver — 1 passed.npm run verify:cheap— passed.npm run verify:ui— 265 Chromium production scenarios passed.npm run verify:pr-local -- --files tests/ui-smoke.spec.ts— passed; format, lint, typecheck, full unit suite, offline RAG fixtures; build correctly skipped by scope selector.Verification not run: live provider tests and live RAG evaluation were not relevant; no application behavior changed.
Risk and rollout
7eed83d37.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
mainand were not duplicated.Note
Low Risk
Test-only change in
tests/ui-smoke.spec.ts; no application or RAG behavior modified.Overview
Stabilizes the Playwright smoke test document viewer content disclosures are naturally closed and mutually exclusive by default by changing how Images, Summary, and Text section links are activated.
Instead of pointer
.click()on the document viewer nav, the test now uses a smallclickViewerNavhelper that waits for the link’s ReactonClickhandler, then drives the same focus + Enter path asactivateFocusedControl—matching the rationale already used elsewhere in this file when pdf.js layout shifts make Firefox pointer hits flaky.Production behavior is unchanged; this is test reliability only.
Reviewed by Cursor Bugbot for commit 7eed83d. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit