Skip to content

test: stabilize document viewer navigation in Firefox#1083

Merged
BigSimmo merged 1 commit into
mainfrom
codex/reconcile-browser-matrix
Jul 22, 2026
Merged

test: stabilize document viewer navigation in Firefox#1083
BigSimmo merged 1 commit into
mainfrom
codex/reconcile-browser-matrix

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Wait for React click handlers before activating document-viewer section links.
  • Use the existing focused keyboard activation helper so Firefox is not dependent on pointer coordinates during disclosure layout changes.
  • Reject the remaining archived browser hunks because they were duplicates, unrelated styling, or passed current-main reproduction.

RAG impact: no retrieval behaviour change — Playwright test reliability only; production code is unchanged.

Verification

  • Current-main targeted matrix: 40 passed, 1 skipped, 1 Firefox failure in document viewer content disclosures are naturally closed and mutually exclusive by default.
  • Focused Firefox iteration against identity-verified npm run ensure server — 1 passed.
  • Final isolated production targeted matrix, Chromium + Firefox + WebKit — 3 passed.
  • npm run verify:cheap — passed.
  • npm run verify:ui — 265 Chromium production scenarios passed.
  • npm run verify:pr-local -- --files tests/ui-smoke.spec.ts — passed; format, lint, typecheck, full unit suite, offline RAG fixtures; build correctly skipped by scope selector.

Verification not run: live provider tests and live RAG evaluation were not relevant; no application behavior changed.

Risk and rollout

  • Risk: low; one browser expectation now uses the same keyboard activation path already exercised elsewhere in the document viewer.
  • Rollback: revert commit 7eed83d37.
  • Provider or production effects: None. Test-only change.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • Service-worker isolation and the PWA exception were already on main and were not duplicated.
  • No archived retry wrappers, engine-specific stale expectations, or formulation styling changes were copied.

Note

Low Risk
Test-only change in tests/ui-smoke.spec.ts; no application or RAG behavior modified.

Overview
Stabilizes the Playwright smoke test document viewer content disclosures are naturally closed and mutually exclusive by default by changing how Images, Summary, and Text section links are activated.

Instead of pointer .click() on the document viewer nav, the test now uses a small clickViewerNav helper that waits for the link’s React onClick handler, then drives the same focus + Enter path as activateFocusedControl—matching the rationale already used elsewhere in this file when pdf.js layout shifts make Firefox pointer hits flaky.

Production behavior is unchanged; this is test reliability only.

Reviewed by Cursor Bugbot for commit 7eed83d. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Tests
    • Improved UI smoke test coverage for document viewer disclosure tabs.
    • Verified tab navigation, viewport visibility, mutual exclusivity, and behavior under print preview conditions.

@supabase

supabase Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The UI smoke test adds a helper for React-event-aware activation of document viewer disclosure tabs and updates Images, Text, and Summary assertions for visibility and mutual exclusivity.

Changes

Viewer disclosure navigation

Layer / File(s) Summary
React-aware disclosure tab flow
tests/ui-smoke.spec.ts
Adds clickViewerNav for focused tab activation and uses it across Images, Text, and Summary disclosure checks, including viewport visibility and mutually exclusive open states.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: claude, copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the test-only Firefox navigation stabilization in the document viewer.
Description check ✅ Passed The description matches the template with completed Summary, Verification, Risk and rollout, Clinical Governance, and Notes sections.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/reconcile-browser-matrix

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit 0afa0a5 into main Jul 22, 2026
20 of 21 checks passed
@BigSimmo
BigSimmo deleted the codex/reconcile-browser-matrix branch July 22, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant