Correct account sync and sign-in claims#1087
Merged
Merged
Conversation
Align account copy with the actual favourites/preferences persistence model and browser-session recents. Clearly disable unavailable SSO options while preserving configured Google and Microsoft OAuth. Verified with focused DOM tests, verify:cheap, verify:ui, and verify:pr-local.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughChangesAuthentication UI updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/clinical-dashboard/account-setup-dialog.tsx`:
- Around line 291-303: Update the disabled provider buttons to follow the
required accessibility pattern: in
src/components/clinical-dashboard/account-setup-dialog.tsx:291-303, add a
per-provider connected sr-only description and make the title end with “coming
soon”; apply the same Apple-button title and connected description changes in
src/components/clinical-dashboard/auth-panel.tsx:247-271, while retaining the
existing connected description and updating only the title in
src/components/clinical-dashboard/settings-dialog.tsx:1146-1181. Update
corresponding title and accessible-description assertions in
tests/favourites-auth-gate.dom.test.tsx:153-157,
tests/auth-panel-product-truth.dom.test.tsx:44-48, and
tests/settings-dialog-actions.dom.test.tsx:147-151.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 135634c2-89ca-4f1d-bdfc-e181cc9f3b63
📒 Files selected for processing (7)
src/components/clinical-dashboard/account-setup-dialog.tsxsrc/components/clinical-dashboard/auth-panel.tsxsrc/components/clinical-dashboard/settings-dialog.tsxtests/auth-panel-product-truth.dom.test.tsxtests/favourites-auth-gate.dom.test.tsxtests/settings-dialog-actions.dom.test.tsxtests/ui-smoke.spec.ts
Use the repository's coming-soon tooltip and connected screen-reader description pattern for unavailable providers. Focused DOM tests, ESLint, and typecheck pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run verify:pr-local— passed: format, lint, typecheck, 363 Vitest files / 3,220 passed / 1 skipped, production build/client secret scan, offline RAG 36/36.npm run verify:ui— passed: 265 Chromium scenarios across desktop/mobile, reduced motion, forced colors, zoom, axe, focus, and overflow.npm run verify:release— Verification not run: this is one sequential reconciliation PR; the final aggregate release gate is reserved for the fully reconciledmainstate.npm run check:production-readiness— static checks ran; credential-dependent readiness was not completed because this isolated worktree intentionally has no.env.localSupabase/OpenAI values. No provider call was made.Risk and rollout
RAG impact: no retrieval behaviour change — account copy, disabled-provider presentation, and UI tests only.
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
/api/account/favourites,/api/account/preferences, and browser-session recent-query storage.Summary by CodeRabbit