fix(ui): restore edge-to-edge phone search dock (no white strip) by BigSimmo · Pull Request #1090 · BigSimmo/Database

BigSimmo · 2026-07-23T10:59:28Z

Summary

Fix the phone bottom search bar white strip so the dock remains edge-to-edge: dock chrome reaches the viewport edge while the pill stays inset by safe-area padding.

Changes

Pin the ClinicalDashboard phone shell with fixed inset-0 and remove the phone dvh clamp that could leave an iOS Safari toolbar dead band.
Keep bottom docks at bottom: 0 and paint the safe-area region as dock chrome.
Strengthen the footer scrim and its reduced-transparency/no-blur fallbacks.
Tighten phone geometry assertions and cover /factsheets mode-home placement.
Merge current origin/main into the PR branch so hosted checks validate the exact landing tree.

Verification

npm run ensure — passed; identity-checked local app at http://localhost:3202.
node scripts/run-playwright.mjs tests/ui-tools.spec.ts --project=chromium --grep "phone mode homes keep|phone bottom search dock stays" — 2 passed.
node scripts/run-playwright.mjs tests/ui-tools.spec.ts --project=webkit --grep "phone mode homes keep|phone bottom search dock stays" — 2 passed.
Synthetic merge tree against current origin/main: 0a97a16e9f5e90363967d6afbc77f6cf0684e994; actual merge commit has the same tree.
Hosted required checks: pending for head 761de7e9ad623b6bd8d634d849a9eb465d622e48.

Checks not run locally

Full npm run verify:ui and npm run verify:pr-local were not repeated locally: the original PR head passed hosted unit/build/production UI checks, and this current-main tree received focused Chromium and WebKit coverage. The refreshed hosted required checks are the landing gate.

RAG impact: no retrieval behaviour change — UI shell/CSS/composer layout only.

Risk and rollback

Risk: low-to-moderate UI layout risk, concentrated in phone viewport and safe-area behavior.
Rollback: revert this PR.
Provider/production effects: none beyond the normal Railway deployment after merge to main.

Summary by CodeRabbit

Bug Fixes
- Improved the mobile search dock’s edge-to-edge appearance and safe-area handling.
- Prevented unwanted gaps or clipping when command and search panels are open.
- Improved fallback behavior on devices without backdrop blur support.
- Corrected mobile app shell sizing and scrolling behavior.
- Ensured the shared search experience remains consistent on Factsheets and other phone home screens.

Stop the white strip under the bottom search bar by pinning the ClinicalDashboard phone shell with fixed inset-0 (no 100dvh dead band), forcing dock bottom:0 with safe-area as internal padding, and painting opaque dock chrome through the home-indicator band. Tighten Playwright geometry asserts and cover factsheets mode-home hero placement. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

coderabbitai · 2026-07-23T10:59:34Z

📝 Walkthrough

Walkthrough

Phone dock scrims, edge-to-edge positioning, mobile shell sizing, composer reserve documentation, and UI regression tests were updated for small-screen safe-area behavior.

Changes

Phone dock edge and mobile shell layout

Layer / File(s)	Summary
Dock edge rendering and scroll behavior `src/app/globals.css`	Dock scrim gradients, fallback opacity thresholds, edge selectors, compact padding, and scroll-hide behavior were updated.
Mobile shell sizing and reserve documentation `src/app/globals.css`, `src/components/ClinicalDashboard.tsx`, `src/components/clinical-dashboard/global-search-shell.tsx`	Small-screen shell sizing and positioning were adjusted, and phone dock reserve behavior comments were clarified.
Phone dock regression coverage `tests/ui-tools.spec.ts`	Factsheets mode-home coverage was added, edge alignment assertions were tightened, and safe-area geometry validation was added.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

BigSimmo/Database#421: Updates the same phone dock edge masking and gradient rules.
BigSimmo/Database#922: Related to mobile dock safe-area reservation and regression coverage.
BigSimmo/Database#1027: Related to phone mode-home composer placement and dock reserve behavior.

Suggested labels: codex

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely summarizes the main UI fix to the phone search dock.
Description check	✅ Passed	The PR body includes summary, changes, verification, and risk/rollback details, with only minor template-format omissions like the checklist and notes.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cursor/fix-phone-dock-edge-1b1d

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

supabase · 2026-07-23T10:59:35Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Revert ModeHomeHero data-testid to avoid duplicating ModeHomeTemplate ids. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

Compress shell comments so the file stays within the 4140-line no-growth hotspot cap enforced by Static PR checks. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

github-actions · 2026-07-23T11:18:11Z

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

Static PR checks — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #4517 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

Static PR checks failed format:check on tests/ui-tools.spec.ts. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

BigSimmo · 2026-07-23T12:20:40Z

@codex review this PR for any issues

chatgpt-codex-connector · 2026-07-23T12:24:20Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: c993975f6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cursoragent and others added 2 commits July 23, 2026 10:59

test(ui): use stable differentials query for dock edge assert

4b91126

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

cursoragent and others added 3 commits July 23, 2026 11:03

fix(ui): apply ModeHomeHero testId for factsheets home coverage

5f65a18

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

test(ui): assert factsheets home via factsheets-home-main

708715b

Revert ModeHomeHero data-testid to avoid duplicating ModeHomeTemplate ids. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

fix(ui): keep ClinicalDashboard under maintainability line budget

b2f37c4

Compress shell comments so the file stays within the 4140-line no-growth hotspot cap enforced by Static PR checks. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

style(test): prettier-format edge-to-edge dock assert

c993975

Static PR checks failed format:check on tests/ui-tools.spec.ts. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

BigSimmo marked this pull request as ready for review July 23, 2026 11:57

Merge origin/main into PR #1090

761de7e

BigSimmo merged commit 09028ef into main Jul 23, 2026
19 checks passed

BigSimmo deleted the cursor/fix-phone-dock-edge-1b1d branch July 23, 2026 14:29

BigSimmo mentioned this pull request Jul 23, 2026

docs: align reconciliation findings and review evidence #1094

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): restore edge-to-edge phone search dock (no white strip)#1090

fix(ui): restore edge-to-edge phone search dock (no white strip)#1090
BigSimmo merged 7 commits into
mainfrom
cursor/fix-phone-dock-edge-1b1d

BigSimmo commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

supabase Bot commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

BigSimmo commented Jul 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

BigSimmo commented Jul 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Verification

Checks not run locally

Risk and rollback

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

supabase Bot commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026

CI triage

Uh oh!

BigSimmo commented Jul 23, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BigSimmo commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading