Document rejected RAG canary findings#1093
Conversation
Prevent unrelated structured tables from satisfying medication monitoring threshold queries. Preserve the clinical subject through retrieval selection and document the remaining distinct RAG issues.\n\nVerified with focused Vitest, eval:rag:offline, verify:cheap, verify:pr-local, production-readiness, and a narrow live lithium diagnostic.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This reverts commit fd31318.
|
Post-canary |
Correct the monitoring-miss diagnosis and capture the two distinct answer-gate failures observed on byte-identical trees. Preserve the rejected lithium candidate as an archive-only follow-up and explicitly stop immediate live retries.
|
Reverted confirmation run |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 369414187a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Use the green main baseline and reverted confirmation as the byte-identical comparison, and describe the candidate run separately.
Summary
RAG impact: no retrieval behaviour change — candidate
fd3131803was reverted by9236ce981; the final PR tree differs fromorigin/mainonly indocs/outstanding-issues.md.Verification
npm run format:changedgit diff --check30007833352: golden retrieval recall 1.0, zero reciprocal-rank regressions; answer gate failed unsupported-route p9530009207429: golden retrieval recall 1.0; answer gate failed differently on citation failureCode tests/build not rerun after the final docs-only commit: the code diff is empty and the candidate had already passed
verify:cheapandverify:pr-localbefore being reverted.UI verification not run: documentation only.
Risk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
refs/archive/rejected-rag/20260723/monitoring-subject-gate.Note
Low Risk
Documentation-only; no application code, deployment, or RAG behavior changes.
Overview
Updates
docs/outstanding-issues.mdonly—no runtime or retrieval changes (reverted RAG experiment; tree matchesmainaside from this doc).Adds a 2026-07-23 RAG reconciliation callout that supersedes the single-composer story in #18: lithium, ADHD, metabolic, and admission misses are documented as separate mechanisms (e.g. lithium fast-path, ADHD extractive budget, metabolic prose selection; #19 stays post-retrieval comparison). It notes the reverted lithium subject-evidence guard, archive ref
refs/archive/rejected-rag/20260723/monitoring-subject-gate, keeps #29 for remaining fallback stubs, and defers further RAG tuning without a reproducer + passing canary pair.Introduces P2 #51 to stabilise the live answer-quality canary before more RAG work: two byte-identical-tree runs passed golden retrieval but failed the answer gate for different reasons (unsupported-route p95 vs citation failure). Next action is gate/diagnostic work, not immediate retries.
Bumps the issues tracker
next-idto 052 and surfaces #51 at the top of the open-items table.Reviewed by Cursor Bugbot for commit 3694141. Configure here.