Skip to content

Fix single-run canary trend classification #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 1 commit into from
Jul 23, 2026
+28 −6
Merged

Fix single-run canary trend classification #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions scripts/eval-trend.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,22 @@ export function buildAnswerQualityVariabilityRows(payloads) {
const providerSignatures = fingerprints.map(({ provider }) => stableSignature(provider));
const latencySignatures = fingerprints.map(({ latency }) => stableSignature(latency));
const repeatedContentFailure =
allEqual(contentSignatures) && fingerprints.every(({ content }) => content.categories.length > 0);
let classification = "stable";
if (!allEqual(contentSignatures)) classification = sameTree ? "same_tree_content_variability" : "content_change";
else if (repeatedContentFailure) classification = "repeated_content_failure";
else if (!allEqual(providerSignatures)) classification = "provider_route_variability";
else if (!allEqual(latencySignatures)) classification = "latency_variability";
matches.length > 1 &&
allEqual(contentSignatures) &&
fingerprints.every(({ content }) => content.categories.length > 0);
let classification =
matches.length === 1
? fingerprints[0].content.categories.length > 0
? "observed_content_failure"
: fingerprints[0].latency.latencyFailure || fingerprints[0].latency.routeCeilingExceeded
? "observed_latency_failure"
: "single_run"
: "stable";
if (matches.length > 1 && !allEqual(contentSignatures)) {
classification = sameTree ? "same_tree_content_variability" : "content_change";
} else if (repeatedContentFailure) classification = "repeated_content_failure";
else if (matches.length > 1 && !allEqual(providerSignatures)) classification = "provider_route_variability";
else if (matches.length > 1 && !allEqual(latencySignatures)) classification = "latency_variability";

return {
case: caseId,
Expand Down
12 changes: 12 additions & 0 deletions tests/eval-trend.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,18 @@ const answerReport = (label: string, sha: string, result: Record<string, unknown
});

describe("eval-trend answer-quality variability", () => {
it("does not call a single observed failure repeated", () => {
const failed = answerResult({ failures: ["citation count below required minimum"], citations: 1 });
expect(buildAnswerQualityVariabilityRows([answerReport("first-run", "same-sha", failed)])[0]).toMatchObject({
classification: "observed_content_failure",
same_tree: false,
runs: 1,
});
expect(buildAnswerQualityVariabilityRows([answerReport("first-run", "same-sha", answerResult())])[0]).toMatchObject(
{ classification: "single_run", runs: 1 },
);
});

it("marks pass-to-content-failure changes on the same tree as variability, not a deterministic regression", () => {
const rows = buildAnswerQualityVariabilityRows([
answerReport("baseline", "same-sha", answerResult()),
Expand Down
Loading