docs: record reconciliation canary evidence#1098
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17ddcde4c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | #023 | P3 | task | Read Sunday 2026-07-26 scheduled-run artifacts | The 18:00 UTC scheduled runs deliver three free datapoints at once: first full-44 weekly canary (validates the #1044 ANSWER_CASE_LIMIT raise), browser-matrix flake second datapoint (webkit ui-route-coverage now reproduced + root-caused 2026-07-22 → see #024; firefox ui-formulation:91 still awaits a datapoint), and the irrelevant@10 labeling-audit artifact (§3.1 human-decision class). Read all three, then disposition. | sessions 2026-07-20/21; branch-review-ledger convergence notes | 2026-07-21 | | ||
| | #024 | P3 | issue | WebKit e2e `_rsc`-prefetch access-control-checks errors | verify:release:offline on `main` ce32fe170 (2026-07-22) reproduced #023's webkit clause: **6/6 deterministic** failures in `tests/ui-route-coverage.spec.ts` (Therapy Compass; DSM home/comparison; Specifier comparison/map; Differential stream), each a `pageerror … ?_rsc=… due to access control checks` on Next.js RSC prefetch — Chromium + Firefox clean. Not merge-blocking (required gate `test:e2e:pr` is chromium-only; the full webkit matrix is advisory/release-time). Most likely a Playwright route-interception × WebKit interaction, not a Safari user defect. Next: decide (a) allow/mock the `_rsc` routes for the `webkit` e2e project, or (b) confirm real Safari impact — before trusting the full-matrix webkit gate at release. NB the 2 other webkit fails (`ui-stress:412`, `ui-universal-search:210`) passed on isolated re-run = true flake. | session 2026-07-22 (verify:release:offline, `main` ce32fe170); refines #023 | 2026-07-22 | | ||
| | #025 | P2 | task | Activate the three webhooks (operator secrets) | Merged (#968) + deployed but inert — verified live: `POST /api/webhooks/railway` returns `503 webhook_not_configured`. To turn on: (1) Railway → set `RAILWAY_WEBHOOK_SECRET` + add the `?token=…` webhook URL; (2) the chat URLs `SLACK_WEBHOOK_URL`/`DISCORD_WEBHOOK_URL` must be set in BOTH places — the Railway **app/server env** (the receiver forwards deploy alerts via `postChatNotification`, which reads server env, so repo-secret-only leaves the Railway webhook authenticated but returning `delivered:false`) AND as **GitHub repo secrets** (the CI-failure workflow reads `secrets.*`); (3) `SUPABASE_INGESTION_WEBHOOK_SECRET`. Each fails closed until set, so this is pure ops. See docs/webhooks.md. | session 2026-07-22; PR #968; docs/webhooks.md | 2026-07-22 | | ||
| | #026 | P2 | task | Wire the Supabase document-change trigger | Locally implemented on `codex/supabase-document-change-trigger` in dedicated worktree `C:\\Users\\joshs\\.codex\\worktrees\\supabase-trigger-20260723\\Database`: forward migration `20260723150000_document_change_ingestion_webhook.sql`, schema mirror, update-only/minimal/fail-safe contract test and rollback docs. Focused schema tests 69/69 plus migration-role, function-grant and owner-scope guards pass. Not committed or applied: disposable replay and `drift:manifest` are blocked because Docker cannot start and `wsl --status` returns `Wsl/0x80070422` (WSL service disabled). Next: enable WSL/Docker, replay and regenerate drift, run broad gates, then use a protected-main PR before configuring the Vault secret/base-URL GUC. Never apply the SQL raw to live. | local branch/worktree; `docs/webhooks.md` section 3; session 2026-07-23 | 2026-07-22 | |
There was a problem hiding this comment.
Make the trigger patch recoverable
This records the Supabase trigger as "locally implemented" only in a Windows worktree/branch, but in this checkout that branch/worktree is absent and a repo-wide search finds no 20260723150000_document_change_ingestion_webhook.sql, so a fresh/cloud session cannot recover the patch needed for the documented next steps. Since this file is meant to be durable cross-session memory, please either commit/capture the patch somewhere repo-accessible or mark it as unavailable and restate the work from reproducible sources.
AGENTS.md reference: AGENTS.md:L453-L455
Useful? React with 👍 / 👎.
Summary
Why
This leaves durable, current evidence for the remaining reconciliation work and prevents unnecessary RAG retries or unsafe retrieval changes.
Verification
git diff --check— passednpx prettier --check docs/outstanding-issues.md— passedChecks not run
Risk and follow-up
RAG impact: no retrieval behaviour change — documentation only.
Note
Low Risk
Documentation-only edits to the issues tracker; no runtime, schema, or retrieval changes.
Overview
Updates
docs/outstanding-issues.mdonly—no application or RAG behavior changes.Adds a merged-main canary block for run
30018289898(structured report SHA/latency, 36/36 retrieval, answer-gate citation failure on neuroleptic case, admission/discharge fallback symptoms, ~$0.23 answer cost) and instructs no immediate RAG retry until the 2026-07-26 scheduled report.Refreshes open rows to match that evidence: #51 points at PR #1095/#1097 diagnostics and the comparison run; #19 narrows to the fallback layer after PR #1096 (retrieval/ranking ruled out); #31 documents the Source Governance table wiring gap (
eval:quality --rag-onlyvs golden retrieval artifact); #26 records local Supabase trigger work and WSL/Docker replay blockers.Resolves #20 in the archive with the same run’s nonzero cost readout. Open-table columns are Prettier realigned (shorter Detail cells).
Reviewed by Cursor Bugbot for commit 17ddcde. Configure here.