Skip to content

Fix design/UX defects #068–#072 from sitewide review - #1135

Merged
BigSimmo merged 9 commits into
mainfrom
cursor/sitewide-design-ux-review-6176
Jul 24, 2026
Merged

Fix design/UX defects #068–#072 from sitewide review#1135
BigSimmo merged 9 commits into
mainfrom
cursor/sitewide-design-ux-review-6176

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

Implements and archives the confirmed production design/UX defects from the sitewide review on main @ 6ceaaff5:

Verification

  • Focused Vitest: mobile-interaction regressions + favourites auth gate + visual-evidence tabs (19 passed)
  • ESLint on touched files
  • Live DOM proofs on http://localhost:4461 (presentation tab hrefs, Comparing dock, Sorted A to Z, diagnosis ?tab=map/related)
  • Typecheck (tsc --noEmit)
  • Verification not run: full verify:cheap / verify:ui — changes are scoped UI honesty/wiring; focused proof used instead

Clinical KB governance preflight

  • Not applicable — no ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output behavior changes beyond honest UI affordances.

RAG impact

RAG impact: no retrieval behaviour change — UI wiring/honesty only.

Risk and rollout

  • Risk: Low — presentation/tools navigation labels and disabled placeholders only.
  • Rollback: Revert the fix commit on this branch.
  • Provider or production effects: None
Open in Web Open in Cursor 

Summary by CodeRabbit

  • New Features

    • Added clearer navigation tabs for presentation workflows, including Overview, Compare, Map, and Related views.
    • Added a dedicated Saved shortcut to the tools launcher.
  • Bug Fixes

    • Improved in-app navigation and mobile routing behavior.
    • Clarified unavailable favourites and comparison controls with accessible “coming soon” messaging.
    • Simplified tools filtering and sorting labels for a more consistent experience.
  • Tests

    • Added mobile regression coverage for navigation, filtering, accessibility messaging, and unfinished controls.

Record confirmed presentation-tab, fake Add, Tools affordance, compare-dock,
and hard-reload defects from the 2026-07-24 production-page design review;
queue them as A2 UI work and note Compact/Detailed selected styling on #10.
Append the main@6ceaaff5 production-page design/UX review outcome and checks
so the same HEAD+scope is not re-reviewed without an explicit fresh pass.
@supabase

supabase Bot commented Jul 24, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 04199dca-3414-41b9-9e05-fb12d751a561

📥 Commits

Reviewing files that changed from the base of the PR and between 46af311 and 72ca08a.

📒 Files selected for processing (3)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
  • src/components/clinical-dashboard/evidence-panels.tsx
📝 Walkthrough

Walkthrough

Updates launcher filtering and labels, client-side clinical navigation, disabled placeholder controls, differential workflow tabs and comparison indicators, regression coverage, and review issue ledgers. No product code fixes are claimed in the branch-review record.

Changes

UI remediation and audit records

Layer / File(s) Summary
Differential workflow navigation and controls
src/components/differentials/differential-presentation-workflow-page.tsx, tests/mobile-interaction-regressions.test.ts
Mobile tabs now generate explicit routes, the compare dock is a status indicator, and desktop density controls are disabled with accessible messaging.
Clinical navigation and unavailable actions
src/components/clinical-dashboard/master-search-header.tsx, src/components/clinical-dashboard/evidence-panels.tsx, src/components/clinical-dashboard/visual-evidence.tsx
Clinical mode navigation uses router.push, while unfinished favourites actions are disabled and described for assistive technology.
Tools launcher affordances and filtering
src/components/applications-launcher-page.tsx, tests/mobile-interaction-regressions.test.ts
The launcher uses Saved labeling, explicit filter cases, static sorting text, and no menu chevrons; regression assertions cover these behaviors.
Review and issue ledger updates
docs/branch-review-ledger.md, docs/outstanding-issues.md
Review records, issue allocation metadata, open-item context, and resolved entries are updated for 2026-07-24.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: codex

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing documented design/UX defects from the sitewide review.
Description check ✅ Passed The description covers Summary, Verification, Risk and rollout, Clinical Governance, RAG impact, and Notes, with clear reasons where some gates were not run.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/sitewide-design-ux-review-6176

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo marked this pull request as ready for review July 24, 2026 05:34
@BigSimmo

Copy link
Copy Markdown
Owner Author

@cursoragent please can you resolve the branch conflicts here for me.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 24, 2026 05:34
@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

❌ Unable to add follow-up after multiple attempts. The agent may be experiencing issues.

Please try again later or Open in Web to view the status.

Open in Web Open in Cursor 

Learn more about Cursor Agents

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7066d631b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/outstanding-issues.md Outdated
Wire presentation mobile tabs to diagnosis section deep-links, replace the
self-linking Compare dock with a Comparing status, convert fake Evidence Add
controls to coming-soon placeholders, make Tools Sort/More affordances honest,
and use router.push for mode-action internal navigation.
Move the fixed presentation, Tools, Evidence Add, and soft-navigation defects
to the resolved archive and restore a contiguous recommended queue.
@cursor cursor Bot changed the title Capture sitewide design/UX review findings (#068–#072) Fix design/UX defects #068–#072 from sitewide review Jul 24, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 23: Update the reviewed branch entry in the ledger to use a qualified
branch token such as origin/main so scripts/sweep-branch-ledger.mjs includes it
in parseLedgerBranches() coverage; preserve the canonical main branch identity
and existing review details.

In `@docs/outstanding-issues.md`:
- Around line 94-95: Remove the blank line between the consecutive blockquote
lines in the merged-main canary update so the blockquote remains continuous and
satisfies markdownlint MD028.

In `@src/components/differentials/differential-presentation-workflow-page.tsx`:
- Around line 709-729: Use native disabled controls for all unavailable actions:
add disabled to both density buttons in
src/components/differentials/differential-presentation-workflow-page.tsx lines
709-729, the Add button in src/components/clinical-dashboard/evidence-panels.tsx
lines 845-857, and the Add button in
src/components/clinical-dashboard/visual-evidence.tsx lines 678-690 while
preserving their existing aria-disabled, coming-soon title, and accessible note;
update the assertions in tests/mobile-interaction-regressions.test.ts lines
67-76 to require native disabled alongside the accessibility copy.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ea539167-19b5-4781-a57b-50a1c8d4a002

📥 Commits

Reviewing files that changed from the base of the PR and between 9456cea and 46af311.

📒 Files selected for processing (8)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
  • src/components/applications-launcher-page.tsx
  • src/components/clinical-dashboard/evidence-panels.tsx
  • src/components/clinical-dashboard/master-search-header.tsx
  • src/components/clinical-dashboard/visual-evidence.tsx
  • src/components/differentials/differential-presentation-workflow-page.tsx
  • tests/mobile-interaction-regressions.test.ts

Comment thread docs/branch-review-ledger.md Outdated
Comment thread docs/outstanding-issues.md Outdated
cursoragent and others added 4 commits July 24, 2026 05:55
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
GitHub review-comment reply returned 403, so the outdated Codex acuity thread was resolved with the GraphQL resolveReviewThread mutation.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Qualify the sitewide review ledger ref as origin/main for sweep parsing,
fix the outstanding-issues blockquote blank (MD028), and record the babysit
disposition. Keep focusable aria-disabled coming-soon placeholders.
Resolve outstanding-issues ID collision by keeping main's #68/#69 and
archiving the PR UX defects as #70#74. Retain product honesty fixes.
@BigSimmo
BigSimmo merged commit 0cc0ee2 into main Jul 24, 2026
17 checks passed
@BigSimmo
BigSimmo deleted the cursor/sitewide-design-ux-review-6176 branch July 24, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants