Codify search chrome behaviour rules and guard hidden phone-dock reserve

[BigSimmo]

Motivation

• Prevent recurring iOS bottom white-band regressions by making the phone search/header/footer chrome behaviour explicit and durable across the repo.
• Ensure page-aware composer ownership (shell vs hero vs DocumentViewer) and the edge-to-edge dock contract are remembered so future edits cannot silently reintroduce the old reserve behaviour.
• Add a testable static guard so the remembered rules, CSS tokens, and code comments stay aligned with the implemented zero hidden-reserve contract.

Description

• Added a new AGENTS.md section <!-- BEGIN:search-chrome-behaviour --> codifying the owner model, edge-to-edge dock rules, the 0rem hidden reserve invariant, header/footer symmetry, and a change checklist for future edits.
• Added docs/search-chrome-behaviour.md with the page ownership model, invariants, and a pre-change checklist that points to the TypeScript source-of-truth src/components/clinical-dashboard/mobile-composer-reserve.ts and the CSS token alignment rules.
• Aligned source and tests by updating src/components/ClinicalDashboard.tsx comment to the 0rem hidden reserve, extended tests/ui-overlay-css-contract.test.ts to assert the AGENTS/docs/implementation guard, and recorded the targeted review in docs/branch-review-ledger.md.
• Files changed: AGENTS.md, docs/search-chrome-behaviour.md (new), src/components/ClinicalDashboard.tsx, tests/ui-overlay-css-contract.test.ts, and docs/branch-review-ledger.md.

Testing

• Ran static repository checks and searches (dependency-shortcut section count, targeted rg probes for stale 0.75rem wording) which passed and confirmed no remaining source mentions of the obsolete hidden-pad contract.
• Ran git diff --check which returned clean results for the working changeset.
• Attempted to run the focused Vitest targets npm run test -- tests/mobile-composer-reserve.test.ts tests/ui-overlay-css-contract.test.ts, but the test run was blocked in this environment due to missing node_modules/Vitest and the container Node runtime being 20.20.2 while the repo requires Node 24.x, so the dynamic tests could not be executed here.

---

Codex Task

[coderabbitai]

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 156df3c9-0c3d-4935-bc31-c18ae49ea92c

📥 Commits

Reviewing files that changed from the base of the PR and between be3a9fe and 233f7b1.

📒 Files selected for processing (5)

• AGENTS.md
• docs/branch-review-ledger.md
• docs/search-chrome-behaviour.md
• src/components/ClinicalDashboard.tsx
• tests/ui-overlay-css-contract.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/review-search-bar-behavior-and-establish-rules

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[github-actions]

CI triage

CI failed on this PR. Automated classification of the 6 failed job(s):

• Static PR checks — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• Unit coverage — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• Advisory UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• Build — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #4671 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ee0484cc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BigSimmo]

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ee0484cc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".