fix(ui): remediate spring physics animations, GPU layer compositing, and reduced-motion presets#1142
Conversation
…and reduced-motion presets
|
Warning Review limit reached
Next review available in: 38 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe update centralizes UI easing tokens, applies them across global transitions and animations, adds motion performance and accessibility helpers, refines mockup control interactions, and appends the PR review result to the branch review ledger. ChangesMotion and interaction refinement
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
# Conflicts: # docs/branch-review-ledger.md Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 similar comment
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/app/globals.css (2)
108-118: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the shared spring token in the animation shorthand.
Line [116] repeats the exact cubic-bezier value stored in
--spring-bouncy, so later token changes can cause the token and animation to drift. Usevar(--spring-bouncy)here and map the other animation definitions to their intended shared tokens.Proposed fix
- --animate-pop-in: pop-in 180ms cubic-bezier(0.34, 1.3, 0.64, 1) both; + --animate-pop-in: pop-in 180ms var(--spring-bouncy) both;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/globals.css` around lines 108 - 118, Update the animation shorthands in the global token definitions to reference the appropriate shared spring variables instead of duplicating cubic-bezier values, specifically replacing the pop-in easing in --animate-pop-in with --spring-bouncy and mapping the remaining animation definitions to their intended existing spring tokens. Preserve each animation name, duration, and fill mode.
2273-2276: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winScope
will-changeto the active transition.These declarations apply continuously to every matching element.
will-change: padding-bottomdoes not make layout reflow compositor-only, while permanent transform hints andtranslateZ(0)can increase layer and memory overhead. Apply the hints only during the transition, or remove them after confirming they provide measurable benefit.Also applies to: 2639-2660
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/globals.css` around lines 2273 - 2276, Update the .animate-skeleton-shimmer rule and the corresponding declarations around the additional referenced block so will-change and transform hints are applied only while the animation or transition is active; remove permanent translateZ(0) and unnecessary compositor hints, preserving the skeleton shimmer behavior without continuous layer overhead.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/app/globals.css`:
- Around line 108-118: Update the animation shorthands in the global token
definitions to reference the appropriate shared spring variables instead of
duplicating cubic-bezier values, specifically replacing the pop-in easing in
--animate-pop-in with --spring-bouncy and mapping the remaining animation
definitions to their intended existing spring tokens. Preserve each animation
name, duration, and fill mode.
- Around line 2273-2276: Update the .animate-skeleton-shimmer rule and the
corresponding declarations around the additional referenced block so will-change
and transform hints are applied only while the animation or transition is
active; remove permanent translateZ(0) and unnecessary compositor hints,
preserving the skeleton shimmer behavior without continuous layer overhead.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 43885a3f-9964-4a30-a5f8-c7bed25f847f
📒 Files selected for processing (3)
docs/branch-review-ledger.mdsrc/app/globals.csssrc/app/mockups/answer-evidence-popups/page.tsx
…-audit Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
# Conflicts: # src/app/globals.css Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
@cursoragent please resolve merge conflicts please |
|
Merge conflicts on PR #1142 are resolved.
  |
…-audit Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Record merge of origin/main into fix-physics-animation-audit after the PR went CONFLICTING behind #1138. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 433409c95d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…-audit Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d58758755
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Move the misplaced spring-physics review records out from under the table header / mid-history so they append after the final existing row, restoring the branch-review-ledger append-only contract. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
2 participants
Summary
fields=index, differentials abort/debounce, universal documents typeahead soft-timeout (750ms), shared(search-app)shell to avoid composer remount, and Answer rate-limit in-memory fallback outside production./services→/dsm) syncssearchModeduring render (no stale-mode paint) even when the query string is unchanged; extracted ClinicalDashboard lazy imports to stay under the maintainability budget.RAG impact: no retrieval behaviour change — typeahead documents domain timeout and shell URL sync only; ranking formulas and full
/api/searchretrieval path unchanged.Verification
npm run verify:pr-local— focused Vitest on touched sources (362) plus api-rate-limit / search-shell / universal / route / site-map suites green;docs:check-indexOKverify:uinot required for this pass; mode-home smoke vianpm run ensurereturned HTTP 200 for/,/services,/dsm,/documents/search,/therapy-compass,/?mode=prescribing, and/api/answer/streamreturned 200 after the rate-limit fallback fixeval:retrieval:latency/ soak / live OpenAI canary — approval-gated provider work; not needed for timeout-only typeahead changeRisk and rollout
GlobalSearchShelllayouts and prior timeout/fallback behaviourClinical Governance Preflight
[REDACTED]([REDACTED])Notes
fields=indexremains for identity-only consumers (cross-mode links).