Use browser history for header back arrow#1151
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Closed as deliberately rejected/superseded. Browser-history back can eject deep-linked users to an external or unrelated page and is nondeterministic across entry paths. #1161 instead landed explicit canonical in-app return targets, including allowlisted mode-aware privacy returns, as merge |
Motivation
Description
router.back()call so the button uses the browser history.src/components/clinical-dashboard/global-search-shell.tsxwhere theonMobileBackhandler was simplified to() => router.back().Testing
npm run workflow:design-sweep -- --write-evidencewhich completed successfully for the design sweep evidence stage.npm ciand the install completed without reported vulnerabilities.npx eslint src/components/clinical-dashboard/global-search-shell.tsx --max-warnings 0and it passed without warnings.npm run typecheckand the TypeScript check passed;npm run ensure(local dev server) was attempted but the Next dev server did not become ready in this environment due to external Google font fetch failures, so a running local UI smoke test could not be completed.Codex Task