Skip to content

Use browser history for header back arrow#1151

Closed
BigSimmo wants to merge 3 commits into
mainfrom
codex/fix-header-back-arrow-navigation
Closed

Use browser history for header back arrow#1151
BigSimmo wants to merge 3 commits into
mainfrom
codex/fix-header-back-arrow-navigation

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Motivation

  • The sitewide header back arrow on info and search pages was navigating to hardcoded section/home routes instead of returning the user to the actual previous page in browser history.

Description

  • Replace the route-specific redirect logic for the header/mobile back control with a direct router.back() call so the button uses the browser history.
  • The change is confined to src/components/clinical-dashboard/global-search-shell.tsx where the onMobileBack handler was simplified to () => router.back().

Testing

  • Ran npm run workflow:design-sweep -- --write-evidence which completed successfully for the design sweep evidence stage.
  • Installed dependencies with npm ci and the install completed without reported vulnerabilities.
  • Linted the modified file with npx eslint src/components/clinical-dashboard/global-search-shell.tsx --max-warnings 0 and it passed without warnings.
  • Ran npm run typecheck and the TypeScript check passed; npm run ensure (local dev server) was attempted but the Next dev server did not become ready in this environment due to external Google font fetch failures, so a running local UI smoke test could not be completed.

Codex Task

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f4918ce6-e788-4113-9621-b0062d88d93c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-header-back-arrow-navigation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 24, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

cursoragent and others added 2 commits July 24, 2026 07:37
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo

Copy link
Copy Markdown
Owner Author

Closed as deliberately rejected/superseded. Browser-history back can eject deep-linked users to an external or unrelated page and is nondeterministic across entry paths. #1161 instead landed explicit canonical in-app return targets, including allowlisted mode-aware privacy returns, as merge 7a81cfaa9064d7e1c4d50488e2dfa0926887a0e9 with full hosted checks green. The branch remains recoverable in the reconciliation bundle.

@BigSimmo BigSimmo closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants