fix: surface and recover stranded uploads#1152
Conversation
Detect aged owner-scoped queued documents without open jobs in the scheduled health probe, alert operators without automatic production mutation, and recover approved candidates through the transactional reindex RPC.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb446cdd42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Exclude queued documents with failed ingestion jobs from the stranded sweep so ordinary failed-job recovery retains the single action limit.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 similar comment
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
queueddocuments with no pending/processing ingestion job inreindex:healthRAG impact: no retrieval behaviour change — this affects ingestion health detection and queue recovery only; retrieval, ranking, generation and source rendering are unchanged.
Verification
npx vitest run tests/stranded-queued-recovery.test.ts tests/ingestion-autopilot.test.ts tests/ingestion-recovery.test.ts tests/supabase-schema.test.ts --maxWorkers=1— 98/98 passednpm run typechecknpm run check:github-actionsnpm run check:ci-scopeClinical KB Database(sjrfecxgysukkwxsowpy); configuration-only, no API requestverify:pr-localdry-run selected runtime, format, lint, typecheck, full unit, build and offline RAG fixtures. The smallest affected tests and static gates were run locally; exact-head hosted CI remains the broad landing gate.UI verification not run: no UI, routing, styling or browser behavior changed. No live Supabase query/mutation, OpenAI/Railway call, RAG evaluation or deployment was run.
Risk and rollout
apply=truedispatch.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
The detector is capped at 20 returned candidates and scans at most 200 aged queued rows per run. Rows without an owner are excluded from discovery and fail closed if passed directly. The transactional RPC and unique open-job index guarantee idempotent enqueue under concurrent recovery.