-
Notifications
You must be signed in to change notification settings - Fork 0
fix: rebuild safe information-page back navigation #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
dc3f305
feat: add back navigation to info pages
BigSimmo b64d309
fix: use IconButton for back nav tap target
BigSimmo 3621a70
fix(nav): use explicit in-app back targets and 44px settings back
cursoragent 91eb3ad
fix(safety-plan): confirm before leaving a dirty plan
cursoragent 259ea27
fix(ui): stop sheet focus-restore timers from crashing CI
cursoragent 004e191
fix: guard safety-plan draft navigation
cursoragent 5bc029a
Merge remote-tracking branch 'origin/main' into HEAD
cursoragent 5884c86
fix: preserve dirty navigation guards on teardown
BigSimmo eef0634
Merge remote-tracking branch 'origin/main' into codex/back-navigation…
BigSimmo ccc978e
Merge remote-tracking branch 'origin/main' into codex/back-navigation…
BigSimmo b2a1059
fix: return tool references to their mode home
BigSimmo a3f057a
fix: preserve privacy source navigation
BigSimmo 605264a
fix: keep privacy route statically reachable
BigSimmo f8fa480
fix: tighten navigation review coverage
BigSimmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| "use client"; | ||
|
|
||
| import { ArrowLeft } from "lucide-react"; | ||
| import { useRouter } from "next/navigation"; | ||
|
|
||
| import { cn, floatingControl, IconButton } from "@/components/ui-primitives"; | ||
|
|
||
| type NavigationBackButtonProps = { | ||
| label?: string; | ||
| fallbackHref?: string; | ||
| className?: string; | ||
| /** | ||
| * Optional gate before navigation. Return `false` to cancel (for example a | ||
| * dirty-form confirmation). When omitted, navigation always proceeds. | ||
| */ | ||
| onBeforeNavigate?: () => boolean; | ||
| }; | ||
|
|
||
| /** | ||
| * Deterministic in-app back control. Always navigates to `fallbackHref` rather | ||
| * than `history.back()`, so deep links / external referrers cannot eject the | ||
| * user out of Clinical KB (same contract as form detail pages). | ||
| */ | ||
| export function NavigationBackButton({ | ||
| label = "Go back", | ||
| fallbackHref = "/", | ||
| className, | ||
| onBeforeNavigate, | ||
| }: NavigationBackButtonProps) { | ||
| const router = useRouter(); | ||
|
|
||
| return ( | ||
| <IconButton | ||
| label={label} | ||
| icon={ArrowLeft} | ||
| onClick={() => { | ||
| if (onBeforeNavigate && !onBeforeNavigate()) return; | ||
| router.push(fallbackHref); | ||
| }} | ||
| className={cn(floatingControl, "rounded-full text-[color:var(--text-muted)]", className)} | ||
| iconClassName="h-5 w-5" | ||
| /> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.