UI: add universal search query ribbon#1166
Conversation
…arch-headings # Conflicts: # src/components/forms/forms-search-results-page.tsx
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughWalkthroughChangesThe shared search results heading now supports loading-aware status, accessibility metadata, filtered scope chips, conditional utilities, and responsive sort labels. Favourites, medication, and forms views use it directly across breakpoints. A new responsive search-heading mockup route presents three concepts, with DOM and UI smoke tests covering the updated behavior. Universal search heading
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bac7245e87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/mockups/mockups-layout-client.tsx (1)
16-40: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winSuppress the shared search composer for
/mockups/search-heading.
chromeVisible=falsehides the header, butsearchComposerVisiblestill defaults totrue, so the master search composer still renders standalone. ExcludingisSearchHeadingMockupprevents a fixed search bar from stacking over this mockup.🩹 Proposed fix
searchComposerVisible={ !isToolsPageMockup && !isFavouritesPageMockup && !isStandaloneDocumentFlow && !isUniversalSearchRedesignMockup && - !isCalculatorsSearchPageMockup + !isCalculatorsSearchPageMockup && + !isSearchHeadingMockup }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/mockups/mockups-layout-client.tsx` around lines 16 - 40, Update the searchComposerVisible condition in the GlobalMockupSearchShell props to also exclude isSearchHeadingMockup, ensuring the shared composer is hidden for the search-heading mockup while preserving existing visibility behavior for all other mockups.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/app/mockups/mockups-layout-client.tsx`:
- Around line 16-40: Update the searchComposerVisible condition in the
GlobalMockupSearchShell props to also exclude isSearchHeadingMockup, ensuring
the shared composer is hidden for the search-heading mockup while preserving
existing visibility behavior for all other mockups.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 774c11df-6d9e-493a-99f7-3f06b9bb12f9
📒 Files selected for processing (11)
docs/branch-review-ledger.mddocs/site-map.mdsrc/app/mockups/mockups-layout-client.tsxsrc/app/mockups/search-heading/page.tsxsrc/components/clinical-dashboard/favourites-command-library-page.tsxsrc/components/clinical-dashboard/medication-prescribing-workspace.tsxsrc/components/clinical-dashboard/search-results-header-band.tsxsrc/components/forms/forms-search-results-page.tsxsrc/components/search-heading-mockups.tsxtests/search-results-header-band.dom.test.tsxtests/ui-tools.spec.ts
1 participant
Summary
/mockups/search-headingreference page and focused DOM/Chromium regression coverage.RAG impact: no retrieval behaviour change — presentation-only shared search-header update.
Verification
npm run verify:pr-local— runtime, Prettier, full ESLint, and TypeScript passed; the complete unit run stopped only on the unrelated load-sensitivereconciliation-preflight30-second timeout, then that file passed 5/5 in isolation.git diff --check.npm run verify:ui— not repeated because the focused production matrix directly covers every changed production route and breakpoint; hosted UI checks remain required.npm run verify:release— not run; no release/provider workflow requested or required for this presentation-only PR.Risk and rollout
Clinical Governance Preflight
Notes
Summary by CodeRabbit
New Features
Tests
Documentation