Resolve merge conflicts for PR #1162 and #1134; add shared search-app layout, debounce/abort caching and CI/doc updates

[BigSimmo]

Summary

• Fix cross-mode search performance findings: prescribing catalogue debounce/abort/fields=index, differentials abort/debounce, universal documents typeahead soft-timeout (750ms), shared (search-app) shell to avoid composer remount, and Answer rate-limit in-memory fallback outside production.
• Fix Bugbot regressions: shared-shell pathname navigation (/services → /dsm) syncs searchMode during render (no stale-mode paint) even when the query string is unchanged; extracted ClinicalDashboard lazy imports to stay under the maintainability budget.

RAG impact: no retrieval behaviour change — typeahead documents domain timeout and shell URL sync only; ranking formulas and full /api/search retrieval path unchanged.

Verification

• npm run verify:pr-local — focused Vitest on touched sources (362) plus api-rate-limit / search-shell / universal / route / site-map suites green; docs:check-index OK
• UI verification not run: full verify:ui not required for this pass; mode-home smoke via npm run ensure returned HTTP 200 for /, /services, /dsm, /documents/search, /therapy-compass, /?mode=prescribing, and /api/answer/stream returned 200 after the rate-limit fallback fix
• Verification not run: eval:retrieval:latency / soak / live OpenAI canary — approval-gated provider work; not needed for timeout-only typeahead change

Risk and rollout

• Risk: medium — shared layout remount change and rate-limit fallback behaviour in non-production; production Answer/upload still fail closed when the durable limiter is unavailable
• Rollback: revert this PR; mode routes return to per-segment GlobalSearchShell layouts and prior timeout/fallback behaviour
• Provider or production effects: None

Clinical Governance Preflight

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains [REDACTED] ([REDACTED])
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

• Prescribing list rows keep the full catalogue payload so Safety/Monitoring filters and patient alerts still see section-derived signals; keystroke storms are controlled by debounce + abort. fields=index remains for identity-only consumers (cross-mode links).
• Live hybrid RPC cold tails remain a separate approval-gated follow-up.

[coderabbitai]

Important

Review skipped

Too many files!

This PR contains 115 files, which is 15 over the limit of 100.

To get a review, narrow the scope:
• coderabbit review --committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c2d8a359-d0b9-4b3e-b14a-2d0445438842

📥 Commits

Reviewing files that changed from the base of the PR and between 1292db8 and 48fcb48.

📒 Files selected for processing (130)

• .cursor/agents/pr-babysit.md
• PR_POLICY_BODY.md
• docs/branch-review-ledger.md
• docs/codebase-index.md
• docs/search-rag-master-context.md
• docs/site-map.md
• scripts/check-docs-links.mjs
• scripts/generate-site-map.ts
• src/app/(search-app)/differentials/diagnoses/[slug]/error.tsx
• src/app/(search-app)/differentials/diagnoses/[slug]/loading.tsx
• src/app/(search-app)/differentials/diagnoses/[slug]/page.tsx
• src/app/(search-app)/differentials/diagnoses/page.tsx
• src/app/(search-app)/differentials/error.tsx
• src/app/(search-app)/differentials/layout.tsx
• src/app/(search-app)/differentials/loading.tsx
• src/app/(search-app)/differentials/page.tsx
• src/app/(search-app)/differentials/presentations/[slug]/error.tsx
• src/app/(search-app)/differentials/presentations/[slug]/loading.tsx
• src/app/(search-app)/differentials/presentations/[slug]/page.tsx
• src/app/(search-app)/differentials/presentations/route.ts
• src/app/(search-app)/documents/[id]/error.tsx
• src/app/(search-app)/documents/[id]/loading.tsx
• src/app/(search-app)/documents/[id]/page.tsx
• src/app/(search-app)/documents/error.tsx
• src/app/(search-app)/documents/layout.tsx
• src/app/(search-app)/documents/search/loading.tsx
• src/app/(search-app)/documents/search/page.tsx
• src/app/(search-app)/documents/source/evidence/page.tsx
• src/app/(search-app)/documents/source/page.tsx
• src/app/(search-app)/dsm/compare/page.tsx
• src/app/(search-app)/dsm/diagnoses/[slug]/differentials/page.tsx
• src/app/(search-app)/dsm/diagnoses/[slug]/page.tsx
• src/app/(search-app)/dsm/layout.tsx
• src/app/(search-app)/dsm/loading.tsx
• src/app/(search-app)/dsm/page.tsx
• src/app/(search-app)/dsm/search/page.tsx
• src/app/(search-app)/factsheets/[slug]/page.tsx
• src/app/(search-app)/factsheets/layout.tsx
• src/app/(search-app)/factsheets/page.tsx
• src/app/(search-app)/factsheets/search/page.tsx
• src/app/(search-app)/favourites/error.tsx
• src/app/(search-app)/favourites/layout.tsx
• src/app/(search-app)/favourites/loading.tsx
• src/app/(search-app)/favourites/page.tsx
• src/app/(search-app)/forms/[slug]/error.tsx
• src/app/(search-app)/forms/[slug]/page.tsx
• src/app/(search-app)/forms/error.tsx
• src/app/(search-app)/forms/layout.tsx
• src/app/(search-app)/forms/loading.tsx
• src/app/(search-app)/forms/page.tsx
• src/app/(search-app)/formulation/[slug]/page.tsx
• src/app/(search-app)/formulation/builder/page.tsx
• src/app/(search-app)/formulation/compare/page.tsx
• src/app/(search-app)/formulation/layout.tsx
• src/app/(search-app)/formulation/map/page.tsx
• src/app/(search-app)/formulation/page.tsx
• src/app/(search-app)/home-page-client.tsx
• src/app/(search-app)/layout.tsx
• src/app/(search-app)/medications/[slug]/error.tsx
• src/app/(search-app)/medications/[slug]/loading.tsx
• src/app/(search-app)/medications/[slug]/page.tsx
• src/app/(search-app)/medications/layout.tsx
• src/app/(search-app)/medications/route.ts
• src/app/(search-app)/page.tsx
• src/app/(search-app)/services/[slug]/error.tsx
• src/app/(search-app)/services/[slug]/page.tsx
• src/app/(search-app)/services/error.tsx
• src/app/(search-app)/services/layout.tsx
• src/app/(search-app)/services/loading.tsx
• src/app/(search-app)/services/page.tsx
• src/app/(search-app)/specifiers/[slug]/page.tsx
• src/app/(search-app)/specifiers/builder/page.tsx
• src/app/(search-app)/specifiers/compare/page.tsx
• src/app/(search-app)/specifiers/layout.tsx
• src/app/(search-app)/specifiers/map/page.tsx
• src/app/(search-app)/specifiers/page.tsx
• src/app/(search-app)/therapy-compass/[slug]/brief/page.tsx
• src/app/(search-app)/therapy-compass/[slug]/page.tsx
• src/app/(search-app)/therapy-compass/[slug]/sheet/page.tsx
• src/app/(search-app)/therapy-compass/compare/page.tsx
• src/app/(search-app)/therapy-compass/layout.tsx
• src/app/(search-app)/therapy-compass/page.tsx
• src/app/(search-app)/therapy-compass/pathways/page.tsx
• src/app/(search-app)/therapy-compass/recommend/page.tsx
• src/app/(search-app)/therapy-compass/review/page.tsx
• src/app/(search-app)/therapy-compass/search/page.tsx
• src/app/(search-app)/tools/error.tsx
• src/app/(search-app)/tools/layout.tsx
• src/app/(search-app)/tools/loading.tsx
• src/app/(search-app)/tools/page.tsx
• src/app/differentials/layout.tsx
• src/app/documents/documents-layout-client.tsx
• src/app/documents/layout.tsx
• src/app/documents/source/evidence/page.tsx
• src/app/dsm/layout.tsx
• src/app/factsheets/layout.tsx
• src/app/favourites/layout.tsx
• src/app/forms/layout.tsx
• src/app/formulation/layout.tsx
• src/app/home-page-client.tsx
• src/app/medications/layout.tsx
• src/app/services/layout.tsx
• src/app/specifiers/layout.tsx
• src/app/therapy-compass/layout.tsx
• src/app/tools/layout.tsx
• src/components/ClinicalDashboard.tsx
• src/components/clinical-dashboard/clinical-dashboard-helpers.ts
• src/components/clinical-dashboard/clinical-dashboard-lazy.tsx
• src/components/clinical-dashboard/global-search-shell.tsx
• src/components/clinical-dashboard/medication-prescribing-workspace.tsx
• src/components/clinical-dashboard/shared-search-app-shell.tsx
• src/components/clinical-dashboard/use-differential-catalog.ts
• src/components/clinical-dashboard/use-medication-catalog.ts
• src/components/differentials/differentials-home-page.tsx
• src/lib/api-rate-limit.ts
• src/lib/search-shell-props.ts
• src/lib/universal-search.ts
• tests/api-rate-limit-fallback.test.ts
• tests/audit-content-services-regressions.test.ts
• tests/audit-navigation-auth-regressions.test.ts
• tests/differentials-navigation.test.ts
• tests/document-detail-performance.test.ts
• tests/favourites-demo-boundary.test.ts
• tests/production-mockup-boundary.test.ts
• tests/route-error-boundary.test.ts
• tests/search-shell-props.test.ts
• tests/services-client-boundary.test.ts
• tests/shared-search-shell-url-sync.test.ts
• tests/site-map.test.ts
• tests/therapy-compass-mode-wiring.test.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-merge-conflicts-and-ci-on-open-prs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[BigSimmo]

@codex fix failing CI testing

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14b94edc18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BigSimmo]

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

[chatgpt-codex-connector]

Summary

• Committed 653d09e (Fix CI docs links and flaky safety tests) on branch work.
• Created PR metadata via make_pr with title: Fix CI docs links and stabilize safety tests.
• Fixed docs-link CI failures by allowing historical moved route references while keeping current docs pointed at the actual (search-app) route locations. scripts/check-docs-links.mjsL45-L54
• Updated the generated site-map ownership source to src/app/(search-app)/page.tsx, and regenerated the matching docs row. scripts/generate-site-map.tsL137-L140 docs/site-map.mdL1091-L1096
• Updated current documentation references for the moved root/tools app paths. docs/process-hardening.mdL70-L72 docs/outstanding-issues.mdL114-L117
• Stabilized heavyweight-lock unit assertions by adding a test-only zero-wait option while preserving the production default wait behavior. scripts/test-run-lock.mjsL74-L88 scripts/test-run-lock.mjsL139-L151 tests/test-runner-safety.test.tsL74-L83 tests/test-runner-safety.test.tsL139-L147
• Stabilized the PDF deadline process-tree test by waiting for the child PID under load and treating Linux zombie grandchildren as terminated after SIGKILL. tests/pdf-extraction-budget.test.tsL19-L35 tests/pdf-extraction-budget.test.tsL141-L160

Testing

• ✅ npm ci
• ✅ npm run docs:check-links
• ✅ npm run sitemap:check
• ✅ npx vitest run tests/pdf-extraction-budget.test.ts tests/test-runner-safety.test.ts --reporter=dot
• ✅ npm run verify:cheap

View task →