Fix WebKit RSC prefetch interception errors#1179
Conversation
📝 WalkthroughWalkthroughAdds a documentation-only execution plan for diagnosing and conditionally correcting WebKit RSC prefetch failures, recording issue 024’s disposition, preserving issue 065, and running required offline verification. ChangesWebKit RSC prefetch disposition
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
…bkit-rsc-2e15 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/superpowers/plans/2026-07-24-webkit-rsc-prefetch-disposition.md`:
- Around line 300-305: Update the validation steps to compare `#065` row content
rather than line-numbered grep output: snapshot the matching content without
line numbers or verify that the diff contains no changes to `#065`. Keep the
expectation that only `#024` is mentioned in the diff and `#065` remains
byte-for-byte unchanged.
- Around line 272-284: Revise Step 2A so the `#024` archive row is not finalized
before Task 4 completes. Move the git SHA capture and final evidence row
update/commit to after Task 4’s full WebKit, Chromium UI, and offline gates, or
explicitly record a provisional disposition followed by a post-verification
update containing those results.
- Around line 140-155: Add a plain HTTP fetch probe alongside the existing HTTPS
case in the external request guard test, verify it is blocked, and assert that
the drained problems list contains both exact records with their respective
schemes so either HTTP or HTTPS matching regressions fail.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ace925fc-5c5f-4594-9326-a48aaba931e6
📒 Files selected for processing (1)
docs/superpowers/plans/2026-07-24-webkit-rsc-prefetch-disposition.md
Summary
fields=index, differentials abort/debounce, universal documents typeahead soft-timeout (750ms), shared(search-app)shell to avoid composer remount, and Answer rate-limit in-memory fallback outside production./services→/dsm) syncssearchModeduring render (no stale-mode paint) even when the query string is unchanged; extracted ClinicalDashboard lazy imports to stay under the maintainability budget.RAG impact: no retrieval behaviour change — typeahead documents domain timeout and shell URL sync only; ranking formulas and full
/api/searchretrieval path unchanged.Verification
npm run verify:pr-local— focused Vitest on touched sources (362) plus api-rate-limit / search-shell / universal / route / site-map suites green;docs:check-indexOKverify:uinot required for this pass; mode-home smoke vianpm run ensurereturned HTTP 200 for/,/services,/dsm,/documents/search,/therapy-compass,/?mode=prescribing, and/api/answer/streamreturned 200 after the rate-limit fallback fixeval:retrieval:latency/ soak / live OpenAI canary — approval-gated provider work; not needed for timeout-only typeahead changeRisk and rollout
GlobalSearchShelllayouts and prior timeout/fallback behaviourClinical Governance Preflight
[REDACTED]([REDACTED])Notes
fields=indexremains for identity-only consumers (cross-mode links).