Unify search filters and document Sources #1184
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,15 @@ | ||
| "use client"; | ||
|
|
||
| import { BookOpen, ChevronDown, type LucideIcon } from "lucide-react"; | ||
| import { useCallback, useEffect, useRef, useState, type CSSProperties, type ReactNode, type RefObject } from "react"; | ||
|
|
||
| import { Sheet, type SheetMobileSize } from "@/components/ui/sheet"; | ||
| import { clinicalDivider, cn, iconTilePremium, navPill, panelSubtle, textMuted } from "@/components/ui-primitives"; | ||
|
|
||
| const sheetMediaQueries = { | ||
| sm: "(max-width: 639px)", | ||
| lg: "(max-width: 1023px)", | ||
| all: "(min-width: 0px)", | ||
| } as const; | ||
|
|
||
| type UtilityDrawerSheetBreakpoint = keyof typeof sheetMediaQueries; | ||
|
|
@@ -87,6 +88,7 @@ export function UtilityDrawer({ | |
| sheetDescription, | ||
| sheetBreakpoint = "sm", | ||
| sheetMobileSize, | ||
| sheetReturnFocusRef, | ||
| }: { | ||
| id?: string; | ||
| title: string; | ||
|
|
@@ -113,13 +115,16 @@ export function UtilityDrawer({ | |
| sheetDescription?: string | null; | ||
| sheetBreakpoint?: UtilityDrawerSheetBreakpoint; | ||
| sheetMobileSize?: SheetMobileSize; | ||
| sheetReturnFocusRef?: RefObject<HTMLElement | null>; | ||
| }) { | ||
| const [uncontrolledOpen, setUncontrolledOpen] = useState(defaultOpen); | ||
| const [usesSheet, setUsesSheet] = useState(false); | ||
| const mobileTriggerRef = useRef<HTMLButtonElement>(null); | ||
| const open = controlledOpen ?? uncontrolledOpen; | ||
| const sheetTriggerClassName = | ||
| sheetBreakpoint === "all" ? "block" : sheetBreakpoint === "lg" ? "lg:hidden" : "sm:hidden"; | ||
| const inlineDrawerClassName = | ||
| sheetBreakpoint === "all" ? "hidden" : sheetBreakpoint === "lg" ? "hidden lg:block" : "hidden sm:block"; | ||
|
Comment on lines
+118
to
+127
Contributor
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Inspect the Sheet component's backdrop / focus-trap / inert handling.
fd -e tsx sheet.tsx --exec cat -n {}Repository: BigSimmo/Database Length of output: 20273 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "## Locate dashboard shell and clinical dashboard"
fd -e tsx 'dashboard-shell\.tsx|ClinicalDashboard\.tsx' .
echo
echo "## dashboard-shell relevant sections"
file="$(fd -e tsx 'dashboard-shell\.tsx' . | head -n 1)"
echo "FILE=$file"
wc -l "$file"
sed -n '1,260p' "$file" | cat -n
echo
echo "## ClinicalDashboard UtilityDrawer usages"
cli="$(fd -e tsx 'ClinicalDashboard\.tsx' . | head -n 1)"
if [ -n "${cli:-}" ]; then
rg -n "UtilityDrawer|UtilityDrawerProps|useDrawer|documentsDrawerOpen|documentsDrawer|sheetBreakpoint|sheetReturnFocusRef" "$cli"
sed -n '1,260p' "$cli" | cat -n
fiRepository: BigSimmo/Database Length of output: 25184 🌐 Web query:
💡 Result: The Shadcn Citations:
🌐 Web query:
💡 Result: Radix UI's Dialog component manages modality and accessibility by dynamically manipulating DOM styles and attributes, which can lead to specific behaviors regarding Citations:
🌐 Web query:
💡 Result: Radix UI Dialog manages focus trapping and body interaction as part of its default modal behavior to ensure WAI-ARIA compliance [1][2]. Focus Trapping and Trigger Interaction: When the Dialog is in modal mode ( Citations:
🌐 Web query:
💡 Result: In Radix UI Dialog components, the Citations:
🏁 Script executed: #!/bin/bash
set -euo pipefail
cli="$(fd -e tsx 'ClinicalDashboard\.tsx' . | head -n 1)"
echo "## ClinicalDashboard wrapper and UtilityDrawer props"
sed -n '3780,3915p' "$cli" | cat -n
echo
echo "## UtilityDrawer return focus props"
sed -n '3008,3035p' "$cli" | cat -n
sed -n '3090,3125p' "$cli" | cat -nRepository: BigSimmo/Database Length of output: 12657 Hide the externally controlled trigger for At 🤖 Prompt for AI Agents |
||
| const triggerClassName = cn( | ||
| "flex min-h-[56px] w-full cursor-pointer list-none items-center justify-between gap-3 rounded-lg px-4 py-3 text-left transition motion-safe:duration-150 hover:bg-[color:var(--surface-subtle)]", | ||
| className, | ||
|
|
@@ -227,7 +232,7 @@ export function UtilityDrawer({ | |
| contentStyle={sheetContentStyle} | ||
| bodyClassName={sheetBodyClassName} | ||
| mobileSize={sheetMobileSize} | ||
| returnFocusRef={sheetReturnFocusRef ?? mobileTriggerRef} | ||
| portal | ||
| > | ||
| <div className={cn("space-y-3", sheetChildrenClassName)}>{children}</div> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy lift
Do not record an unrun UI gate as passed.
This row says
npm run verify:uipassed 268/268, but the PR objectives say full UI verification was not run. Remove that claim or mark the gate as not run before using this as merge-readiness evidence. As per PR objectives, “Full UI verification … [was] not run.”🤖 Prompt for AI Agents
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the future-dated review records. Both newly added entries are dated July 25, 2026, which is after the current review date of July 24, 2026.
docs/branch-review-ledger.md#L797-L797: use the actual review date or defer this record until July 25, 2026.docs/branch-review-ledger.md#L799-L799: use the actual review date or defer this record until July 25, 2026.📍 Affects 1 file
docs/branch-review-ledger.md#L797-L797(this comment)docs/branch-review-ledger.md#L799-L799🤖 Prompt for AI Agents