-
Notifications
You must be signed in to change notification settings - Fork 0
fix: stop choppy screen resize when switching modes #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bb93fea
fix: stop choppy screen resize when switching modes
cursoragent 54d45f6
test: align therapy-compass wiring with pathname mode-home gate
cursoragent 5b7b034
docs(ledger): record mode-switch lag same-class bug hunt
cursoragent b948439
fix: close same-class mode-switch layout thrash bugs
cursoragent a32c1a2
docs(ledger): record mode-switch thrash review fixes
cursoragent 775d15a
fix: satisfy lint for mode-switch scroll and portal cleanup
cursoragent 0ef62ff
docs(ledger): record mode-switch thrash lint closeout
cursoragent 68228c0
merge origin/main into cursor/fix-mode-switch-lag-22f6
BigSimmo 113de41
Merge branch 'main' into cursor/fix-mode-switch-lag-22f6
github-actions[bot] 7e80c2b
docs(ledger): record frontend-architecture loading/nav review
cursoragent 9c5237f
merge origin/cursor/fix-mode-switch-lag-22f6 (main sync)
cursoragent 876d7ec
fix: reduce mode/page loading blanking and layout rework
cursoragent c64a2f0
docs(ledger): record parallel loading behaviour review fixes
cursoragent 905b7a5
refactor: extract sidebar transition hook and private-scope URL helper
cursoragent 7bceebf
test: allow DocumentViewer identity-only remount key
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,5 @@ | ||
| import { Skeleton, searchPageShell, searchPageContainer } from "@/components/ui-primitives"; | ||
| import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton"; | ||
|
|
||
| export default function Loading() { | ||
| return ( | ||
| <div className={searchPageShell} role="status" aria-label="Loading library"> | ||
| <div className={searchPageContainer}> | ||
| <div className="mb-6 flex flex-col gap-4 sm:flex-row sm:items-center sm:justify-between"> | ||
| <Skeleton className="h-10 w-full max-w-sm" /> | ||
| <div className="flex gap-2"> | ||
| <Skeleton className="h-9 w-20 rounded-full" /> | ||
| <Skeleton className="h-9 w-20 rounded-full" /> | ||
| <Skeleton className="h-9 w-20 rounded-full" /> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div className="grid gap-4 sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4"> | ||
| <Skeleton className="h-40 w-full rounded-xl" animationDelay="50ms" /> | ||
| <Skeleton className="h-40 w-full rounded-xl" animationDelay="100ms" /> | ||
| <Skeleton className="h-40 w-full rounded-xl" animationDelay="150ms" /> | ||
| <Skeleton className="h-40 w-full rounded-xl" animationDelay="200ms" /> | ||
| </div> | ||
| </div> | ||
| <span className="sr-only">Loading library</span> | ||
| </div> | ||
| ); | ||
| return <ModeHomeRouteLoading />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,5 @@ | ||
| import { Skeleton, searchPageShell, searchPageContainer } from "@/components/ui-primitives"; | ||
| import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton"; | ||
|
|
||
| export default function Loading() { | ||
| return ( | ||
| <div className={searchPageShell} role="status" aria-label="Loading DSM criteria"> | ||
| <div className={searchPageContainer}> | ||
| <Skeleton className="mb-6 h-10 w-1/3 max-w-sm" /> | ||
| <div className="grid gap-4"> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="50ms" /> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="100ms" /> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="150ms" /> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="200ms" /> | ||
| </div> | ||
| </div> | ||
| <span className="sr-only">Loading DSM criteria</span> | ||
| </div> | ||
| ); | ||
| return <ModeHomeRouteLoading />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton"; | ||
|
|
||
| export default function Loading() { | ||
| return <ModeHomeRouteLoading />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,5 @@ | ||
| import { Skeleton } from "@/components/ui-primitives"; | ||
| import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton"; | ||
|
|
||
| export default function Loading() { | ||
| return ( | ||
| <div className="mx-auto w-full max-w-7xl px-3 py-4 sm:px-5 lg:px-6" role="status" aria-label="Loading medication"> | ||
| <Skeleton className="mb-2 h-10 w-2/3 max-w-sm" /> | ||
| <Skeleton className="mb-6 h-6 w-1/3 max-w-xs" /> | ||
|
|
||
| {/* Tabs */} | ||
| <div className="mb-6 flex gap-2"> | ||
| <Skeleton className="h-10 w-24 rounded-lg" /> | ||
| <Skeleton className="h-10 w-24 rounded-lg" /> | ||
| <Skeleton className="h-10 w-24 rounded-lg" /> | ||
| </div> | ||
|
|
||
| {/* Grid */} | ||
| <div className="grid gap-6 md:grid-cols-2 lg:grid-cols-3"> | ||
| <Skeleton className="h-48 w-full rounded-xl" animationDelay="50ms" /> | ||
| <Skeleton className="h-48 w-full rounded-xl" animationDelay="100ms" /> | ||
| <Skeleton className="h-48 w-full rounded-xl" animationDelay="150ms" /> | ||
| </div> | ||
| <span className="sr-only">Loading medication</span> | ||
| </div> | ||
| ); | ||
| return <ModeHomeRouteLoading />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,5 @@ | ||
| import { Skeleton, searchPageShell, searchPageContainer } from "@/components/ui-primitives"; | ||
| import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton"; | ||
|
|
||
| export default function Loading() { | ||
| return ( | ||
| <div className={searchPageShell} role="status" aria-label="Loading services"> | ||
| <div className={searchPageContainer}> | ||
| <div className="mb-6 flex flex-col gap-4 sm:flex-row sm:items-center sm:justify-between"> | ||
| <Skeleton className="h-10 w-full max-w-sm" /> | ||
| <Skeleton className="h-10 w-32 rounded-lg" /> | ||
| </div> | ||
| <div className="grid gap-4 sm:grid-cols-2 lg:grid-cols-3"> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="50ms" /> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="100ms" /> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="150ms" /> | ||
| <Skeleton className="h-32 w-full rounded-xl" animationDelay="200ms" /> | ||
| </div> | ||
| </div> | ||
| <span className="sr-only">Loading services</span> | ||
| </div> | ||
| ); | ||
| return <ModeHomeRouteLoading />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton"; | ||
|
|
||
| export default function Loading() { | ||
| return <ModeHomeRouteLoading />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton"; | ||
|
|
||
| export default function Loading() { | ||
| return <ModeHomeRouteLoading />; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve the supported
queryalias.GlobalStandaloneSearchShellClientreadsq ?? query, but this redirect forwards onlyq./?mode=services&query=mania&run=1therefore lands without a query or submitted search.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents