fix(theme): salvage dark-mode audit from PR #1190 without clinical regressions by BigSimmo · Pull Request #1214 · BigSimmo/Database

BigSimmo · 2026-07-25T15:09:31Z

Summary

PR #1190 (remediate-dark-mode-audit @ 00eca49b) is not merge-safe: conflict resolution dropped the trustGatedAnswerForClinicalNotes fail-closed gate, broke @/lib/rag imports on the answer API, and remains CONFLICTING vs main.

This PR salvages only the intentional dark-mode audit commit (363672602) onto current main:

Theme transition / CSS dark-mode tokens + no-hardcoded-hex ESLint rule
Theme-aware sidebar/provider/settings colour usage
Remove static PWA manifest theme_color / background_color (theme-color stays on viewport/meta)
Keep trustGatedAnswerForClinicalNotes intact
Drop unused APP_THEME_COLORS / DEFAULT_THEME imports from manifest.ts
Update tests/pwa-manifest.test.ts to assert theme colours are not locked in the static manifest

After this lands: close PR #1190 without merging.

Verification

tsc --noEmit clean on salvage tip
tests/visual-evidence-tabs.dom.test.tsx + tests/ui-overlay-css-contract.test.ts (13/13)
tests/pwa-manifest.test.ts (8/8) after contract update
eslint on changed files (--max-warnings 0)
npm run check:branch-review-ledger
Synced with origin/main before merge
Verification not run: full verify:pr-local deferred to hosted CI on this tip
UI verification not run: no local browser matrix; Production UI covered by hosted CI

Risk and rollout

Risk: Low — theme/CSS/lint + mockup colour token cleanup; no answer/retrieval behaviour change
Rollback: revert this PR
Provider or production effects: None

Clinical Governance Preflight

Not required for this salvage (no ingestion/answer/search/source/privacy/production-env behaviour change). Explicitly preserves the clinical-notes trust gate that #1190 deleted.

Notes

Review of fix: remediate dark mode audit issues #1190 recorded in docs/branch-review-ledger.md
Bugbot + local proof: DO NOT MERGE fix: remediate dark mode audit issues #1190; use this salvage instead

Cherry-pick the intentional dark-mode commit from PR #1190 onto current main, keep trustGatedAnswerForClinicalNotes, drop unused manifest theme imports, and normalize the no-hardcoded-hex ESLint rule export.

coderabbitai · 2026-07-25T15:09:37Z

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cd5286d1-71ed-4770-80e5-6c83ee950c12

📥 Commits

Reviewing files that changed from the base of the PR and between b2d794c and e194422.

📒 Files selected for processing (12)

docs/branch-review-ledger.md
eslint-rules/no-hardcoded-hex.mjs
eslint.config.mjs
playwright.config.ts
src/app/globals.css
src/app/manifest.ts
src/components/clinical-dashboard/ClinicalSidebar.tsx
src/components/clinical-dashboard/provider-brand-icons.tsx
src/components/clinical-dashboard/settings-dialog.tsx
src/components/clinical-dashboard/use-theme.ts
src/components/favourites-page-mockups/favourites-library-redesign-page.tsx
tests/pwa-manifest.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cursor/pr1190-dark-mode-salvage-f453

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

supabase · 2026-07-25T15:09:38Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

chatgpt-codex-connector · 2026-07-25T15:11:21Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Matches the dark-mode salvage that removed locked theme_color/background_color from the PWA manifest so light/dark can update at runtime.

github-actions · 2026-07-25T15:20:56Z

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

Unit coverage — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #5459 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

Bot-authored main sync left required CI on action_required; this agent commit re-triggers human-authored checks for PR #1214.

BigSimmo added 3 commits July 25, 2026 22:53

chore: implement dark mode audit recommendations

1b5b245

fix(theme): salvage dark-mode audit delta without clinical regressions

b551f29

Cherry-pick the intentional dark-mode commit from PR #1190 onto current main, keep trustGatedAnswerForClinicalNotes, drop unused manifest theme imports, and normalize the no-hardcoded-hex ESLint rule export.

style: prettier-format dark-mode salvage files

e702c6c

merge(main): sync salvage branch before merge

04c4514

BigSimmo marked this pull request as ready for review July 25, 2026 15:11

test(pwa): expect theme colors on meta/viewport, not static manifest

3ae4cc5

Matches the dark-mode salvage that removed locked theme_color/background_color from the PWA manifest so light/dark can update at runtime.

BigSimmo and others added 5 commits July 25, 2026 23:23

merge(main): re-sync salvage before merge

3613a79

Merge branch 'main' into cursor/pr1190-dark-mode-salvage-f453

68d0cea

chore: retrigger CI after pr-branch-sync bot merge

15f5819

Bot-authored main sync left required CI on action_required; this agent commit re-triggers human-authored checks for PR #1214.

Merge branch 'main' into cursor/pr1190-dark-mode-salvage-f453

6e22ae4

chore: skip-branch-sync and retrigger CI for #1214 merge

e194422

BigSimmo enabled auto-merge (squash) July 25, 2026 15:36

BigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 25, 2026

BigSimmo merged commit bb6b394 into main Jul 25, 2026
19 checks passed

BigSimmo deleted the cursor/pr1190-dark-mode-salvage-f453 branch July 25, 2026 15:46

BigSimmo mentioned this pull request Jul 25, 2026

docs(ledger): record #1214 prlanded merge and #1190 close #1221

Merged

1 task

BigSimmo added a commit that referenced this pull request Jul 25, 2026

docs(ledger): record #1214 prlanded merge and #1190 close (#1221)

85d4564

cursor Bot mentioned this pull request Jul 25, 2026

fix(chrome): hide and return the universal header on scroll at every breakpoint #1222

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(theme): salvage dark-mode audit from PR #1190 without clinical regressions#1214

fix(theme): salvage dark-mode audit from PR #1190 without clinical regressions#1214
BigSimmo merged 10 commits into
mainfrom
cursor/pr1190-dark-mode-salvage-f453

BigSimmo commented Jul 25, 2026 •

edited by cursor Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 25, 2026 •

edited

Loading

Review limit reached

Uh oh!

supabase Bot commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BigSimmo commented Jul 25, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Risk and rollout

Clinical Governance Preflight

Notes

Uh oh!

coderabbitai Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

supabase Bot commented Jul 25, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 25, 2026

Uh oh!

github-actions Bot commented Jul 25, 2026

CI triage

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BigSimmo commented Jul 25, 2026 •

edited by cursor Bot

Loading

coderabbitai Bot commented Jul 25, 2026 •

edited

Loading