Skip to content

fix: keep desktop search in page flow#1252

Merged
BigSimmo merged 3 commits into
mainfrom
codex/desktop-page-search-48c0ee
Jul 26, 2026
Merged

fix: keep desktop search in page flow#1252
BigSimmo merged 3 commits into
mainfrom
codex/desktop-page-search-48c0ee

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • move submitted/search-page composers into normal page flow at desktop widths (1024px and above)
  • keep the auto-hiding sticky header independent from the desktop search composer
  • preserve the existing tablet sticky composer and phone bottom-dock behavior
  • add static and Playwright coverage for shell and dashboard search surfaces

Why

Desktop search was being kept inside the sticky header stack. The shared baseline now gives desktop result/detail pages a page-owned composer while retaining the established smaller-device behavior.

Areas touched

  • shared search header and page-owned composer slots
  • dashboard and standalone search shells
  • search chrome behavior documentation
  • responsive static and Chromium coverage

Verification

  • npm run workflow:design-sweep -- --write-evidence — passed
  • npm run verify:ui — passed, 289/289 Chromium tests
  • npm test -- tests/header-scroll-hide-contract.test.ts — passed, 15/15
  • npm run test:e2e -- tests/ui-chrome-scroll.spec.ts --project=chromium — passed, 12/12 after latest main sync
  • npm run test:e2e -- tests/ui-phone-scroll.spec.ts --project=chromium — passed, 20/20
  • npm run verify:cheap — lint, typecheck, policy, maintainability, and other preliminary gates passed; full unit phase has one unrelated Windows-only failure in tests/pdf-extractor.test.ts ("rejects cleanly if the python process dies with SIGKILL"). The extractor and test files are byte-identical to origin/main, and the focused rerun reproduces the same failure.

Checks not run

  • No live Supabase, OpenAI, ingestion, retrieval, or deployment checks; this is presentation-only UI behavior.

RAG impact: no retrieval behaviour change — shared search chrome placement only.

@supabase

supabase Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b29f090d-02fc-4586-bda2-074c3301e7a4

📥 Commits

Reviewing files that changed from the base of the PR and between 73ec464 and 0e6106f.

📒 Files selected for processing (9)
  • docs/search-chrome-behaviour.md
  • src/components/ClinicalDashboard.tsx
  • src/components/clinical-dashboard/global-search-shell.tsx
  • src/components/clinical-dashboard/master-search-header.tsx
  • src/components/services/services-navigator-page.tsx
  • src/lib/mode-home-composer.ts
  • tests/header-scroll-hide-contract.test.ts
  • tests/ui-chrome-scroll.spec.ts
  • tests/ui-tools.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/desktop-page-search-48c0ee

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit 0c0f69c into main Jul 26, 2026
18 checks passed
@BigSimmo
BigSimmo deleted the codex/desktop-page-search-48c0ee branch July 26, 2026 02:23
cursor Bot pushed a commit that referenced this pull request Jul 26, 2026
…n blanking

Resolve conflicts from desktop page-slot search (#1252) and phone chrome work
by taking main's page composer slot + portal rename, while keeping this
branch's host-attached keep-alive (no suppress-on-slotId) and omitting
ClientHydrationBoundary around mode-home children.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant