Skip to content
Merged
4 changes: 4 additions & 0 deletions docs/branch-review-ledger.md
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,11 @@ This file is append-only. Never rewrite or delete an existing review record; app
| 2026-07-27 | `codex/phone-bottom-band-root-20260727` | `a8a72a43d` | CI follow-up review of calculator dock hide lifecycle | APPROVE. Hosted production Chromium exposed a fast-close race where effect cleanup could cancel the queued focus-latch reset, plus a paint-contract journey coupled to natural short-page geometry. The reset now survives rapid sheet teardown, actual input focus is asserted before hide, and explicit runway isolates the paint contract from the anti-clamp boundary tests. No P0-P3 finding remains. | Exact locked Next 16.2.11 / Playwright 1.61.1 production Chromium repeat PASS (20/20); `verify:cheap` PASS (393 files; 3519 passed / 2 skipped); no provider-backed checks. |
| 2026-07-27 | `codex/phone-bottom-band-root-20260727` | `cc63ee90928d402eb9c5dd241e411ed88cc01f27` | Hosted Applications search hydration follow-up review | APPROVE. The final hosted Chromium failure was a test synchronization race: server-rendered content was visible before the controlled global-search input had its React onChange handler, so hydration could discard an immediate fill. Both shared-search tests now wait for the React handler and assert the accepted value before checking filtering. No product behavior changed and no P0-P3 finding remains. | Exact locked Next 16.2.11 / Playwright 1.61.1 production Chromium repeat PASS (20/20); `verify:cheap` PASS (25 gates; 393 files; 3519 passed / 2 skipped); no non-GitHub provider-backed checks. |
| 2026-07-27 | `codex/phone-bottom-band-root-20260727` | `a4802b9373404a00549a3479d86340398e978cc8` | Automated review follow-up for phone viewport fallback layering | APPROVE. Verified the review finding and separated the baseline 100vh declarations from the supported 100svh override, while retaining the later 100dvh override as the preferred dynamic viewport size. This removes duplicate properties without changing the intended fallback order. The ledger date remains the Australia/Perth task completion date. No P0-P3 finding remains. | Focused viewport-shell static contract PASS (8/8); `git diff --check` PASS; prior full `verify:cheap` and hosted required CI were green before this CSS-only declaration-layering follow-up; no non-GitHub provider-backed checks. |
| 2026-07-27 | `codex/fix-phone-bottom-edge-20260727` | `2cfd726843e034620091c9bb400640cce0fa40d3` | Superseding review of the physical-iOS phone bottom-edge regression | APPROVE pending broad local gates and physical staging acceptance. PR #1266 restored a phone `100dvh` shell and moved the primary regression away from Services, so Chromium parent geometry stayed green while Safari and a freshly relaunched standalone PWA clipped live result content above the physical edge. Both application owners now share a phone-only fixed `inset: 0` shell without a viewport-unit height clamp. The repaired Services journey requires the real result list to own the final pixel and preserves its pre-resize anchor through viewport shrink and expansion. No P0-P3 code or test finding remains. | TDD RED on the base shell (`relative` instead of `fixed`); exact Services Chromium GREEN (1/1); focused shell contracts GREEN (19/19); full Vitest GREEN (393 files, 3520 passed / 2 skipped); independent spec and quality reviews PASS; physical Safari/Home Screen staging proof and broad local gates pending; no provider-backed checks yet. |
| 2026-07-27 | `codex/fix-phone-bottom-edge-20260727` | `3f33b0b4b7c08dab74ba6685fbd6aa672a8e6c91` | Final review of browser and standalone phone edge ownership | APPROVE pending exact staging device acceptance. Supersedes the `2cfd7268` review after physical Safari and cold-launch PWA evidence disproved the fixed-root solution. Browser phones now use document scrolling so Safari can minimize its chrome and paint content through released top and bottom edges; standalone phones retain a bounded 100vh frame with page-owned calculator, DocumentViewer, and differential footers portaled outside the inner scroller. Hidden chrome releases reserve, opacity, hit testing, and last-pixel ownership without a backward scroll jump, while sm+ returns portal content inline. Independent final review found no P0-P3 issue. | `verify:cheap` PASS (393 files; 3526 passed / 2 skipped); focused static contracts PASS (43/43); exact new standalone and responsive production Chromium journeys PASS (4/4); `verify:ui` PASS (323/323); Prettier and `git diff --check` PASS; physical Safari and freshly relaunched Home Screen PWA staging proof pending; no live provider-backed verification. |
| 2026-07-27 | `codex/config-reconciliation-current-20260727` | `4400f59730fbd24efc5f4c54adda828506f3835b` | Protected-main review of #054 production configuration reconciliation | APPROVE. GitHub reads are repository-pinned; Railway reads are pinned to the live project, production environment and explicit app/worker services; each provider call has a 30-second bound; output is names-only even though Railway JSON is reduced from values in memory. Multiline Zod and `.env.example` drift are guarded. The correct primary checkout received only three generated gitignored local HMAC/probe values. No P0-P3 finding remains. Residual staging, webhook activation and legal/ZDR work remain #056, #025 and #053 rather than being overstated as complete. | Focused parity/local-presence 22/22 PASS; `verify:cheap` PASS (25 gates; 393 files; 3523 passed / 2 skipped); `verify:pr-local` PASS (same unit matrix + 36 offline RAG fixtures; build correctly skipped as unaffected); production-readiness READY (8 PASS, 2 checkout-file-location warnings); exact provider names-only GitHub/Railway parity PASS; Ops Digest active + latest schedule SUCCESS; Railway app/worker latest deploy SUCCESS; Supabase read-only cron/Vault-name proof; no OpenAI request or live RAG evaluation. |
| 2026-07-27 | PR #1271 / `codex/config-reconciliation-current-20260727` | `ada836d167f6a03f2a6514d56d3aee6304c6276c` | Automated-review follow-up for cross-worktree local fill persistence | APPROVE. The P2 was valid: caller-only process secrets could hide missing target-file values during `--root --fill`. Fill mode now computes persistent gaps from target env files while project identity still uses the merged file/process view; report mode retains its existing process override behavior. A dedicated contract proves all caller-only fillable values remain target-file gaps. No other P0-P3 finding remains. | Focused `tests/local-presence.test.ts` PASS (10/10); exact primary `check:local-presence -- --root C:\Dev\Apps\Database` PASS; Prettier + `git diff --check` PASS; earlier exact-tree `verify:cheap` and `verify:pr-local` remain the broad baseline; hosted required checks will rerun on this follow-up. |
| 2026-07-27 | PR #1271 / `codex/config-reconciliation-current-20260727` | `3321c1eb1f2d1ac4294caf40e09a63b74fe1f713` | Second automated-review follow-up for safe local fill targeting/reporting | APPROVE. Two valid P2 findings were fixed: an explicit root must now carry the Database package identity before any fill, and fill mode applies file-only state solely to writable HMAC/probe gaps while preserving merged process/file truth for report-only provider rows and project identity. Tests cover an unrelated package root, caller-only fillable values, and caller-only provider reporting. Zero unresolved local findings remain. | Focused `tests/local-presence.test.ts` PASS (11/11); exact primary presence PASS; unrelated-root CLI rejection PASS; Prettier PASS; hosted required checks and automated review must rerun on this head before merge. |
| 2026-07-27 | PR #1270 / `codex/fix-phone-bottom-edge-20260727` | `40d7cb1e4e934b47e96e9d7d8cea6a956472c12c` | Final automated-review follow-up for phone chrome scroll ownership | APPROVE. Three valid minor review findings were fixed: the latest scroll reporter now uses the commit-synchronized event-callback abstraction instead of mutating a ref during render; the 1024px focus regression proves bounded `main` ownership before and after scrolling; and paired answer geometry reads are ordered instead of raced. The component remains within its no-growth budget, visible edge geometry is unchanged, and no P0-P3 finding remains. | `verify:cheap` PASS (25 gates; 393 files; 3532 passed / 2 skipped); focused scroll contracts PASS (32/32); exact affected production Chromium journeys PASS twice (4/4 each); scoped ESLint, maintainability budget, Prettier, and `git diff --check` PASS; no non-GitHub provider-backed checks. |
| 2026-07-27 | PR #1270 / `codex/fix-phone-bottom-edge-20260727` | `931f7cef632921b0e41d0368ad4e5fc117221498` | Hosted Production UI hydration-settlement follow-up | APPROVE pending fresh hosted required checks. The full hosted Chromium matrix exposed one missed strict-locator guard: `/forms` can briefly overlap its server and settled client mode-home trees during production hydration. The test now applies the same one-owner convergence assertion already used by the adjacent shared-home loop, so a transient duplicate waits while a persistent duplicate still fails. No product behavior or edge geometry changed, and no P0-P3 finding remains. | First hosted run: 322/323 Chromium journeys PASS with the sole `/forms` strict-mode duplicate; exact failed production journey PASS 10/10 after the guard; scoped ESLint, Prettier, and `git diff --check` PASS; fresh hosted required checks pending; no non-GitHub provider-backed checks. |
| 2026-07-27 | `codex/remaining-safe-fixes-20260727` | `37c1fd9a10fc953013ef9bdbcff9d2bad681dab4` | Protected-main review of focused document-search timeout and reconciliation evidence | APPROVE. The staging tenancy failure was reproduced against the 750 ms federated timeout, then fixed by restoring the historical 6,000 ms budget only when documents are the sole requested domain; multi-domain requests retain the 750 ms cap. The diff does not change retrieval, ranking, ordering, aliases, scores, ownership, or selected results. Current canary, production-content, staging-boundary, and migration-gap evidence is recorded without overstating the remaining browser or schema work. No P0-P3 finding remains. Residual operational risk is the exact 23-migration staging reconciliation and post-merge tenancy proof. | Red/green fake-timer contract PASS; focused search/RAG tests 77/77; offline RAG 36 cases / 309 tests PASS; production-readiness READY (8 PASS, two isolated-checkout file warnings); `verify:cheap` PASS (25 gates); `verify:pr-local` PASS (393 files, 3,526 passed / 2 skipped, production build/client-secret scan, 36 offline RAG fixtures); no new live RAG dispatch or OpenAI spend. |
Loading
Loading