test: harden phone chrome verification and merge safeguards - #1279
Conversation
Add lock parity, risk-scoped phone coverage, stable geometry diagnostics, physical iPhone acceptance guidance, and a fail-closed final merge audit.
…sting-infra-20260727
Re-converge the document endpoint while phone chrome transitions change the scroll range, preserving the strict one-pixel clearance assertion.
…sting-infra-20260727
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (35)
📝 WalkthroughWalkthroughThis PR adds installed-lock parity checking, a final-merge-audit CLI, and a phone-chrome verification planner/CLI with supporting docs and CI wiring. It also refactors dashboard/document scroll ownership into shared active-scroll-owner and chrome-coordinator hooks, adding phone ChangesVerification & CI Tooling Infrastructure
Estimated code review effort: 4 (Complex) | ~60 minutes Phone Chrome Scroll-Ownership Coordinator
Estimated code review effort: 4 (Complex) | ~75 minutes Sequence Diagram(s)sequenceDiagram
participant Dev
participant CLI as verify-phone-chrome.mjs
participant Scope as ci-change-scope.mjs
participant Plan as phoneChromePlan
Dev->>CLI: npm run verify:phone-chrome
CLI->>Scope: get changed files (or --files)
Scope-->>CLI: file list
CLI->>Plan: phoneChromePlan(files, fullMode)
Plan-->>CLI: stage commands and notes
CLI->>CLI: run stages sequentially, stop on failure
sequenceDiagram
participant MainEl as main scroll element
participant Coordinator as useDashboardChromeCoordinator
participant OwnerHook as useActiveScrollOwner
participant Reporter as reportChromeScrollHide
MainEl->>Coordinator: scroll event
Coordinator->>Coordinator: throttle via requestAnimationFrame
Coordinator->>Reporter: offset, collapse metrics, source element
Coordinator->>OwnerHook: resolve owner from element geometry
OwnerHook-->>Coordinator: "pending"|"main"|"document"
Coordinator-->>MainEl: hidden/transition state, activeScrollOwner
Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fb8008dbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
Summary
Testing
|
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #5943 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
…sting-infra-20260727 # Conflicts: # tests/ui-tools.spec.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16fe430d74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
verify:phone-chromecoverage with focused ownership journeys before full UI escalationWhy
Repeated phone Safari/PWA regressions and CI races were being misclassified because dependency drift, duplicate hydrated owners, split geometry reads, and changing scroll ranges were not guarded consistently.
Areas touched
CI and package scripts; phone chrome test helpers and Playwright journeys;
ClinicalDashboard,GlobalSearchShell, andDocumentViewerdiagnostics; review/testing documentation.Verification
npm run verify:phone-chrome: 91/91 contracts, 12/12 focused journeys, 323/323 full ChromiumNot run / limitations
RAG impact: no retrieval behaviour change — test infrastructure and UI diagnostics only.
Summary by CodeRabbit
Improvements
Quality