fix(dashboard): prune dead #quotes/#images evidence nav anchors#228
Merged
Conversation
The evidence UI was redesigned into UnifiedEvidenceDrawerContent (a drawer with its own in-panel pill nav), which dropped the #quotes and #images section ids. The top section-jump nav (navigationHashes), its scroll-spy, and the Quotes/Images nav items still referenced those hashes, so both were dead jump targets: getElementById returns null and the scroll is a no-op. - Drop #quotes/#images from navigationHashes and the scroll-spy section list - Remove the now-dead Quotes/Images nav items (Search + Sources remain) - Remove the orphaned visualEvidence memo (only the Images item consumed it) - Strip the leftover id="images" from VisualEvidenceStrip's two non-embedded return branches (never rendered since all call sites pass embedded, but a latent duplicate-id hazard) typecheck + eslint clean; no new warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Removing id="images" shortened the VisualEvidenceStrip default-branch <section> enough for prettier to collapse it onto one line. Fixes the format:check verify gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The section-jump nav in
ClinicalDashboardhad two dead anchors:#quotesand#images. Clicking them was a no-op and they polluted the scroll-spy.Why
The evidence UI was redesigned into
UnifiedEvidenceDrawerContent— a drawer with its own in-panel pill nav (aria-label="Evidence sections"). That redesign dropped the#quotes/#imagessectionids, but the top nav never caught up:navigationHashes, the scroll-spysectionslist, and the Quotes/Images nav items still referenced#quotes/#imagesdocument.getElementById(hash)?.scrollIntoView(...)→ those ids no longer exist → silent no-op#sourcesstill resolves to a real anchorDiscovered during a repo-wide DOM/accessibility audit. (The audit's other output — 10 unlabeled form-control
aria-labels — was already fixed onmainvia #215, so this PR is only the nav cleanup.)Changes
#quotes/#imagesfromnavigationHashesand the scroll-spysectionslistvisualEvidencememo (only the Images item consumed it)id="images"fromVisualEvidenceStrip's two non-embedded return branches — never rendered (all call sites passembedded) but a latent duplicate-id hazardNet: +4 / −25, one file.
Testing
tsc --noEmit— clean (thenavigationHashesas constunion narrowed from 4→2 members with no downstream breakage)eslinton the file — 0 errors, no new warnings#quotes/#imagesor the removed nav labelsClinical governance
UI-only navigation cleanup. Does not touch ingestion, answer generation, search/ranking, source rendering, document access, privacy, or clinical output — governance preflight N/A.
🤖 Generated with Claude Code