fix(mockups): collapse tools-page primary region on filter + a11y/label polish#244
Merged
Merged
Conversation
- Collapse-on-filter: hide Start here / workflow lanes / launcher overview when a search or non-'all' filter is active, so results never render beneath a still-populated grid (adds isFiltering to useToolFilter). Split-pane overview swaps to live results + count/empty state. - Add a Resume lane to the workflow board (represents the personal/Saved area). - Cap 'Start here' grid at md:grid-cols-2 (drop cramped 2xl 4-up). - Bump sub-44px touch targets: search submit 40->44, clear 36->40, filter chips 40->44. - Parallel-noun areaLabels (Assessment/Treatment/Coordination/Saved/Reference). - Bump 10px phone-rail caption to 11px. - Add tests/ui-tools-collapse.spec.ts (additive). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up polish on the tools-page mockups (#215). Addresses the one genuine UX defect plus minor a11y/consistency items found in a design-critique pass.
#1 Collapse-on-filter (the functional fix)
Previously, search/filters only drove the bottom "All tools" list while the primary region (Start here / workflow lanes / launcher overview) stayed static — so a no-match query showed "No tools match" beneath a still-populated grid, and tools were duplicated 2–3× per screen.
Now, when a search or non-
allfilter is active the static primary region hides and only the filtered results show:Showing N of 7+ empty state); redundant bottom list + recents hide. Nav stays put.Implemented via a new
isFilteringflag onuseToolFilter.Minor polish
personal/Saved area).md:grid-cols-2(dropped the cramped2xl4-up).areaLabels:Reference / Assessment / Treatment / Coordination / Saved.Tests
Added
tests/ui-tools-collapse.spec.ts(additive) covering all three collapse behaviours + the Resume lane.Scope / governance
Mockup-only (
/mockups/tools-*). Touches no ingestion, answer generation, search/ranking, source rendering, document access, privacy, or clinical-output surfaces — clinical governance preflight N/A.Verification
typecheck✓,eslint✓,prettier --check✓ locally. The Playwright specs run in CI (ui-smoke/verify:ui).🤖 Generated with Claude Code