Skip to content

fix(access): complete outstanding P0/P1 hardening and test alignment#279

Closed
BigSimmo wants to merge 7 commits into
cursor/content-access-review-a385from
cursor/access-hardening-f048
Closed

fix(access): complete outstanding P0/P1 hardening and test alignment#279
BigSimmo wants to merge 7 commits into
cursor/content-access-review-a385from
cursor/access-hardening-f048

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary

Completes outstanding access-hardening work and P2/P3 follow-up verification.

Code fixes (prior commits)

  • Image signed-url route: repair broken merge while preserving owner-check-before-storage + committed-generation gating
  • Setup status: JSON error envelope on unexpected failures
  • Access route tests: managed port 4298, upload guard 409, withOwnerReadScope mock alignment

P2/P3 verification (this turn)

  • npm run governance:releasePASS (label coverage, label governance, source metadata audit)
  • Gold-label backfill dry-run — 0 documents need labels
  • tests/private-access-routes.test.ts + tests/answer-render-policy.test.ts99/99 pass
  • npm run eval:quality:releaseFAIL thresholds: P95 latency ~50.7s (ceiling 25s); 4 latency cases >20s; 2 routing mismatches (illegal-substances, unsupported-close-title-noise)
  • tests/ui-tools.spec.tsblocked by local server port churn (4298 vs 4299) during long Playwright run; needs a single ensured URL for the full suite

Docs

  • docs/clinical-governance.md: records public/anonymous API access patterns, rate-limit buckets, signed-url gates, and upload local-project guard

Follow-up

  • Product decision on eval latency / review thresholds (or infra tuning for answer generation)
  • Re-run verify:ui / ui-tools with stable npm run ensure URL (no competing dev servers)
  • Live DB-level RLS integration test (anon key, two users) — still tracked as follow-up
Open in Web Open in Cursor 

BigSimmo added 6 commits July 5, 2026 22:01
- Hide footer Evidence/Sources chips on phone hero composers; scope stays in + menu
- Suppress bottom-dock composer flash until hero portal slot is ready
- Increase composer action/send touch targets to 44px on phones
- Update Playwright tests for scope menu, Answer home geometry, and stress fallback
@supabase

supabase Bot commented Jul 5, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review July 5, 2026 17:14
@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@BigSimmo

BigSimmo commented Jul 5, 2026

Copy link
Copy Markdown
Owner Author

Organizing open PRs (Jul 6): Superseded in part by #274 on main. Rebase remaining unique hardening onto main if still needed.

@BigSimmo

BigSimmo commented Jul 5, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded by merged work on \main:

Production is live with these fixes. Any remaining unique commits should be cherry-picked onto a fresh branch from current \main.

@BigSimmo BigSimmo closed this Jul 5, 2026
@BigSimmo
BigSimmo deleted the cursor/access-hardening-f048 branch July 9, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant