Remove Evidence-based and All sources chips from answer footer#285
Remove Evidence-based and All sources chips from answer footer#285BigSimmo wants to merge 20 commits into
Conversation
The golden retrieval set was 100% lexical fast-path (embedding_skipped_rate=1.0), so it could not measure whether a re-index changes vector/embedding retrieval quality. - forceEmbedding option on searchChunksWithTelemetry (SearchChunksArgs): bypasses every lexical text-fast-path so retrieval always exercises the embedding/vector stage. Diagnostic/eval-only; folded into the search cache key; never set on production paths. - eval-retrieval.ts: per-case `forceEmbedding` field + a global `--force-embedding` flag. - 10 `vector-*` cases (psychiatric monographs: PTSD, OCD, panic, anorexia, GAD, Tourette, postnatal, bipolar, ADHD, opioid) with forceEmbedding=true. Each is a clinical query that must be answered by vector retrieval of the right monograph — verified live at document_recall@5=1.0, content_recall@5=1.0, all via strategy=hybrid (embedding used). Rationale: forcing embedding is the correct instrument for re-index measurement — you want to measure the vector index directly, not have a lexical shortcut mask a regression. Wording alone can't reliably force the vector path (the fast-path is driven by emergent lexical-match strength), so the flag makes these probes deterministic. Live golden eval: 34/34 pass (24 existing + 10 new), no regression. verify:cheap green (980). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Wire forceEmbedding through eval runners and retrieval cache keys, bypass coverage/lexical shortcuts when forced, and add golden-case failure metrics so vector regressions cannot hide behind text-fast-path or cache hits.
…board Delete post-extraction dead code left in the monolith and trim unused imports. Also fix minor lint issues in favourites-hub, visual-evidence, and services-navigator.
…rdening fix(access): complete public retrieval scope and production access hardening
fix: restore anonymous production setup-status for psychiatry.tools
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Closing because the base branch (\cursor/fix-all-db-issues-5f13, PR #281) was closed as superseded/conflicted. If this UX change is still wanted, cherry-pick onto a fresh branch from current \main\ and open a new PR targeting \main. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 6 potential issues.
Bugbot Autofix prepared fixes for all 6 issues found in the latest run.
- ✅ Fixed: Answer dock inset still includes chips
- Reduced the default composer inset from 132px to 88px for the chipless answer footer and added a screen-reader-only scope trigger so focus restoration still works when footer chips are hidden.
- ✅ Fixed: One-shot commit script in repo
- Deleted scripts/commit-access-rag-fix.mjs so the one-shot auto-commit maintenance script is no longer in the repository.
- ✅ Fixed: Signed-in answers skip public corpus
- Updated retrieval_owner_matches so owner-scoped retrieval also matches public rows (owner_id IS NULL), aligning hybrid RAG with withOwnerReadScope for signed-in users.
- ✅ Fixed: Tool selection jumps while typing
- Pinned the selected tool id while the detail panel is open so typing in the search box no longer re-derives the highlighted tool mid-edit.
- ✅ Fixed: Public uploads invisible to uploaders
- Anonymous public uploads now persist with owner_id null and a public/ storage prefix so list, read, and retrieval paths that scope to public rows can see them immediately.
- ✅ Fixed: Upload rate limit bucket missing
- Added the document_upload bucket to ApiRateLimitBucket with default and anonymous limit maps so upload rate limiting resolves configured limits instead of undefined.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 7a0166d. Configure here.
| const phoneMediaQuery = "(max-width: 639px)"; | ||
|
|
||
| // Reserved height for the fixed answer footer composer (pill + chips + safe area). | ||
| const defaultComposerInsetPx = 132; |
There was a problem hiding this comment.
Answer dock inset still includes chips
Medium Severity
In answer mode, footer chips are no longer rendered. This causes two issues: the useCollapseWhenContentBelow hook's composerInsetPx (132px) is too large, leading to the Clinical notes/Evidence row collapsing prematurely, becoming inert, and blocking taps on mobile. Additionally, focus restoration after closing a document scope fails because the scopeSummaryRef is missing.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7a0166d. Configure here.
| ); | ||
| execSync('git commit -m "fix(rag): scope anonymous retrieval to public documents via owner sentinel"', { | ||
| stdio: "inherit", | ||
| }); |
There was a problem hiding this comment.
One-shot commit script in repo
High Severity
The commit-access-rag-fix.mjs script is a one-shot maintenance script that overwrites core library and schema files and then automatically commits the changes. This creates a serious footgun, risking unintended local commits and data corruption if executed in dev or CI environments.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7a0166d. Configure here.
| /** Scope reads to public rows (owner_id IS NULL) and, when signed in, the caller's owned rows. */ | ||
| export function withOwnerReadScope<T extends OwnerScopedQuery<T>>(query: T, ownerId: string | undefined): T { | ||
| if (ownerId) return query.eq("owner_id", ownerId); | ||
| if (ownerId) return query.or(`owner_id.eq.${ownerId},owner_id.is.null`); |
There was a problem hiding this comment.
Signed-in answers skip public corpus
Medium Severity
Document reads for signed-in users now include public rows via withOwnerReadScope, but answer retrieval still passes allowGlobalSearch: !access.ownerId, so hybrid RPCs filter to the user’s owner_id only. Public indexed guidelines visible in the library can be excluded from source-backed answers while signed in.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7a0166d. Configure here.
| queryKey: (controlledQuery ?? "").trim().toLowerCase(), | ||
| id: initialToolId(controlledQuery), | ||
| })); | ||
| const selectedId = selection.queryKey === normalizedQuery ? selection.id : queryDerivedId; |
There was a problem hiding this comment.
Tool selection jumps while typing
Low Severity
selectedId falls back to queryDerivedId whenever the query string differs from selection.queryKey, so editing the search box re-derives the highlighted tool before the user submits or picks a row. An open detail panel can switch tools mid-typing.
Reviewed by Cursor Bugbot for commit 7a0166d. Configure here.
| const uploadOwnerId = access.ownerId ?? (publicUploadsEnabled() ? publicWorkspaceOwnerId() : null); | ||
| if (!uploadOwnerId) { | ||
| return NextResponse.json({ error: "Public uploads are not configured for this workspace." }, { status: 503 }); | ||
| } |
There was a problem hiding this comment.
Public uploads invisible to uploaders
High Severity
Anonymous public uploads are stored with owner_id set to PUBLIC_WORKSPACE_OWNER_ID, but anonymous document reads and global RAG only include rows where owner_id is null (via withOwnerReadScope and PUBLIC_OWNER_FILTER_SENTINEL). After a successful upload, the same anonymous user cannot list, open, or retrieve that document in search/answer until it is promoted to a public row.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 7a0166d. Configure here.
| supabase: adminSupabase, | ||
| subject: access.rateLimitSubject, | ||
| bucket: "document_upload", | ||
| allowInMemoryFallbackOnUnavailable: allowRateLimitInMemoryFallbackOnUnavailable(), |
There was a problem hiding this comment.
Upload rate limit bucket missing
Medium Severity
The upload route passes document_upload to consumeSubjectApiRateLimit, but that bucket is not defined in ApiRateLimitBucket or the default limit maps. Anonymous upload rate limiting has no configured limits and can throw when resolving defaults if this path runs.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7a0166d. Configure here.
1 participant
Summary
Removes the Evidence-based and All sources footer chips from the answer-mode composer on all screen sizes. The answer bar now shows only the input pill and send button.
Scope and evidence remain reachable via the integrated + menu (
ScopeandEvidence mapactions).Changes
master-search-header.tsx: Hide footer chip row whensearchMode === "answer"only (other modes unchanged).ui-accessibility.spec.ts/ui-smoke.spec.ts: Open document scope via + menu (Scope) instead of removed footer chip.capture-chrome-parity.ts: Drop selectors for removed chip buttons.Verification
npm run test:e2e:accessibility— 2 passed (on PR branch)demo answer flow reaches a source-backed answersmoke test — passed (on PR branch)scripts/capture-answer-bar-screenshot.tsNotes
showFooterSearchChips = false— that hides chips for all modes. The correct guard issearchMode !== "answer".ClinicalDashboard.tsxnow that the chip row is gone.