fix(db): fail closed on NULL retrieval owner_filter#409
Merged
Conversation
…ilter Close the tenancy defense-in-depth gap where a null owner_filter matched every tenant row. Demo/test/local-no-auth now pass the public sentinel instead of null, and schema/tests encode the fail-closed truth table. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retrieval_owner_matches(NULL, …)return false instead of matching every tenant row (tenancy defense-in-depth review §6 item 1).schema.sql, drift manifest/allowlist, and schema/owner-scope tests to lock the fail-closed truth table.Test plan
vitest: owner-scope, retrieval-owner-filter-guard, drift-detection, supabase-schema (58 passed)20260708160000_retrieval_owner_matches_fail_closed.sqlon live, then remove body-half of drift allowlist entry forretrieval_owner_matchesMade with Cursor