Skip to content

fix(answer): remove duplicate cross-mode links strip on main #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BigSimmo wants to merge 2 commits into from
Closed

fix(answer): remove duplicate cross-mode links strip on main #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61080d4
fix(answer): remove duplicate cross-mode links strip on main
cursoragent Jul 9, 2026
8ccd2b6
test(ui-smoke): retry mobile table fullscreen open to reduce flake
cursoragent Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/components/ClinicalDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
primaryControl,
textMuted,
toneInfo,
toneSuccess,

Check warning on line 41 in src/components/ClinicalDashboard.tsx

View workflow job for this annotation

GitHub Actions / verify 

'toneSuccess' is defined but never used
toneWarning,

Check warning on line 42 in src/components/ClinicalDashboard.tsx

View workflow job for this annotation

GitHub Actions / verify 

'toneWarning' is defined but never used
} from "@/components/ui-primitives";
import { useAuthSession } from "@/lib/supabase/client";
import { AccountSetupDialog } from "@/components/clinical-dashboard/account-setup-dialog";
Expand Down Expand Up @@ -3502,9 +3502,6 @@

{showSystemNotice && answer ? renderSystemNotice("sm:hidden") : null}

{activeModeResultKind === "answer" && answer && (
<CrossModeLinksSection queries={crossModeQueries} onModeSearch={handleCrossModeSearch} />
)}
{activeModeResultKind === "answer" && answer && (
<RelatedDocumentsPanel
documents={relatedDocuments}
Expand Down
11 changes: 8 additions & 3 deletions tests/ui-smoke.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,9 +589,12 @@ async function scrollMobileTableExpandClearOfFooter(page: Page, clinicalTable: L
async function openMobileTableFullscreen(page: Page, clinicalTable: Locator) {
await scrollMobileTableExpandClearOfFooter(page, clinicalTable);
const tableSurface = clinicalTable.getByTestId("accessible-table-surface");
await tableSurface.click({ force: true });
const tableDialog = page.getByTestId("table-fullscreen-dialog");
await expect(tableDialog).toBeVisible({ timeout: 10_000 });
await expect(async () => {
if (await tableDialog.isVisible().catch(() => false)) return;
await tableSurface.click({ force: true });
await expect(tableDialog).toBeVisible({ timeout: 2_000 });
}).toPass({ timeout: 15_000 });
return tableDialog;
}

Expand Down Expand Up @@ -1475,7 +1478,9 @@ test.describe("Clinical KB UI smoke coverage", () => {
await page.goto(`/?mode=answer&q=${encodeURIComponent(question)}&run=1`, {
waitUntil: "domcontentloaded",
});
await expect(page.getByTestId("plain-answer-response")).toBeVisible({ timeout: uiAssertionTimeoutMs });
await expect(page.getByTestId("plain-answer-response")).toBeVisible({ timeout: 15_000 });

await expect(page.getByTestId("cross-mode-links")).toHaveCount(1, { timeout: 15_000 });

const answerSurface = page.locator('[data-dashboard-stage="answer-surface"]');
const strip = answerSurface.getByTestId("cross-mode-links");
Expand Down
Loading