fix(mobile): simplify dashboard scroll-hide and stabilize UI test#426
Merged
Conversation
Wire ClinicalDashboard phone scroll-hide through a single native listener on <main> instead of OR-merging parent and internal reporters. Allow 127.0.0.1 dev hydration via allowedDevOrigins, prefer localhost in Playwright base URL resolution, and add a collapse data attribute with a stepped-scroll smoke test. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
BigSimmo
enabled auto-merge (squash)
July 9, 2026 04:20
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #415: simplifies the phone dashboard header hide-on-scroll architecture and adds a stable Playwright regression test.
Changes
ClinicalDashboardwires phone scroll-hide via a native passive listener on<main>and passesscrollHiddentoMasterSearchHeader; removes dual OR-merge with internaluseHideOnScroll.next.config.ts): addallowedDevOrigins: ['127.0.0.1']so Next.js HMR/client hydration works when tooling hits127.0.0.1(without this, scroll listeners never attach).playwright-base-url.ts): preferlocalhostto matchensure-local-server.data-scroll-hidden+data-testid="universal-header-collapse"on the collapse wrapper.<main>asserting header collapse.Verification
npm run verify:cheapnpm run format:checknpx playwright test tests/ui-smoke.spec.ts -g "phone universal header fully hides" --project=chromiumManual follow-up
Quick scroll check on a real iPhone in Answer mode.