fix(ui): stop Tools filter row wrapping on medium screens#464
Merged
Conversation
Raise the "All tools" header breakpoint from sm to lg so the heading and the filter chips + Sort control stay stacked (full width, no awkward wrap) until the desktop grid turns on. Hide the static Sort pill below lg so the six chips get the full row and stay on one line. Drop the dead phone bottom-padding reserve on the launcher main: the mode-home search composer already renders in the centered hero on phones, so the 12rem docked-composer reserve was empty space. Lock that behaviour in by adding /applications (Tools) to the mobile and tablet/desktop search-centering regression tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
📝 WalkthroughWalkthroughThe applications launcher’s responsive padding and “All tools” header breakpoints were adjusted. Existing mobile and tablet/desktop UI layout tests now also cover the ChangesApplications launcher layout
Estimated code review effort: 2 (Simple) | ~10 minutes Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (10 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Responsive fixes for the Tools page (
/applications, the Applications Launcher):justify-betweenrow fromsm(640px), so between ~640–1024px the chips only got half the width and wrapped messily. Raised that breakpoint tolg, so the heading and controls stay stacked (full width, no awkward wrap) until the desktop card grid turns on atlg, then sit side-by-side. Hid the static "Sort by A to Z" pill belowlgso the six chips keep the full row and stay on one line.pb-[calc(12rem+…)]) on the launchermain. The mode-home search composer already renders in the centered hero on phones (samemin-width:0pxhero-portal path the other mode homes use), so that reserve was empty space./applicationsto the existing mode-home centering regression tests intests/ui-tools.spec.ts(Tools was the only standalone mode home missing from them).No behavior change to retrieval, ranking, answer generation, ingestion, source rendering, document access, privacy, or production env — this is presentational CSS plus test coverage.
Verification
Local gates run on this branch (cut fresh from
origin/main), reported honestly:npm run format:check— pass (required CI gate; not part ofverify:cheap).npm run verify:cheap— pass (check:runtime, github-actions, sitemap:check, lint, typecheck, full vitest).Targeted Chromium E2E:
tests/ui-tools.spec.ts+tests/ui-smoke.spec.ts(the requiredui-smokegate) — pass. Also verified the new Tools centering entries and swept the filter-row layout at 640/768/800/900/1000/1024/1100/1280px (single-row chips, no horizontal overflow).npm run verify:pr-local— not run as a single script; equivalent surface covered byformat:check+verify:cheap+ targeted UI specs above.npm run verify:ui— ran the two relevant Chromium specs directly (ui-tools + ui-smoke) instead of the full matrix; this worktree's full Turbopack e2e run is slow/flaky (cold-compile webServer timeouts). CI runs the authoritative required gates.N/A
npm run eval:retrieval:quality— no retrieval/ranking/selection/chunking/scoring change.N/A
npm run eval:rag/eval:quality— no answer-generation change.N/A
npm run check:production-readiness/check:deployment-readiness— no clinical workflow, privacy, env, Supabase, governance, or deployment change.Clinical Governance Preflight
N/A — this change is a responsive-layout fix plus test coverage. It does not touch ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.
Notes
origin/mainto isolate only this session's UI change. A pre-existing, unrelated docs commit that happened to sit on the working branch (648abfa3f, a Next.js version/date bump in the readiness checklist) was intentionally left off this PR and remains as local work on the other branch.