fix(responsive): resolve site-wide layout defects across all breakpoints#520
Conversation
Site-wide responsive review driving every production route at 11 widths (320-1536px + landscape) in Chromium, with page-overflow and internal-clip probes plus visual triage. Fixes 7 layout defects: - Answer follow-up composer was dragged ~186px off-screen across the entire 640-1023px band in the submitted-answer view. Root cause: the composer was `sm:sticky` (top-docked) in that band, but the centering CSS is written for a `fixed` element, so translateX(-50%) pushed it off the left edge. Made the answer composer `fixed bottom-0` at all widths (bottom-docked, consistent with phone/desktop); the existing rail-aware centering rules handle it, so the earlier CSS workaround was reverted (globals.css unchanged). Desktop and phone layouts are unchanged; only the tablet band changes. - DocumentViewer "Answer from this" button clipped at 320px: gate whitespace-nowrap to sm so it wraps on narrow phones. - Service detail long status chip collapsed into a circle when its text wrapped: rounded-full -> rounded-2xl (still a pill when single-line). - Tools/Applications list-row CTAs clipped at <=390px: nested single-column display:grid implicit auto columns weren't shrinking -> grid-cols-1. - documents-source monitoring table cards + evidence header overflowed at 320px: responsive column/title sizing (sm: restores the desktop sizing). - Differentials candidate-card title clipped a long word at 320px: break-words. Verified: verify:cheap green, verify:ui exit 0, ui-tools+ui-overlap 57 passed, zero horizontal overflow at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📝 WalkthroughWalkthroughUpdated responsive layout classes, text wrapping, evidence header presentation, pill customization, monitoring card columns, and service status chip styling across several interface components. ChangesResponsive UI styling
Estimated code review effort: 2 (Simple) | ~10 minutes Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (9 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@copilot resolve the merge conflicts in this pull request |
|
@copilot resolve the merge conflicts on this branch. |
Head branch was pushed to by a user without write access
Resolved the merge conflicts on this branch and merged |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/master-document-flow-mockups.tsx`:
- Around line 1599-1605: Update the evidence header around the Evidence h1,
Pill, and actions container so the title/pill area uses min-w-0 flex-1, allowing
it to shrink on narrow screens while preserving space for the actions. Ensure
the Pill’s text remains truncated when evidence.label is long, without changing
the actions behavior.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ba65f02c-4c2a-4c99-ad23-bb8ab6b0a8a5
📒 Files selected for processing (6)
src/components/DocumentViewer.tsxsrc/components/applications-launcher-page.tsxsrc/components/clinical-dashboard/master-search-header.tsxsrc/components/differentials/differential-presentation-workflow-page.tsxsrc/components/master-document-flow-mockups.tsxsrc/components/services/service-detail-page.tsx
|
@codex resolve all comments and CI |
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. The agent ran but didn't make any changes. The issues may already be fixed or require manual intervention. |
Summary
Testing
|
main's action-button redesign already makes these buttons full-width, so gating whitespace-nowrap to sm was dead code; DocumentViewer now matches main. The evidence-header overflow is handled by the preceding autofix commit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adding grid-cols-1 pushed the div past the 120-char print width; prettier wraps the JSX attributes. Pure formatting — the grid-cols-1 fix is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Summary
Site-wide responsive review — drove every production route at 11 widths (320–1536px + landscape) in Chromium with page-overflow and internal-clip probes plus visual triage. Fixes 7 layout defects. Desktop and phone layouts are unchanged; the only behavioral change is the tablet band for the Answer composer.
sm:sticky(top-docked) in the 640–1023 band, but the centering CSS (left:50%/calc+translateX(-50%)) is written for afixedelement, so the transform pushed the sticky element off-screen. Made the Answer composerfixed bottom-0at all widths — bottom-docked and consistent with phone/desktop. The existing rail-aware centering rules already handle a fixed composer, so an earlier CSS workaround was reverted (globals.cssends up untouched).whitespace-nowraptosm:so it wraps on narrow phones.rounded-full→rounded-2xl(still a pill at single-line height).display:gridimplicitautocolumns weren't shrinking →grid-cols-1(minmax(0,1fr)).sm:restores the desktop sizing).break-words.6 files, +14/−12.
Verification
npm run verify:ui— exit 0 (full Chromium suite)npm run verify:cheap(green: lint, typecheck, format, type-scale, sitemap, unit) and targetedui-tools+ui-overlap→ 57 passedNot applicable (no such logic changed):
eval:retrieval:quality,eval:rag,check:production-readiness,check:deployment-readiness.Clinical Governance Preflight
Layout/responsive-only change. It touches source-rendering surfaces (document viewer, documents table) but only their visual sizing — no source content, retrieval, access, governance, or clinical-output behavior changed. All invariants hold:
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
<input>scrolling its own text, and a ~6px sub-pixel/scrollbar residual on the PDF reader at desktop (maps to no visible over-wide element).🤖 Generated with Claude Code