Icon glyph refinements: services → Route, medication risk/contra/safe differentiated

[BigSimmo]

Follow-up to #519, resolving the three open icon-gallery review items.

• Services mode: ShieldCheck → Route. The mode is "service records + referral pathways"; ShieldCheck read as safety/trust. Changed at the single source (app-mode-icons.ts, so nav/search/favourites follow) plus the matching documentFacetIcons "Service" entry.
• Medication record sections differentiated (risk/contra/safe all shared ShieldCheck): risk → TriangleAlert, contra → Ban, safe → ShieldCheck. Aligned with the app's semantic-tone safety icons (warning/danger); contra already carries a danger tone (medications.ts), which Ban matches.
• Differentials: kept BrainCircuit — evaluated GitCompare (reads as a dev/git glyph in a clinical app) and Stethoscope (already used for "Clinical role" in settings); neither beats BrainCircuit for distinctiveness + clinical legibility.

Clinical governance: N/A — presentation-only icon swaps. No changes to ingestion, answer generation, search/ranking, source governance, document access, or clinical content.

Verified: prettier, npm run lint -- --max-warnings 0, typecheck, check:icon-scale, brand:check all green; no snapshot tests reference these maps (CI runs the full vitest + build gate).

🤖 Generated with Claude Code

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated Lucide icon mappings for service-related facets and app modes, plus medication risk and contraindication sections. No search logic, state handling, or public component APIs changed.

Changes

Icon Mapping Updates

Layer / File(s)	Summary
Service icon mappings src/components/clinical-dashboard/document-search-results.tsx, src/lib/app-mode-icons.ts	The Service document facet and services app mode now use Route instead of ShieldCheck.
Medication safety icons src/components/clinical-dashboard/medication-record-page.tsx	Risk sections use TriangleAlert, while contraindication sections use Ban.

Estimated code review effort: 1 (Trivial) | ~5 minutes

---

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Verification Claims	❌ Error	PR description says “Verified: prettier, lint, typecheck, check:icon-scale, brand:check all green,” which is a verification claim without explicit run/passed wording per check.	Rewrite verification notes as explicit entries, e.g. “Ran npm run lint -- --max-warnings 0: passed” or “Not run: reason”, for each check.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly reflects the main icon-glyph changes across services and medication sections.
Description check	✅ Passed	The description covers the change summary, governance impact, and verification results, though it doesn't use the template's exact checkbox layout.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Generated And Sensitive Files	✅ Passed	Only three source TS/TSX files changed; no .env, secrets, tokens, build outputs, caches, node_modules, or other sensitive/generated artifacts appeared in the diff.
Risky Git Or Deployment Actions	✅ Passed	Committed diff only swaps Lucide icons in three TS files; no force-push, reset, destructive clean, branch deletion, mutation, or deploy guidance added.
Supabase Project And Schema Safety	✅ Passed	PR only swaps Lucide icons in three UI files; no Supabase/project refs, env examples, migrations, RLS, policy, or DB changes are present.
Runtime And Package Manager Integrity	✅ Passed	Only TSX icon files changed; no lockfile, package-manager, or engine/runtime settings were modified. Repo still pins npm@11.17.0, Node 24, engine-strict=true.
Api Route Failure Handling	✅ Passed	Only presentation-only icon mapping changes in three client UI files; no API route, server action, RAG, search, ingestion, or provider code changed.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/icon-glyph-refinements

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch claude/icon-glyph-refinements

---

_{Comment @coderabbitai help to get the list of available commands.}