Skip to content

docs(rag): A3 Phase-2 gate check — findings #12–14 remain deferred#526

Merged
BigSimmo merged 1 commit into
mainfrom
claude/rag-optimization-phase-2-748178
Jul 12, 2026
Merged

docs(rag): A3 Phase-2 gate check — findings #12–14 remain deferred#526
BigSimmo merged 1 commit into
mainfrom
claude/rag-optimization-phase-2-748178

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

What & why

Task A3 "RAG optimization Phase 2 (architectural)" re-examined injection-threat findings #12–14 (source-authority tier, per-claim prose entailment, structural role separation) against the standing rule:

No re-index / retrieval change without a real golden miss proving a gain — and eval:retrieval:quality must improve, not merely not-regress.

Outcome: all three stay correctly deferred. The gate is not met, so no code change was made. This PR records the disposition durably in docs/rag-injection-threat-model.md §8 so the decision (and the precise unblock conditions) don't get re-litigated next session.

Disposition (per finding)

Scope / safety

  • Docs-only. No code, retrieval, ranking, or answer-path change.
  • eval:retrieval:quality is provider-backed (scripts/eval-retrieval.tsrequireServerEnv + requireOpenAIEnv, live Supabase + OpenAI) and was not run — speculative miss-hunting is owner-approved spend.
  • Clinical governance preflight: N/A — no ingestion, answer-generation, retrieval, ranking, source-rendering, privacy, or production-config code is touched.

Verification

  • prettier --write docs/rag-injection-threat-model.md → unchanged (already conforms to the format gate).

🤖 Generated with Claude Code

Task A3 ("RAG optimization Phase 2 (architectural)") re-examined injection
findings #12–14 (source-authority tier, per-claim prose entailment, structural
role separation) against the standing rule: no re-index / retrieval change
without a real golden miss proving a gain, with the bar that eval:retrieval:quality
must improve (not merely not-regress).

Disposition: all three stay correctly deferred; the gate is not met. Documents
per-finding unblock conditions in docs/rag-injection-threat-model.md §8:
- No concrete golden-eval miss exists (golden set all-green; miss promotion
  privacy-blocked).
- #13/#14 don't touch retrieval ranking, so eval:retrieval:quality can't register
  a gain — they belong to the injection harness (mitigation #11), not this task.
- #12 risks the recall regression PR #118 fixed; authority stays a tie-breaker,
  not a sort key.

Docs-only. No code, retrieval, or answer-path change. eval:retrieval:quality is
provider-backed and was not run (speculative miss-hunting is owner-approved spend).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@supabase

supabase Bot commented Jul 12, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 204a314d-1e4b-4f49-967c-6fb2ec691209

📥 Commits

Reviewing files that changed from the base of the PR and between 33edba1 and 501b949.

📒 Files selected for processing (1)
  • docs/rag-injection-threat-model.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/rag-optimization-phase-2-748178
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/rag-optimization-phase-2-748178

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit 3ad7cd3 into main Jul 12, 2026
15 checks passed
@BigSimmo
BigSimmo deleted the claude/rag-optimization-phase-2-748178 branch July 13, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant