fix(ia): canonicalise Tools route and unify medication/composer naming (PT-11, PT-12, PT-14)#591
Conversation
…g (PT-11, PT-12, PT-14)
"Tools" and "Applications" were two names for the same launcher:
/?mode=tools (mode home) plus a standalone /applications route titled
"Applications - Clinical KB". Rename the standalone route to /tools to
match the mode name and the /services//forms sibling pattern, and keep
/applications as a query-preserving redirect for old links and history.
Unify the medication naming: the sidebar said "Medications" while the
mode label is "Medication"; use "Medication" in both.
Drop the follow-up composer's "Ask Clinical Guide" placeholder override
so every answer composer uses the task-oriented mode placeholder
("Ask a clinical question..."). Site map regenerated.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe applications page now redirects to ChangesTools Route Migration
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant ApplicationsRedirect
participant ToolsRoute
participant ApplicationsLauncherPage
Browser->>ApplicationsRedirect: Request /applications with query parameters
ApplicationsRedirect->>ApplicationsRedirect: Serialize query parameters
ApplicationsRedirect-->>Browser: Redirect to /tools with forwarded query
Browser->>ToolsRoute: Request /tools
ToolsRoute->>ApplicationsLauncherPage: Render applications launcher
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1420ac698e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bff87bb74b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/ui-tools.spec.ts (1)
310-312: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winAdd a regression test for the legacy redirect and query preservation.
These tests validate
/tools, but do not verify that/applicationsredirects there while preserving search state such asq/query,mode,run, andfocus.As per coding guidelines, high-risk routing changes should be reviewed for regressions and missing tests; the PR objective also requires preserving live and legacy search state.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/ui-tools.spec.ts` around lines 310 - 312, Add a regression test alongside the existing “standalone tools route uses the shared global search” test that navigates to the legacy /applications route with q/query, mode, run, and focus parameters, then verifies it redirects to /tools while preserving those parameters and the expected search state.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/ui-tools.spec.ts`:
- Around line 310-312: Add a regression test alongside the existing “standalone
tools route uses the shared global search” test that navigates to the legacy
/applications route with q/query, mode, run, and focus parameters, then verifies
it redirects to /tools while preserving those parameters and the expected search
state.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 20d423f1-b583-4665-8dfa-c575985acf43
📒 Files selected for processing (11)
docs/site-map.mdsrc/app/applications/page.tsxsrc/app/tools/error.tsxsrc/app/tools/layout.tsxsrc/app/tools/loading.tsxsrc/app/tools/page.tsxsrc/components/clinical-dashboard/ClinicalSidebar.tsxsrc/components/clinical-dashboard/global-search-shell.tsxsrc/components/clinical-dashboard/master-search-header.tsxtests/ui-smoke.spec.tstests/ui-tools.spec.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b7e22fe43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Audit PT-11/PT-12/PT-14 — one canonical name per product area:
/applications(titled "Applications - Clinical KB") to/tools, matching the mode name and the/services///formssibling pattern./applicationsremains as a query-preserving redirect for old links and history. Navigation hrefs are unchanged.prescribingmode id and the/medicationsredirect are untouched (URL stability).Site map regenerated (
sitemap:update).Verification
sitemap:check, full typecheck, lint, prettier green;tests/ui-tools.spec.tsroute expectations updated to/toolsand exercised in the PR-6 branch's Chromium runs.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
/toolsroute for accessing the tools launcher.Updates