fix(deploy): skip Railway rebuilds for non-runtime changes#617
Conversation
Track per-service watch paths and the deep readiness endpoint, and classify Railway config changes as container-affecting. Verified with focused config tests, CI scope checks, full unit tests, and live Railway health readback.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughRailway app and worker configurations now define build watch patterns and deployment policies. CI detects Railway configuration changes as container changes, tests validate deploy triggers and service isolation, and deployment documentation reflects readiness checks and worker verification. ChangesRailway deployment configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35d4a2657f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
Include the transitive run-tsx startup modules and server-only stub in Railway worker deploy triggers. Verified by 34 focused Railway config tests.
Summary
/api/health/readycheck and both service-specific config files authoritativeRoot cause
Both live services had empty watch patterns, and the app still health-checked
/. The custom config filenames were not linked into Railway, so everymaincommit rebuilt both services and dashboard defaults could drift from the tracked files.Verification
npm test -- tests/railway-config.test.ts: 30 passednpm run check:ci-scope: passednpm run check:github-actions: passedgit diff --check: passednpm test: 229 files passed, 1 skipped; 2,178 tests passed, 1 skippednpm run check:production-readiness:ci: READY/api/health/ready: HTTP 200verify:cheappassed through lint, then local typecheck stopped on pre-existing missing installed Sentry/axe packages and stale.nextroute types. No dependency install or generated-output cleanup was performed; clean hosted CI is expected to provide the definitive typecheck/build.Production and rollback
The matching service settings were applied to Railway production before this PR. Controlled source redeploys succeeded:
7bf87f48-cbea-4408-b6de-04fe8a06911324aef5e1-0e1d-4031-8290-0f9253763274No secrets, variables, scaling, migrations, backfills, or production data were changed. Railway retained the prior deployments until both replacements passed.
Summary by CodeRabbit
New Features
Documentation
Tests