-
Notifications
You must be signed in to change notification settings - Fork 0
Simplify operational tooling and runbooks #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6a2dd93
Initial plan
Copilot d88c269
feat: simplify operational tooling and runbooks (#56)
Copilot c559343
Merge branch 'main' into copilot/simplify-operational-tooling
BigSimmo a7393de
Fix reindex pipeline recovery edge cases
BigSimmo 6735eea
chore(reindex): harden worker recovery and completion paths
BigSimmo 34de6f1
Ignore Claude and visual temp files in ESLint
BigSimmo 3c29f7b
Merge remote-tracking branch 'origin/main' into copilot/simplify-oper…
BigSimmo 64411cf
Update work
BigSimmo d7d3b46
fix(reindex): tighten recovery completion checks
BigSimmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { createInterface } from "node:readline"; | ||
|
|
||
| /** | ||
| * Prompts the user with a yes/no question and returns their answer. | ||
| * Returns `false` if stdin is not a TTY (e.g. when piped). | ||
| */ | ||
| export function confirm(question: string): Promise<boolean> { | ||
| if (!process.stdin.isTTY) { | ||
| console.log(" Non-interactive input detected; defaulting to No."); | ||
| return Promise.resolve(false); | ||
| } | ||
|
|
||
| return new Promise((resolve) => { | ||
| const rl = createInterface({ input: process.stdin, output: process.stdout }); | ||
| rl.question(`${question} (y/N) `, (answer: string) => { | ||
|
BigSimmo marked this conversation as resolved.
|
||
| rl.close(); | ||
| resolve(answer.trim().toLowerCase() === "y"); | ||
| }); | ||
|
Comment on lines
+15
to
+18
|
||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the common release case where all documents are already
indexedand there are no openingestion_jobs,scripts/reindex.tshits its queue-clear check and exits successfully without enqueueing any document for the new indexing code. Since this runbook is specifically for applying RAG indexing changes, describingnpm run reindexas a full reindex cycle can leave the corpus on the old chunks/enrichment while operators proceed to evals; either add an enqueue step/command or label this as draining an already queued reindex.Useful? React with 👍 / 👎.