chore(knip): remove dead barrel files + silence knip false-positives#644
Conversation
Conservative first pass on the knip baseline (advisory gate stays advisory): - Remove src/components/clinical-dashboard/index.ts and ClinicalDashboard.tsx — vestigial re-export barrel/shim from the dashboard decomposition with ZERO importers (the real component is src/components/ClinicalDashboard.tsx, imported directly). Clears knip's "Unused files". - Declare @babel/parser as an explicit devDependency (pinned to ^7 to match the version the AST tests already use — v8 drops the "importAttributes" plugin). Clears knip's "Unlisted dependencies". - Add `railway` to knip ignoreBinaries (used by scripts/check-env-parity.mjs). Clears knip's "Unlisted binaries". The remaining ~179 unused exports / 72 types are intentional public-API/barrel surfaces that need per-item human judgment — deliberately NOT bulk-removed. Verified: typecheck / lint clean; the 3 @babel/parser AST tests pass (17/17); knip file/dependency/binary noise resolved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Conservative first pass on the knip baseline shipped in #636 (the advisory
check:knipgate stays advisory — nothing is promoted to a required gate).src/components/clinical-dashboard/index.ts+ClinicalDashboard.tsx— vestigial re-export barrel/shim left over from the dashboard decomposition, with zero importers (the real component issrc/components/ClinicalDashboard.tsx, imported directly). Clears knip's "Unused files".@babel/parseras an explicit devDependency, pinned to^7to match the version the AST tests (architecture-boundaries,client-secret-surface,clinical-dashboard-merge-artifacts) already use — v8 drops the"importAttributes"plugin those tests pass. Clears knip's "Unlisted dependencies".railwayto knipignoreBinaries(used byscripts/check-env-parity.mjs). Clears knip's "Unlisted binaries".The remaining ~179 unused exports / ~72 exported types are intentional public-API / barrel surfaces that need per-item human judgment — deliberately not bulk-removed (per the repo's "triage, not automatic delete list" stance).
Verification
test— 247 files / 2301 tests pass, 0 failures (incl. the 3@babel/parserAST tests, 17/17)typecheck,lint— clean;format:checkclean on changed filesknip— file / dependency / binary noise resolved; only the (intentional) export triage remainsClinical Governance Preflight
N/A — dead-code removal + tooling config only; no ingestion, answer generation, search, privacy, or clinical output touched.
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
User Impact