Skip to content

chore(knip): remove dead barrel files + silence knip false-positives#644

Merged
BigSimmo merged 1 commit into
mainfrom
claude/knip-cleanup
Jul 14, 2026
Merged

chore(knip): remove dead barrel files + silence knip false-positives#644
BigSimmo merged 1 commit into
mainfrom
claude/knip-cleanup

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

Conservative first pass on the knip baseline shipped in #636 (the advisory check:knip gate stays advisory — nothing is promoted to a required gate).

  • Remove src/components/clinical-dashboard/index.ts + ClinicalDashboard.tsx — vestigial re-export barrel/shim left over from the dashboard decomposition, with zero importers (the real component is src/components/ClinicalDashboard.tsx, imported directly). Clears knip's "Unused files".
  • Declare @babel/parser as an explicit devDependency, pinned to ^7 to match the version the AST tests (architecture-boundaries, client-secret-surface, clinical-dashboard-merge-artifacts) already use — v8 drops the "importAttributes" plugin those tests pass. Clears knip's "Unlisted dependencies".
  • Add railway to knip ignoreBinaries (used by scripts/check-env-parity.mjs). Clears knip's "Unlisted binaries".

The remaining ~179 unused exports / ~72 exported types are intentional public-API / barrel surfaces that need per-item human judgment — deliberately not bulk-removed (per the repo's "triage, not automatic delete list" stance).

Verification

  • test247 files / 2301 tests pass, 0 failures (incl. the 3 @babel/parser AST tests, 17/17)
  • typecheck, lint — clean; format:check clean on changed files
  • knip — file / dependency / binary noise resolved; only the (intentional) export triage remains

Clinical Governance Preflight

N/A — dead-code removal + tooling config only; no ingestion, answer generation, search, privacy, or clinical output touched.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Updated project analysis settings to reduce false-positive findings.
    • Refined internal component organization and exports for improved maintainability.
    • Added tooling support for more reliable code analysis.
  • User Impact

    • No user-facing functionality or interface changes are included in this update.

Conservative first pass on the knip baseline (advisory gate stays advisory):

- Remove src/components/clinical-dashboard/index.ts and ClinicalDashboard.tsx —
  vestigial re-export barrel/shim from the dashboard decomposition with ZERO
  importers (the real component is src/components/ClinicalDashboard.tsx, imported
  directly). Clears knip's "Unused files".
- Declare @babel/parser as an explicit devDependency (pinned to ^7 to match the
  version the AST tests already use — v8 drops the "importAttributes" plugin).
  Clears knip's "Unlisted dependencies".
- Add `railway` to knip ignoreBinaries (used by scripts/check-env-parity.mjs).
  Clears knip's "Unlisted binaries".

The remaining ~179 unused exports / 72 types are intentional public-API/barrel
surfaces that need per-item human judgment — deliberately NOT bulk-removed.

Verified: typecheck / lint clean; the 3 @babel/parser AST tests pass (17/17);
knip file/dependency/binary noise resolved.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@supabase

supabase Bot commented Jul 14, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 14, 2026 07:29
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d8eb49a1-e70d-48cf-8ee7-586808feb72a

📥 Commits

Reviewing files that changed from the base of the PR and between 0696ded and 2d6368e.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • knip.json
  • package.json
  • src/components/clinical-dashboard/ClinicalDashboard.tsx
  • src/components/clinical-dashboard/index.ts
 ____________________________________________________
< Fluent in over six million forms of bug detection. >
 ----------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/knip-cleanup

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit e4b1799 into main Jul 14, 2026
18 checks passed
@BigSimmo
BigSimmo deleted the claude/knip-cleanup branch July 14, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant