fix(a11y): restore label-only mode-action menuitem names (CI for #654)#665
Conversation
…ting aria-hidden
- Add scope='col' and scope='row' to <th> elements in differentials comparison table
- Add aria-label to <table> in differentials and favourites pages
- Add aria-label to two unlabelled <nav> elements in favourites-library-nav
- Add tabIndex={-1} to SourcePreviewPopover surface for focus fallback
- Remove aria-hidden='true' from mode-action-popup description span
referenced by aria-describedby (conflicting attributes)
Removing aria-hidden from description spans correctly fixed the aria-describedby conflict, but visible description text then joined the accessible name (e.g. "Scope Limit answers…"). Set aria-label to the item label so names stay exact-match stable for Scope/Upload PDF queries. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Summary
CI fix for #654. Prefer #654 for review/merge — this branch tip matches
#654(9f880853).Root cause
Removing
aria-hiddenfrom mode-action description spans fixed thearia-describedbyconflict, but description text then joined each menuitem’s accessible name (e.g."Scope Limit answers to chosen sources"). Exact-match Playwright queries for"Scope"timed out in reduced-motion / forced-colors UI regression tests.Fix
Set
aria-label={item.label}on mode-action menuitems so names stay label-only while descriptions remain visible viaaria-describedby.Verification
npm run test:e2e:accessibility— 5/5 passedfix/accessibility-remaining-findingsso fix(a11y): add missing scope, aria-label, tabIndex and remove conflicting aria-hidden #654 re-runs CI