Skip to content

fix(a11y): restore label-only mode-action menuitem names (CI for #654)#665

Merged
BigSimmo merged 2 commits into
mainfrom
cursor/fix-pr654-ci-53b4
Jul 14, 2026
Merged

fix(a11y): restore label-only mode-action menuitem names (CI for #654)#665
BigSimmo merged 2 commits into
mainfrom
cursor/fix-pr654-ci-53b4

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

CI fix for #654. Prefer #654 for review/merge — this branch tip matches #654 (9f880853).

Root cause

Removing aria-hidden from mode-action description spans fixed the aria-describedby conflict, but description text then joined each menuitem’s accessible name (e.g. "Scope Limit answers to chosen sources"). Exact-match Playwright queries for "Scope" timed out in reduced-motion / forced-colors UI regression tests.

Fix

Set aria-label={item.label} on mode-action menuitems so names stay label-only while descriptions remain visible via aria-describedby.

Verification

Open in Web Open in Cursor 

BigSimmo and others added 2 commits July 14, 2026 18:28
…ting aria-hidden

- Add scope='col' and scope='row' to <th> elements in differentials comparison table
- Add aria-label to <table> in differentials and favourites pages
- Add aria-label to two unlabelled <nav> elements in favourites-library-nav
- Add tabIndex={-1} to SourcePreviewPopover surface for focus fallback
- Remove aria-hidden='true' from mode-action-popup description span
  referenced by aria-describedby (conflicting attributes)
Removing aria-hidden from description spans correctly fixed the
aria-describedby conflict, but visible description text then joined the
accessible name (e.g. "Scope Limit answers…"). Set aria-label to the
item label so names stay exact-match stable for Scope/Upload PDF queries.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 257504d6-4fe8-4cb8-ac8b-703964ec337e

📥 Commits

Reviewing files that changed from the base of the PR and between 5d9b043 and 9f88085.

📒 Files selected for processing (5)
  • src/components/clinical-dashboard/favourites-command-library-page.tsx
  • src/components/clinical-dashboard/favourites-library-nav.tsx
  • src/components/clinical-dashboard/mode-action-popup.tsx
  • src/components/clinical-dashboard/source-preview-popover.tsx
  • src/components/differentials/differential-presentation-workflow-page.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-pr654-ci-53b4

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 14, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo marked this pull request as ready for review July 14, 2026 14:06
@BigSimmo
BigSimmo enabled auto-merge (squash) July 14, 2026 14:06
@cursor cursor Bot changed the title fix(a11y): restore label-only mode-action menuitem names for CI fix(a11y): restore label-only mode-action menuitem names (CI for #654) Jul 14, 2026
@BigSimmo
BigSimmo merged commit ed77b35 into main Jul 14, 2026
30 checks passed
@BigSimmo
BigSimmo deleted the cursor/fix-pr654-ci-53b4 branch July 17, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants