fix: resolve CI failures on DSM integration branch#671
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@copilot resolve the merge conflicts on this branch. |
…714' into copilot/rerun-all-ci-again # Conflicts: # docs/site-map.md # scripts/generate-site-map.ts # tests/ui-smoke.spec.ts
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38e5ea214e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await expect(page).toHaveURL(/\/formulation\?q=anxious\+distress&focus=1&run=1$/); | ||
| await expect(page.getByRole("heading", { level: 1, name: "Mechanisms matching “anxious distress”" })).toBeVisible(); | ||
| await expect(page).toHaveURL(/\/specifiers\?q=anxious\+distress&focus=1&run=1$/); | ||
| await expect(page.getByRole("heading", { level: 1, name: 'Matches for "anxious distress"' })).toBeVisible(); |
There was a problem hiding this comment.
When this smoke test starts at /?mode=specifiers..., the current src/app/specifiers/[[...path]]/page.tsx catch-all immediately redirects /specifiers?q=anxious+distress... to the Formulation search page, whose heading is Mechanisms matching “anxious distress”. This assertion still looks for the removed Specifiers copy with straight quotes, so the UI smoke suite remains red after the syntax-only fix; the test should assert the compatibility redirect's Formulation heading instead.
Useful? React with 👍 / 👎.
| await expect(page).toHaveURL(/\/formulation\?q=I\+keep\+going\+over\+it&focus=1&run=1$/); | ||
| await expect( | ||
| page.getByRole("heading", { level: 1, name: "Mechanisms matching “I keep going over it”" }), | ||
| page.getByRole("heading", { level: 1, name: 'Mechanisms matching "I keep going over it"' }), |
There was a problem hiding this comment.
For formulation searches, FormulationResults renders the accessible heading as Mechanisms matching “{query}” with typographic quotes. Replacing the invalid delimiter characters with a straight-quoted string here changes the expected accessible name to Mechanisms matching "I keep going over it", which does not match the page and will fail this Playwright smoke test whenever the formulation redirect path is exercised.
Useful? React with 👍 / 👎.
06f129a
into
codex/dsm-main-integration-20260714
Merge conflicts resolved in commit
The branch is now a true merge commit on top of both |
Summary
tests/ui-smoke.spec.ts"/") with straight quotes in two heading name assertions — these causedSyntaxErrorin prettier, Playwright parser, and the TS build{brace in the specifiers test:async ({ page }) => { {→async ({ page }) => {=>in the formulation test bodyscripts/generate-site-map.tsimport { specifierRecords } from "@/lib/specifiers"—src/lib/specifiers.tswas deleted in the formulation refactor (8ab0e28) and no longer exists; causedCannot find modulein both Vitest (site-map test) and Next.js TypeScript buildrenderSlugInventory("Psychiatric specifier slugs", ...)block that consumed the deleted exportdocs/site-map.mdFormatting — ran
prettier --writeon all files flagged in Static PR checksVerification
prettier --check .— passesnpm run verify:pr-localDuring development, use
npm run verify:cheapas the faster iteration gate before the final PR-local preflight.npm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednpm run verify:releasebefore release or handoff confidence claimsFor retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes,
verify:pr-localrunseval:rag:offlineautomatically. Run the offline command directly during iteration before spending a live eval.npm run eval:retrieval:quality(must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.npm run eval:rag -- --limit 15+npm run eval:quality -- --rag-onlywhen answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)npm run check:production-readinesswhen clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changednpm run check:deployment-readinesswhen deployment startup, hosting, or rollout behavior changedClinical Governance Preflight
Not applicable — no clinical workflow, answer generation, ingestion, or source governance changes.
Notes
@/lib/specifierswas introduced in PR feat(specifiers): add diagnostic decision-support workspace #633, then deleted when the Specifiers feature was refactored into Formulation (8ab0e28). The DSM PR re-introduced the import without the file, causing the build and test failures./specifiers/[[...path]]) remain as compatibility redirects to Formulation — no routing changes.