Refine header and footer scroll timing#703
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe scroll-hide computation now tracks directional travel before hiding or revealing chrome. The search header and composers use state-dependent transition timing and easing, with tests covering thresholds, reversals, overscroll, and small deltas. ChangesScroll chrome behavior
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant ScrollReporter
participant computeScrollHideUpdate
participant SearchHeader
User->>ScrollReporter: scroll
ScrollReporter->>computeScrollHideUpdate: offset and directional travel
computeScrollHideUpdate-->>ScrollReporter: hidden state and updated intent
ScrollReporter->>SearchHeader: header/composer visibility state
SearchHeader->>SearchHeader: apply show or hide transition timing
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Verification
npm run verify:pr-local— not completed: itsverify:cheapunit phase hit the existing 30-second repository graph-scan timeout under local disk contention after format, lint, and TypeScript passednpm run verify:ui— full suite not repeated; the five directly affected Chromium cases passednpm run verify:release— not run; no provider-backed or broad release workflow was invokedCompleted locally:
npm test -- --run tests/use-hide-on-scroll.test.ts— 7/7 passed on the final rebased commitui-smoke.spec.ts, header/composer grep) — 5/5 passedverify:cheap— passedgit diff --check origin/main..HEAD— passedClinical Governance Preflight
Not applicable. This change is limited to local UI scroll timing and does not touch ingestion, answer generation, retrieval/ranking, sources, document access, privacy, production environment, or clinical output.
Notes
node_modulesjunction.Summary by CodeRabbit
New Features
Bug Fixes
Tests