Skip to content

fix: abort response-cancelled answer streams#762

Closed
BigSimmo wants to merge 4 commits into
mainfrom
codex/stream-cancel-hardening-retry-rebase
Closed

fix: abort response-cancelled answer streams#762
BigSimmo wants to merge 4 commits into
mainfrom
codex/stream-cancel-hardening-retry-rebase

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • Added cancellation hardening for /api/answer/stream so request aborts and response-body cancellation propagate through a single merged AbortSignal to both retrieval and summary generation.
  • Added focused regression test in tests/private-access-routes.test.ts asserting cancellation aborts the signal passed to answerQuestionWithScope.

Verification

  • Attempted focused test run: npm run test -- --run tests/private-access-routes.test.ts -t "aborts streamed answer generation when the response body is cancelled".
  • Local execution is blocked by missing Vitest binary (node_modules/vitest/vitest.mjs).

Checks not run

  • Full suite and provider-bound checks were not run because local dependency installation is incomplete.

Risk / follow-up

  • Re-run focused and broader offline checks after installing dependencies.

@supabase

supabase Bot commented Jul 17, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dc2ff178-83f5-42e4-afe4-37ddae2e7b78

📥 Commits

Reviewing files that changed from the base of the PR and between fb35cab and a647460.

📒 Files selected for processing (2)
  • src/app/api/answer/stream/route.ts
  • tests/private-access-routes.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/stream-cancel-hardening-retry-rebase

Comment @coderabbitai help to get the list of available commands.

@BigSimmo BigSimmo closed this Jul 17, 2026
@BigSimmo
BigSimmo deleted the codex/stream-cancel-hardening-retry-rebase branch July 18, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants