fix: make Playwright reduced-motion config type-safe (policy clean)#807
Closed
BigSimmo wants to merge 8 commits into
Closed
fix: make Playwright reduced-motion config type-safe (policy clean)#807BigSimmo wants to merge 8 commits into
BigSimmo wants to merge 8 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThe changes reorganize sitemap generation and documentation, simplify RAG abort and enrichment flows, add Supabase cleanup and query-correction support, update forms and service navigator interactions, and revise related regression, browser, schema, and tooling tests. ChangesRoute discovery and sitemap
RAG retrieval and Supabase hardening
Dashboard and catalog UI
Repository and workflow tooling
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #3145 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/lib/rag.ts (1)
2514-2527: 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy liftPreserve caller cancellation during retrieval.
The caller’s signal is checked only after the uncancellable Supabase operation completes, so Stop/disconnect requests can remain blocked and continue database work.
src/lib/rag.ts#L2514-L2527: wrap the retrieval await with caller cancellation and retain a post-await abort check.src/lib/rag-candidate-sources.ts#L185-L207: retain internal signal support so the underlying RPC receivesabortSignal.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/rag.ts` around lines 2514 - 2527, Preserve caller cancellation in the text candidate retrieval flow by wrapping the searchTextChunkCandidates await in src/lib/rag.ts lines 2514-2527 with args.signal-aware cancellation, while retaining the existing post-await throwIfAborted check and telemetry updates. In src/lib/rag-candidate-sources.ts lines 185-207, retain internal signal propagation so the underlying RPC continues receiving abortSignal; no direct change is required there beyond preserving that support.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@playwright.config.ts`:
- Around line 46-48: Remove the Chromium production project’s
contextOptions.reducedMotion override so it inherits the suite-wide "reduce"
setting. Keep any required "no-preference" coverage isolated to a separate
project rather than changing the production Chromium configuration.
In `@scripts/generate-site-map.ts`:
- Around line 42-45: Update documentedRedirectTargets in
scripts/generate-site-map.ts to use the actual
/differentials/presentations/[slug] route parameter. Regenerate docs/site-map.md
so the corresponding entry reflects [slug], and update the relevant assertion in
tests/site-map.test.ts to expect the corrected destination.
In `@supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql`:
- Around line 2-11: Use concurrent index DDL for the GIN index in
supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql (lines
2-11), the canonical-alias index in
supabase/migrations/20260717010000_harden_rag_scalability_patch.sql (lines 5-6),
and the obsolete index removal in
supabase/migrations/20260717010000_harden_rag_scalability_patch.sql (line 116).
Ensure these migrations use the repository’s non-transactional mechanism
required for concurrent operations.
In `@tests/audit-navigation-auth-regressions.test.ts`:
- Line 129: Align all dashboard H1 assertions to the canonical accessible name:
update tests/audit-navigation-auth-regressions.test.ts at lines 129-129,
tests/ui-accessibility.spec.ts at lines 51-51, and tests/ui-smoke.spec.ts at
lines 870-870 and 1265-1265 to consistently assert the same name, using the name
required by the dashboard contract.
In `@tests/supabase-schema.test.ts`:
- Around line 1219-1222: Update the latest migration assertion in the
migrationFiles test to expect
20260717173000_reassert_supabase_admin_default_privileges.sql, matching the
actual final migration returned by the existing sorted list.
In `@tests/ui-tools.spec.ts`:
- Line 1623: Update mockAnswerDashboardApi to return service-detail records for
13YARN and City East instead of 404 responses for non-form kinds. Add the 13YARN
response at tests/ui-tools.spec.ts lines 1623-1623, the City East record at
lines 1644-1645, and ensure the direct service entry resolves through this
detail mock at lines 1688-1688.
---
Outside diff comments:
In `@src/lib/rag.ts`:
- Around line 2514-2527: Preserve caller cancellation in the text candidate
retrieval flow by wrapping the searchTextChunkCandidates await in src/lib/rag.ts
lines 2514-2527 with args.signal-aware cancellation, while retaining the
existing post-await throwIfAborted check and telemetry updates. In
src/lib/rag-candidate-sources.ts lines 185-207, retain internal signal
propagation so the underlying RPC continues receiving abortSignal; no direct
change is required there beyond preserving that support.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2ab7417a-cfb7-41a1-af1b-7cfdee0966ac
📒 Files selected for processing (24)
docs/codebase-index.mddocs/site-map.mdplaywright.config.tsscripts/check-github-action-pins.mjsscripts/generate-site-map.tssrc/app/layout.tsxsrc/app/page.tsxsrc/components/clinical-dashboard/master-search-header.tsxsrc/components/forms/forms-home-page.tsxsrc/components/services/services-navigator-page.tsxsrc/lib/rag-candidate-sources.tssrc/lib/rag.tssupabase/drift-manifest.jsonsupabase/migrations/20260714180000_patch_rag_and_corrector_scalability.sqlsupabase/migrations/20260714190000_document_table_facts_trgm_idx.sqlsupabase/migrations/20260717010000_harden_rag_scalability_patch.sqlsupabase/schema.sqltests/audit-content-services-regressions.test.tstests/audit-navigation-auth-regressions.test.tstests/site-map.test.tstests/supabase-schema.test.tstests/ui-accessibility.spec.tstests/ui-smoke.spec.tstests/ui-tools.spec.ts
Comment on lines
+2
to
+11
| create index if not exists document_table_facts_text_trgm_idx | ||
| on public.document_table_facts using gin ( | ||
| lower( | ||
| coalesce(table_title, '') || ' ' || | ||
| coalesce(row_label, '') || ' ' || | ||
| coalesce(clinical_parameter, '') || ' ' || | ||
| coalesce(threshold_value, '') || ' ' || | ||
| coalesce(action, '') | ||
| ) extensions.gin_trgm_ops | ||
| ); |
Contributor
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Avoid blocking production writes with normal index DDL.
These GIN index operations can take strong locks on populated retrieval tables during deployment.
supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql#L2-L11: create the index concurrently or use the repository’s non-transactional migration mechanism.supabase/migrations/20260717010000_harden_rag_scalability_patch.sql#L5-L6: create the canonical-alias index concurrently.supabase/migrations/20260717010000_harden_rag_scalability_patch.sql#L116-L116: drop the obsolete index concurrently.
🧰 Tools
🪛 Squawk (2.59.0)
[warning] 2-11: During normal index creation, table updates are blocked, but reads are still allowed. Use concurrently to avoid blocking writes.
(require-concurrent-index-creation)
📍 Affects 2 files
supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql#L2-L11(this comment)supabase/migrations/20260717010000_harden_rag_scalability_patch.sql#L5-L6supabase/migrations/20260717010000_harden_rag_scalability_patch.sql#L116-L116
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql` around
lines 2 - 11, Use concurrent index DDL for the GIN index in
supabase/migrations/20260714190000_document_table_facts_trgm_idx.sql (lines
2-11), the canonical-alias index in
supabase/migrations/20260717010000_harden_rag_scalability_patch.sql (lines 5-6),
and the obsolete index removal in
supabase/migrations/20260717010000_harden_rag_scalability_patch.sql (line 116).
Ensure these migrations use the repository’s non-transactional mechanism
required for concurrent operations.
Source: Linters/SAST tools
BigSimmo
changed the title
Restore dashboard H1 expectations to Clinical Guide, mock service-detail registry records so 13YARN/City East load, drop forms assertions that conflicted with the live Refine/pathway UI, restore mode-menu click safety handlers, and correct the presentations redirect sitemap slug. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
8 tasks
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reducedMotioninto supported config contexts.Verification
node --max-old-space-size=8192 ./node_modules/typescript/bin/tsc -p .tmp-tsconfig-no-worktrees.json --noEmitnode scripts/run-vitest.mjs run tests/rag-abort-signal.test.ts tests/rag-classifier-memo.test.ts tests/rag-variant-early-exit.test.ts tests/supabase-schema.test.tsworktrees/*paths outside repo scope and surfaces unrelated type errors.Risk and rollout
4b98cea8cand re-run the verification commands above.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Summary by CodeRabbit
New Features
Bug Fixes
Documentation