Add Database workflow skills catalog and workflows skill#837
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughWalkthroughAdds repository-local workflow skills and agent interfaces, a risk-scoped productivity planning engine, CLI commands for local checks and evidence, portable external workflow resolution, updated command wiring, and comprehensive planner and CLI tests. ChangesProductivity workflow system
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant productivity-workflow
participant productivity-core
participant ci-change-scope
Operator->>productivity-workflow: Select workflow and options
productivity-workflow->>productivity-core: Build scoped workflow plan
productivity-core->>ci-change-scope: Read changed-file scope
ci-change-scope-->>productivity-core: Return risk flags
productivity-core-->>productivity-workflow: Return local checks and approval gates
productivity-workflow-->>Operator: Render plan or run local checks
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.3)scripts/ci-change-scope.mjsFile contains syntax errors that prevent linting: Line 76: Expected an expression for the left hand side of the 🔧 ESLint
scripts/ci-change-scope.mjsParsing error: Merge conflict marker encountered. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/productivity-core.mjs`:
- Around line 28-33: Extend the clinical classification matcher in the clinical
array to include src/lib/ranking*.ts changes, ensuring approvalChecks() applies
the production-readiness gate to ranking-only modifications. Add a regression
test covering a change limited to a ranking file and verify it is classified as
clinical.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c1fc65b7-49db-465f-b961-2edb4da18db1
📒 Files selected for processing (27)
.agents/skills/clinical-change-proof/SKILL.md.agents/skills/clinical-change-proof/agents/openai.yaml.agents/skills/database-flightplan/SKILL.md.agents/skills/database-flightplan/agents/openai.yaml.agents/skills/database-skills.md.agents/skills/live-design-sweep/SKILL.md.agents/skills/live-design-sweep/agents/openai.yaml.agents/skills/operator-closeout/SKILL.md.agents/skills/operator-closeout/agents/openai.yaml.agents/skills/rag-change-lab/SKILL.md.agents/skills/rag-change-lab/agents/openai.yaml.agents/skills/session-lifecycle/SKILL.md.agents/skills/session-lifecycle/agents/openai.yaml.agents/skills/verify-triage-fix/SKILL.md.agents/skills/verify-triage-fix/agents/openai.yaml.agents/skills/workflows/SKILL.md.agents/skills/workflows/agents/openai.yaml.gitignoreAGENTS.mddocs/branch-review-ledger.mddocs/productivity-workflows.mdpackage.jsonscripts/ci-change-scope.mjsscripts/external-workflow.mjsscripts/productivity-core.mjsscripts/productivity-workflow.mjstests/productivity-workflow.test.ts
| clinical: [ | ||
| /^src\/app\/api\/(?:answer|differentials|documents|ingestion|medications|registry|search)/, | ||
| /^src\/lib\/(?:rag|retrieval|clinical|answer|citation|evidence|source|owner-scope|query-privacy)/, | ||
| /^supabase\//, | ||
| /^docs\/(?:clinical-governance|privacy-impact|samd-|source-governance)/, | ||
| ], |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Classify ranking changes as clinical to preserve the production-readiness gate.
src/lib/ranking*.ts is retrieval-only, so approvalChecks() omits npm run check:production-readiness, contrary to AGENTS.md Line 313. Extend this matcher and add a ranking-only regression test.
Proposed fix
clinical: [
/^src\/app\/api\/(?:answer|differentials|documents|ingestion|medications|registry|search)/,
- /^src\/lib\/(?:rag|retrieval|clinical|answer|citation|evidence|source|owner-scope|query-privacy)/,
+ /^src\/lib\/(?:rag|retrieval|ranking|clinical|answer|citation|evidence|source|owner-scope|query-privacy)/,📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| clinical: [ | |
| /^src\/app\/api\/(?:answer|differentials|documents|ingestion|medications|registry|search)/, | |
| /^src\/lib\/(?:rag|retrieval|clinical|answer|citation|evidence|source|owner-scope|query-privacy)/, | |
| /^supabase\//, | |
| /^docs\/(?:clinical-governance|privacy-impact|samd-|source-governance)/, | |
| ], | |
| clinical: [ | |
| /^src\/app\/api\/(?:answer|differentials|documents|ingestion|medications|registry|search)/, | |
| /^src\/lib\/(?:rag|retrieval|ranking|clinical|answer|citation|evidence|source|owner-scope|query-privacy)/, | |
| /^supabase\//, | |
| /^docs\/(?:clinical-governance|privacy-impact|samd-|source-governance)/, | |
| ], |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/productivity-core.mjs` around lines 28 - 33, Extend the clinical
classification matcher in the clinical array to include src/lib/ranking*.ts
changes, ensuring approvalChecks() applies the production-readiness gate to
ranking-only modifications. Add a regression test covering a change limited to a
ranking file and verify it is classified as clinical.
|
@copilot resolve the merge conflicts on this branch. |
Head branch was pushed to by a user without write access
…-review-ledger.md
Merge conflicts resolved in commit
|
Summary
.agents/skills/database-skills.mddescribing all local Database skills for this worktree.workflowsskill definition at.agents/skills/workflows/SKILL.mdexplaining each workflow skill and recommended usage.workflowsinterface prompt metadata file at.agents/skills/workflows/agents/openai.yaml.Verification
git statusconfirmed only the intended three untracked skill files before staging.git add+git commitcreated commitd22a9894ewith the three workflow files.git pushpushed the branch toorigin/codex/chat-ensure-unique-tree-pr-94f3.Risk and rollout
d22a9894eif needed.Summary by CodeRabbit
New Features
Documentation
Tests