chore: apply 51278a70d remediations onto origin/main#857
Conversation
…8-merge-20260718-clean
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…8-merge-20260718-clean-final
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac1773f050
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| contextOptions: { | ||
| reducedMotion: "no-preference", |
There was a problem hiding this comment.
Because the required Production UI lane runs npm run test:e2e:pr, which selects --project=chromium, setting the Chromium project to reducedMotion: "no-preference" makes every production Chromium spec run with animations enabled again. That contradicts the suite-level guard immediately above, which documents known click races in ui-stress/ui-smoke; a single dock-transition assertion should opt out locally with page.emulateMedia(...) instead of weakening the whole required UI gate.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Committed
1034f76(fix: scope reduced-motion override to dock test) on branchwork. - Restored the Chromium Playwright project to inherit the suite-wide reduced-motion configuration instead of overriding it with
no-preference, keeping production UI specs protected from animation-related click races. playwright.config.tsL45-L60 - Scoped the animation opt-out to the single bottom search dock transition assertion with
page.emulateMedia({ reducedMotion: "no-preference" }), so that test can still verify the transform transition locally. tests/ui-tools.spec.tsL1016-L1022 - Created PR metadata with the
make_prtool using titlefix: scope reduced-motion override to dock test.
Testing
- ✅
npm run workflow:flightplan -- --write-evidence --files playwright.config.ts - ✅
git diff --check ⚠️ npm run test:focused -- --files tests/ui-tools.spec.ts,playwright.config.ts— focused runner refused test/config path selection and instructed running the full unit suite.⚠️ npm run test -- --run tests/ui-tools.spec.ts— could not run becausenode_modules/vitest/vitest.mjsis missing in this workspace; current runtime is Nodev20.20.2.
Worktree
- Current branch:
work. - Worktree is clean after commit.
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd832bbc50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CI triageCI failed on this PR. Automated classification of the 3 failed job(s):
Compared with main CI run #3291 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Pull request was closed
|
@copilot resolve the merge conflicts on this branch. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07eeeca259
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(corrector).toContain("word % tok"); | ||
| expect(corrector).toContain("limit 32"); | ||
| expect(corrector).toContain("min_sim real default 0.45"); | ||
| if (corrector.includes("set pg_trgm.similarity_threshold = 0.3")) { |
There was a problem hiding this comment.
In this clinical-query corrector guard, the change removes the assertions that the SQL still exposes min_sim real default 0.45 and actually applies best_sim >= min_sim; with only the remaining indexed-probe checks, a schema or migration can start rewriting low-similarity clinical search terms and this test will still pass. Because this function rewrites user clinical queries, the bounded-similarity gate is the safety behavior the test name promises to protect; keep an explicit assertion or executable check for the threshold.
Useful? React with 👍 / 👎.
Summary
51278a70dproduction-readiness remediation on the latest mainline by porting route/sitemap assertion alignment and schema drift-manifest synchronization.Verification
Risk and rollout