fix: complete design-audit registry and forms-pathway UI fixes#858
fix: complete design-audit registry and forms-pathway UI fixes#858BigSimmo wants to merge 13 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR adds abort propagation and coalescing metrics to RAG retrieval, disables unsupported pathway UI in forms search, widens Home query parameter typing, and updates provenance, navigation, schema, and browser regression assertions. ChangesApplication behavior updates
Contracts and validation
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant searchChunksWithTelemetry
participant analyzeQueryWithClassifierFallback
participant callVersionedRetrievalRpc
participant SupabaseRPC
Caller->>searchChunksWithTelemetry: provide AbortSignal
searchChunksWithTelemetry->>analyzeQueryWithClassifierFallback: forward signal
analyzeQueryWithClassifierFallback->>analyzeQueryWithClassifierFallback: await in-flight classifier work
searchChunksWithTelemetry->>callVersionedRetrievalRpc: forward signal
callVersionedRetrievalRpc->>SupabaseRPC: execute RPC with abortSignal
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1153019985
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #3300 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
src/lib/rag-candidate-sources.ts (1)
47-53: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winModel the RPC helper as a thenable builder
supabase.rpc()returns aPostgrestFilterBuilder, andabortSignal()returnsthis, so these local RPC types should bePromiseLike/builder-shaped instead ofPromise-shaped.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/rag-candidate-sources.ts` around lines 47 - 53, Update RpcResult, AbortableRpc, and SupabaseRpcClient.rpc to model the Supabase PostgrestFilterBuilder as a thenable builder rather than a Promise-returning value. Represent the RPC result with PromiseLike-compatible behavior and ensure abortSignal returns the same builder instance while remaining awaitable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@playwright.config.ts`:
- Around line 47-49: Update the Chromium project configuration near the
suite-wide reduced-motion setting to preserve reduced-motion as "reduce" for
production Chromium specs; move the "no-preference" override from the top-level
contextOptions into only the narrower project or per-test configuration that
requires it, such as the reduced-motion accessibility spec.
In `@src/components/ClinicalDashboard.tsx`:
- Around line 3719-3721: The UniversalSearchAlsoMatches render in
ClinicalDashboard must appear after the owning mode’s primary results for tools
and favourites. Move the non-answer render from the current pre-results slot to
the existing post-results slot near the corresponding results components,
including the analogous branch around the second referenced location, while
preserving answer-mode behavior and avoiding duplicate rendering.
In `@src/components/route-error-boundary.tsx`:
- Line 62: Update the error heading’s focus styling in route-error-boundary so
its outline uses the focus state rather than only focus-visible. Preserve the
existing outline width, offset, and color, ensuring the recovery heading always
displays a ring when focused.
In `@src/lib/rag-candidate-sources.ts`:
- Around line 91-104: Update both call sites of callVersionedRetrievalRpc in
rag.ts, including the hybrid and vector-fallback retrieval paths, to pass the
available caller AbortSignal as the new final argument. Preserve all existing
RPC arguments and behavior while ensuring both retrieval flows can be cancelled.
In `@src/lib/rag.ts`:
- Around line 1390-1402: Update the catch block around awaitWithCallerSignal to
check opts?.signal?.aborted before existing error classification; when the
caller signal is aborted, rethrow opts.signal.reason regardless of its type or
name, while preserving the current AbortError handling and deterministic
analysis fallback for non-cancellation failures.
---
Nitpick comments:
In `@src/lib/rag-candidate-sources.ts`:
- Around line 47-53: Update RpcResult, AbortableRpc, and SupabaseRpcClient.rpc
to model the Supabase PostgrestFilterBuilder as a thenable builder rather than a
Promise-returning value. Represent the RPC result with PromiseLike-compatible
behavior and ensure abortSignal returns the same builder instance while
remaining awaitable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 52fdc829-8118-4fed-811e-667414817e31
📒 Files selected for processing (11)
playwright.config.tssrc/app/page.tsxsrc/components/ClinicalDashboard.tsxsrc/components/forms/forms-search-results-page.tsxsrc/components/route-error-boundary.tsxsrc/lib/rag-candidate-sources.tssrc/lib/rag.tstests/audit-content-services-regressions.test.tstests/audit-navigation-auth-regressions.test.tstests/supabase-schema.test.tstests/ui-tools.spec.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1153019985
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Gate the mock Refine bar/panel behind supportsPathwayClaims so forms search no longer advertises coming-soon pathway filters in CI. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Keep the forms Refine gating fix on top of the merged sitemap/ledger remediation so #858 can fast-forward merge cleanly. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Restore suite-wide Chromium reduced-motion, keep Also matches after primary tools/favourites results, preserve programmatic error-heading focus outlines, and thread AbortSignal through hybrid retrieval RPCs. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Keep suite-wide reducedMotion for Chromium stability, and only restore motion in the phone dock scroll-hide journey that measures transition duration. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2188568939
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Do not treat AbortError as a recoverable hybrid-RPC failure when lexical candidates exist; cancelled requests must stop instead of continuing through metadata, memory, rerank, and cache work. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Closing as superseded by merged PR #861, which contains the corrected reduced-motion handling, retrieval abort propagation, neutral Forms claims, and resolved review threads with green exact-head CI. Branch retained; no branch deletion performed. |
Summary
Verification
npm run test:e2e -- tests/ui-tools.spec.ts --project=chromium --grep "forms mode shows registry-backed form records without unsupported pathway claims|forms search mockup is usable without horizontal overflow on mobile"(blocked by another active Playwright command in a sibling worktree: PID 89792).npm run verify:uisafely.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Risk and rollout
115301998,551767e6e,ef52a2539,75d8ac3db, and8f280b980frommain.Summary by CodeRabbit
User Experience
Bug Fixes
Tests