Fix(differentials): route Compare selected to resolved presentation workflow

[BigSimmo]

Summary

• "Compare selected" on Differentials builds a same-origin relative presentations href with selected IDs, avoiding restricted-viewport / bad-origin redirect issues.
• Client navigation helpers stay snapshot-free so the home page does not pull the differentials JSON into the client bundle; server route resolution remains on the presentations endpoint.
• Supersedes Fix(differentials): route "Compare selected" directly to resolved presentation workflow #883/Fix(differentials): route "Compare selected" directly to resolved presentation workflow #882 (identical patch; Fix(differentials): route "Compare selected" directly to resolved presentation workflow #882 is the duplicate) with a policy-compliant description.

Verification

• npm run test -- --run tests/differentials-navigation.test.ts (4 passed)
• npx prettier --check on touched navigation/test files
• UI verification not run: local ensure/Playwright blocked here by Google font fetch failures; CI Production UI covers differentials journeys.

Risk and rollout

• Risk: medium; changes compare CTA href construction and presentations redirect Location handling for selected diagnosis IDs.
• Rollback: revert the merge commit; Compare selected falls back to prior redirect-based flow on the previous revision.
• Provider or production effects: None.

Clinical Governance Preflight

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

  

Summary by CodeRabbit

• New Features

  • Added consistent navigation for differential searches, presentations, diagnoses, and selected comparisons.
  • Preserved search terms and selected items when moving between differential views.

• Bug Fixes

  • Redirects now use same-origin relative paths, improving navigation reliability across environments.
  • Fixed routing for comparison and catalogue links across mobile and desktop views.

• Tests

  • Added coverage for query handling, selected-item preservation, and redirect behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c886259-194f-473f-873a-b43006ee448a

📥 Commits

Reviewing files that changed from the base of the PR and between 45ed28a and 9145f18.

📒 Files selected for processing (5)

• src/app/differentials/presentations/route.ts
• src/components/clinical-dashboard/differentials-home.tsx
• src/lib/differentials-navigation.ts
• tests/audit-navigation-auth-regressions.test.ts
• tests/differentials-navigation.test.ts

---

📝 Walkthrough

Walkthrough

The PR centralizes differential navigation URL construction, updates dashboard links to preserve query and selection state, and changes the presentations route to return a relative 307 redirect. Tests cover URL encoding, client-safe imports, bind-address handling, and redirect expectations.

Changes

Differentials navigation

Layer / File(s)	Summary
Shared client navigation helpers and dashboard integration src/lib/differentials-navigation.ts, src/components/clinical-dashboard/differentials-home.tsx	Adds shared builders for trimmed q and ids parameters, then uses them for presentation, diagnosis, compare, and fallback navigation links.
Relative presentations redirect and validation src/app/differentials/presentations/route.ts, tests/audit-navigation-auth-regressions.test.ts, tests/differentials-navigation.test.ts	Builds a relative redirect location and returns it with HTTP 307; tests verify preserved parameters, relative URLs, and client-safe helper behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• BigSimmo/Database#882: Introduces and uses the same differential navigation helpers.
• BigSimmo/Database#883: Overlaps on the redirect, shared helpers, dashboard links, and related tests.
• BigSimmo/Database#739: Covers legacy presentations redirect behavior.

Suggested labels: codex

Suggested reviewers: cursoragent

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: rerouting Compare selected to the presentations workflow.
Description check	✅ Passed	The description covers Summary, Verification, Risk and rollout, and Clinical Governance; only Notes is left blank.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/differentials-compare-href-1ae0

---

_{Comment @coderabbitai help to get the list of available commands.}

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.