Align Therapy Compass home with shared mode-home template#887
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 WalkthroughWalkthroughTherapy Compass now uses the shared mode-home template, enables the shared search composer, hides navigation on the home route, and adjusts landmark/footer rendering by pathname. Review Queue navigation was removed, and structural wiring tests cover the home composition. ChangesTherapy Compass home and workspace
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant TherapyCompassLayout
participant GlobalSearchShell
participant TherapyCompassWorkspace
participant HomeScreen
participant ModeHomeTemplate
TherapyCompassLayout->>GlobalSearchShell: mount therapy-compass shell
GlobalSearchShell->>TherapyCompassWorkspace: render workspace
TherapyCompassWorkspace->>HomeScreen: render home route
HomeScreen->>ModeHomeTemplate: provide home actions and composer slot
ModeHomeTemplate->>HomeScreen: render mode-home content
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bab547705
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bab547705
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #3410 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Home already renders ModeHomeVerificationFooter via ModeHomeTemplate; skip the workspace footer on /therapy-compass so the notice appears once. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Home already renders ModeHomeMain; keep the workspace shell as a div on /therapy-compass so screen readers see a single main landmark. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
cc1385f to
579e9f1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 579e9f1e13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/therapy-compass/workspace.tsx`:
- Around line 75-83: Update the Tag selection in the workspace component to use
"main" when either asMain or b.error is true, preserving "div" otherwise. Extend
the landmark test to cover the b.error state while keeping the existing home and
non-home behavior unchanged.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 773a4774-7d14-4a2f-9566-999d1d19cfbb
📒 Files selected for processing (5)
src/app/therapy-compass/layout.tsxsrc/components/therapy-compass/nav.tsxsrc/components/therapy-compass/screens/home-screen.tsxsrc/components/therapy-compass/workspace.tsxtests/therapy-compass-mode-wiring.test.ts
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. The branch was updated while autofix was in progress. Please try again. |
Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Summary
/therapy-compassby rendering the workspace shell as a non-main wrapper when ModeHomeMain owns the landmark.Verification
tests/therapy-compass-mode-wiring.test.ts, 5 passed)npx prettier --checkon touched therapy workspace/test filesRisk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)